Merge pull request #581 from pjbreaux/bugfix.services_12_1_0

During functional testing against 12.1.0, sys/application test fails and errors out

Author: zancas

f5/bigip/tm/sys/application.py

@@ -111,7 +111,7 @@ def _create(self, **kwargs):
         '''
 
         try:
-            super(Service, self)._create(**kwargs)
+            return super(Service, self)._create(**kwargs)
         except HTTPError as ex:
             if "The configuration was updated successfully but could not be " \
                     "retrieved" not in ex.response.text:

test/functional/tm/sys/test_sys_application.py

@@ -13,13 +13,14 @@
 # limitations under the License.
 #
 
-from pprint import pprint as pp
 from requests import HTTPError
 
-pp(__file__)
+from f5.bigip.tm.sys.application import Service
+from f5.bigip.tm.sys.application import Template
+
 TESTDESCRIPTION = 'TESTDESCRIPTION'
 
-# Application Service Dictionary
+# Application service dictionary, which matches JSON structure
 sections = {
     'implementation': '',
     'presentation': ''
@@ -53,19 +54,23 @@ def setup_template_test(request, bigip, name, partition):
 
     def teardown():
         delete_resource(test_template)
+
     request.addfinalizer(teardown)
     test_template = template_s.template.create(
         name=name,
         partition=partition,
         actions=definition
     )
+    assert isinstance(test_template, Template)
+    assert id(test_template) != id(template_s.template)
     return template_s, test_template
 
 
 def setup_service_test(request, bigip, name, partition, template_name, tgroup):
     service_s = setup_service_collection_test(request, bigip)
 
     def teardown():
+        # Delete the service first, then the template
         delete_resource(test_service)
         delete_resource(test_template)
 
@@ -75,12 +80,16 @@ def teardown():
         partition=partition,
         actions=definition
     )
+    assert isinstance(test_template, Template)
+    assert id(test_template) != id(template_factory)
     test_service = service_s.service.create(
         name=name,
         partition=partition,
         template=template_name,
         trafficGroup=tgroup
     )
+    assert isinstance(test_service, Service)
+    assert id(test_service) != id(service_s.service)
     request.addfinalizer(teardown)
     return service_s, test_service