Fixes #1317: BIGIP> Add support for lsnpool (CGNAT) (#1321)

* Fixes #1317

Problem: Add support for lsnpool(CGNAT)

Analysis:
Added two things:
- LSN log profile collection and resource + corresponding tests
- Add missing ALG profile - IPsecALG

Tests:
- Added functional tests for lsnpool and lsn log profile
- Test results against BIGIP with 14.0.0 build
cmd: py.test test_lsnpool.py --ignore=f5/ --bigip=172.27.77.41 -vs

test_lsnpool.py::TestLSNPool::test_create_no_args PASSED
test_lsnpool.py::TestLSNPool::test_create PASSED
test_lsnpool.py::TestLSNPool::test_create_with_logProfile_without_logPub PASSED
test_lsnpool.py::TestLSNPool::test_create_with_logProfile PASSED
test_lsnpool.py::TestLSNPool::test_refresh PASSED
test_lsnpool.py::TestLSNPool::test_update PASSED
test_lsnpool.py::TestLSNPool::test_exists PASSED
test_lsnpool.py::TestLSNPool::test_stats PASSED
test_lsnpool.py::TestLSNPool::test_create_with_nondefault_mode PASSED
test_lsnpool.py::TestLSNPool::test_create_with_invalid_mode PASSED
test_lsnpool.py::TestLSNPool::test_create_with_member PASSED
test_lsnpool.py::TestLSNPool::test_virtual_with_pool PASSED
test_lsnpool.py::TestLSNPool::test_collection PASSED
test_lsnpool.py::TestLSNPoolLogProfile::test_create_no_args PASSED
test_lsnpool.py::TestLSNPoolLogProfile::test_create PASSED
test_lsnpool.py::TestLSNPoolLogProfile::test_update PASSED
test_lsnpool.py::TestLSNPoolLogProfile::test_exists PASSED

* Issues:
Fixes #1317

Problem: Fixing CI pipeline failures

Analysis:
Added following things:
- Fixed test cases failures on 11.5.4
- Fixed the flake8 issues
- Added unit tests

Tests:
-Ran functional and unit tests against 11.5.4, 11.6.1, 12.0.0, 14.0.0

* Fixes #1317

Problem: 11.6.0 : Fixing CI pipeline failures

Analysis:
- LSN pool Stats functional test is fixed
- 'Flake8 f5' failures are addressed
- Syntax error corrected.

Tests:
-Ran functional and unit tests against 11.6.0. Tests passing now.

* Fixes #1317

Problem:  Fixing flake8 failures in python3

Analysis:
- cmd: sed -i sed 's/\r$//' <file_name>
- Ref: [H903] Use only UNIX style newlines (``n``), not Windows style (``rn``)

Tests:
-Ran functional and unit tests.

* Fixes #1317
Problem:  Addressing review comments

Analysis:
- Addressing review comments

Tests:
- Ran functional and unit tests.
- Ran flake8 f5

Author: PrashantSunkari

f5/bigip/tm/ltm/__init__.py

@@ -1,4 +1,4 @@
-# coding=utf-8
+# coding=utf-8
 #
 # Copyright 2015-2016 F5 Networks Inc.
 #
@@ -33,6 +33,8 @@
 from f5.bigip.tm.ltm.data_group import Data_Group
 from f5.bigip.tm.ltm.default_node_monitor import Default_Node_Monitor
 from f5.bigip.tm.ltm.ifile import Ifiles
+from f5.bigip.tm.ltm.lsn_pools import LSN_Log_Profiles
+from f5.bigip.tm.ltm.lsn_pools import LSN_Pools
 from f5.bigip.tm.ltm.monitor import Monitor
 from f5.bigip.tm.ltm.nat import Nats
 from f5.bigip.tm.ltm.node import Nodes
@@ -58,6 +60,8 @@ def __init__(self, tm):
             Data_Group,
             Default_Node_Monitor,
             Ifiles,
+            LSN_Log_Profiles,
+            LSN_Pools,
             Monitor,
             Nats,
             Nodes,

f5/bigip/tm/ltm/lsn_pools.py

@@ -0,0 +1,74 @@
+# coding=utf-8
+#
+#  Copyright 2014-2016 F5 Networks Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""BIG-IP® Local Traffic Manager™ (LTM®) LSN pool module.
+
+REST URI
+    ``http://localhost/mgmt/tm/ltm/lsn-pool``
+    ``http://localhost/mgmt/tm/ltm/lsn-log-profile``
+
+GUI Path
+    ``Carrier Grade NAT --> LSN Pools``
+    ``Carrier Grade NAT --> Logging Profiles --> LSN``
+
+REST Kind
+    ``tm:ltm:lsn-pool:*``
+    ``tm:ltm:lsn-log-profile:*``
+"""
+
+
+from f5.bigip.resource import Collection
+from f5.bigip.resource import Resource
+
+
+class LSN_Pools(Collection):
+    """BIG-IP® LTM LSN pool collection"""
+    def __init__(self, ltm):
+        super(LSN_Pools, self).__init__(ltm)
+        self._meta_data['allowed_lazy_attributes'] = [LSN_Pool]
+        self._meta_data['attribute_registry'] =\
+            {'tm:ltm:lsn-pool:lsn-poolstate': LSN_Pool}
+
+
+class LSN_Pool(Resource):
+    """BIG-IP® LTM LSN pool resource"""
+    def __init__(self, lsnpool_s):
+        super(LSN_Pool, self).__init__(lsnpool_s)
+        self._meta_data['required_json_kind'] = 'tm:ltm:lsn-pool:lsn-poolstate'
+        self._meta_data['allowed_lazy_attributes'] = [LSN_Log_Profile]
+        self._meta_data['attribute_registry'] = {
+            'tm:ltm:lsn-log-profile:lsn-log-profilestate': LSN_Log_Profile}
+
+
+class LSN_Log_Profiles(Collection):
+    """BIG-IP® LTM LSN pool log profile collection"""
+    def __init__(self, profile):
+        super(LSN_Log_Profiles, self).__init__(profile)
+        self._meta_data['allowed_lazy_attributes'] = [LSN_Log_Profile]
+        self._meta_data['required_json_kind'] = (
+            'tm:ltm:lsn-log-profile:lsn-log-profilecollectionstate')
+        self._meta_data['attribute_registry'] = \
+            {'tm:ltm:lsn-log-profile:lsn-log-profilestate': LSN_Log_Profile}
+        self._meta_data['minimum_version'] = '11.6.0'
+
+
+class LSN_Log_Profile(Resource):
+    """BIG-IP® LTM LSN pool log profile resource"""
+    def __init__(self, LSNLogProfile_s):
+        super(LSN_Log_Profile, self).__init__(LSNLogProfile_s)
+        self._meta_data['required_json_kind'] = (
+            'tm:ltm:lsn-log-profile:lsn-log-profilestate')

f5/bigip/tm/ltm/profile.py

@@ -60,6 +60,7 @@ def __init__(self, ltm):
             Icaps,
             Iiops,
             Ipothers,
+            Ipsecalgs,
             Mblbs,
             Mssqls,
             Ntlms,
@@ -545,6 +546,24 @@ def __init__(self, Ipothers):
             'tm:ltm:profile:ipother:ipotherstate'
 
 
+class Ipsecalgs(Collection):
+    """BIG-IP® IPsecALG profile collection."""
+    def __init__(self, profile):
+        super(Ipsecalgs, self).__init__(profile)
+        self._meta_data['allowed_lazy_attributes'] = [Ipsecalg]
+        self._meta_data['attribute_registry'] = \
+            {'tm:ltm:profile:ipsecalg:ipsecalgstate': Ipsecalg}
+        self._meta_data['minimum_version'] = '13.0.0'
+
+
+class Ipsecalg(Resource):
+    """BIG-IP® IPsecALG resource."""
+    def __init__(self, Ipsecalgs):
+        super(Ipsecalg, self).__init__(Ipsecalgs)
+        self._meta_data['required_json_kind'] = \
+            'tm:ltm:profile:ipsecalg:ipsecalgstate'
+
+
 class Mblbs(Collection):
     """BIG-IP® Mblb profile collection."""
     def __init__(self, profile):