move _check_load_parameters into Resource

Author: zancas

f5/bigip/resource.py

@@ -213,18 +213,6 @@ def _set_meta_data_uri(self):
             self._meta_data['container']._meta_data['uri'] + endpoint + '/'
         self._meta_data['uri'] = final_uri
 
-    def _check_create_parameters(self, **kwargs):
-        """Params given to create should satisfy required params.
-
-        :params: kwargs
-        :raises: MissingRequiredCreateParameter
-        """
-        rset = self._meta_data['required_creation_parameters']
-        check = self._missing_required_parameters(rset, **kwargs)
-        if check:
-            error_message = 'Missing required params: %s' % check
-            raise MissingRequiredCreationParameter(error_message)
-
     def _check_command_parameters(self, **kwargs):
         """Params given to exec_cmd should satisfy required params.
 
@@ -819,6 +807,18 @@ def _activate_URI(self, selfLinkuri):
                                 'creation_uri_frag': frag,
                                 'allowed_lazy_attributes': attrs})
 
+    def _check_create_parameters(self, **kwargs):
+        """Params given to create should satisfy required params.
+
+        :params: kwargs
+        :raises: MissingRequiredCreateParameter
+        """
+        rset = self._meta_data['required_creation_parameters']
+        check = self._missing_required_parameters(rset, **kwargs)
+        if check:
+            error_message = 'Missing required params: %s' % check
+            raise MissingRequiredCreationParameter(error_message)
+
     def _create(self, **kwargs):
         """wrapped by `create` override that in subclasses to customize"""
         if 'uri' in self._meta_data:

f5/bigip/test/test_resource.py

@@ -691,7 +691,7 @@ def test_check_load_parameters_fail(self):
         assert "['FAKELOAD']" in RLPEIO.value.message
 
     def test_check_create_parameters_fail(self):
-        p = PathElement(mock.MagicMock())
+        p = Resource(mock.MagicMock())
         p._meta_data['required_creation_parameters'] = set(['FAKECREATE'])
         with pytest.raises(MissingRequiredCreationParameter) as RCPEIO:
             p._check_create_parameters(FOOCREATE='FOOVAL')