During functional testing against 12.1.0, sys/application test fails and

errors out

Issues:
Fixes #580

Problem:
This is a bug in application.py where we expected the call to create an
application service to raise an HTTPError, which was happening in
versions prior to 12.1.0. This is now fixed on the BIG-IP and when
testing against 12.1.0, it revealed a bug in our code where (in the
happy path) we weren't returning the result from the call to
super()._create(). That was returning None as the object back from a
create call.

Analysis:
Added return to the super call in the overridden version of _create in
Service. Added checks in each of the functional tests to ensure that the
thing that is returned from a create is not None.

Tests:
Ran tests against 12.1.0 for this suite and 11.5.4

Author: Paul Breaux

f5/bigip/tm/sys/application.py

@@ -111,7 +111,7 @@ def _create(self, **kwargs):
         '''
 
         try:
-            super(Service, self)._create(**kwargs)
+            return super(Service, self)._create(**kwargs)
         except HTTPError as ex:
             if "The configuration was updated successfully but could not be " \
                     "retrieved" not in ex.response.text:

test/functional/tm/sys/test_sys_application.py

@@ -59,6 +59,7 @@ def teardown():
         partition=partition,
         actions=definition
     )
+    assert test_template is not None
     return template_s, test_template
 
 
@@ -75,12 +76,14 @@ def teardown():
         partition=partition,
         actions=definition
     )
+    assert test_template is not None
     test_service = service_s.service.create(
         name=name,
         partition=partition,
         template=template_name,
         trafficGroup=tgroup
     )
+    assert test_service is not None
     request.addfinalizer(teardown)
     return service_s, test_service