Move helper function out of class

Author: zancas

f5/bigip/resource.py

@@ -179,6 +179,21 @@ class AttemptedMutationOfReadOnly(F5SDKError):
     pass
 
 
+def _missing_required_parameters(rqset, **kwargs):
+    """Helper function to do operation on sets.
+
+    Checks for any missing required parameters.
+    Returns non-empty or empty list. With empty
+    list being False.
+
+    ::returns list
+    """
+    key_set = set(kwargs.keys())
+    required_minus_received = rqset - key_set
+    if required_minus_received != set():
+        return list(required_minus_received)
+
+
 class PathElement(LazyAttributeMixin):
     """Base class to represent a URI path element that does not contain data.
 
@@ -227,7 +242,7 @@ def _check_command_parameters(self, **kwargs):
         :raises: MissingRequiredCommandParameter
         """
         rset = self._meta_data['required_command_parameters']
-        check = self._missing_required_parameters(rset, **kwargs)
+        check = _missing_required_parameters(rset, **kwargs)
         if check:
             error_message = 'Missing required params: %s' % check
             raise MissingRequiredCommandParameter(error_message)
@@ -295,21 +310,6 @@ def _check_exclusive_parameters(self, **kwargs):
                         'together: "%s".' % cset
                 raise ExclusiveAttributesPresent(error)
 
-    @staticmethod
-    def _missing_required_parameters(rqset, **kwargs):
-        """Helper function to do operation on sets.
-
-        Checks for any missing required parameters.
-        Returns non-empty or empty list. With empty
-        list being False.
-
-        ::returns list
-        """
-        key_set = set(kwargs.keys())
-        required_minus_received = rqset - key_set
-        if required_minus_received != set():
-            return list(required_minus_received)
-
     @property
     def raw(self):
         """Display the attributes that the current object has and their values.
@@ -821,7 +821,7 @@ def _check_create_parameters(self, **kwargs):
         :raises: MissingRequiredCreateParameter
         """
         rset = self._meta_data['required_creation_parameters']
-        check = self._missing_required_parameters(rset, **kwargs)
+        check = _missing_required_parameters(rset, **kwargs)
         if check:
             error_message = 'Missing required params: %s' % check
             raise MissingRequiredCreationParameter(error_message)
@@ -888,7 +888,7 @@ def _check_load_parameters(self, **kwargs):
         :raises: MissingRequiredReadParameter
         """
         rset = self._meta_data['required_load_parameters']
-        check = self._missing_required_parameters(rset, **kwargs)
+        check = _missing_required_parameters(rset, **kwargs)
         if check:
             error_message = 'Missing required params: %s' % check
             raise MissingRequiredReadParameter(error_message)

f5/bigip/test/test_resource.py

@@ -16,6 +16,7 @@
 import pytest
 import requests
 
+from f5.bigip.resource import _missing_required_parameters
 from f5.bigip.resource import AttemptedMutationOfReadOnly
 from f5.bigip.resource import BooleansToReduceHaveSameValue
 from f5.bigip.resource import Collection
@@ -672,15 +673,15 @@ def test_missing_req_param_true(self):
         p = PathElement(mock.MagicMock())
         rqset = set(['FOOPAR1', 'FOOPAR2'])
         fakearg = {'FOOPAR1': 'FOOVAL'}
-        mrq = p._missing_required_parameters(rqset, **fakearg)
+        mrq = _missing_required_parameters(rqset, **fakearg)
         assert mrq
         assert mrq == ['FOOPAR2']
 
     def test_missing_req_param_false(self):
         p = PathElement(mock.MagicMock())
         rqset = set(['FOOPAR1'])
         fakearg = {'FOOPAR1': 'FOOVAL'}
-        mrq = p._missing_required_parameters(rqset, **fakearg)
+        mrq = _missing_required_parameters(rqset, **fakearg)
         assert not mrq
 
     def test_check_load_parameters_fail(self):