Fixes #315

Problem: Adds internal/external data-group support

Author: f5-rahm

f5/bigip/tm/ltm/data_group.py

@@ -36,21 +36,50 @@ def __init__(self, ltm):
         super(Data_Group, self).__init__(ltm)
         self._meta_data['allowed_lazy_attributes'] = [
             Internals,
-            Internal
+            Internal,
+            Externals,
+            External
         ]
 
 
 class Internals(Collection):
     def __init__(self, data_groups):
         super(Internals, self).__init__(data_groups)
         self._meta_data['allowed_lazy_attributes'] = [Internal]
-        self._meta_data['required_json_kind'] = u'tm:ltm:data-group:internal:internalcollectionstate'
-        self._meta_data['attribute_registry'] = {u'tm:ltm:data-group:internal:internalstate': Internal}
+        self._meta_data['required_json_kind'] = \
+            u'tm:ltm:data-group:internal:internalcollectionstate'
+        self._meta_data['attribute_registry'] = \
+            {u'tm:ltm:data-group:internal:internalstate': Internal}
         self._meta_data['uri'] = self._meta_data['uri'].replace('_', '-')
 
 
 class Internal(Resource):
     def __init__(self, internals):
         super(Internal, self).__init__(internals)
-        self._meta_data['required_json_kind'] = u'tm:ltm:data-group:internal:internalstate'
-        self._meta_data['required_creation_parameters'].update(('name', 'type', 'records'))
+        self._meta_data['required_json_kind'] = \
+            u'tm:ltm:data-group:internal:internalstate'
+        self._meta_data['required_creation_parameters'].update(('name', 'type', 'records'))
+
+    def update(self, **kwargs):
+        if 'type' in self.__dict__:
+            del self.__dict__['type']
+        return self._update(**kwargs)
+
+
+class Externals(Collection):
+    def __init__(self, data_groups):
+        super(Externals, self).__init__(data_groups)
+        self._meta_data['allowed_lazy_attributes'] = [External]
+        self._meta_data['required_json_kind'] =\
+            u'tm:ltm:data-group:external:externalcollectionstate'
+        self._meta_data['attribute_registry'] =\
+            {u'tm:ltm:data-group:external:externalstate': External}
+        self._meta_data['uri'] = self._meta_data['uri'].replace('_', '-')
+
+
+class External(Resource):
+    def __init__(self, externals):
+        super(External, self).__init__(externals)
+        self._meta_data['required_json_kind'] =\
+            u'tm:ltm:data-group:external:externalstate'
+        self._meta_data['required_creation_parameters'].update(('name', 'externalFileName'))

f5/bigip/tm/ltm/test/test_datagroup.py

@@ -0,0 +1,56 @@
+# Copyright 2015 F5 Networks Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import mock
+import pytest
+
+from f5.bigip import ManagementRoot
+from f5.bigip.resource import MissingRequiredCreationParameter
+from f5.bigip.tm.ltm.data_group import Internal, External
+
+
+@pytest.fixture
+def FakeData_Group_Internal():
+    fake_dg = mock.MagicMock()
+    fake_dg = Internal(fake_dg)
+    return fake_dg
+
+@pytest.fixture
+def FakeData_Group_External():
+    fake_dg = mock.MagicMock()
+    fake_dg = External(fake_dg)
+    return fake_dg
+
+
+class TestCreate(object):
+    def test_create_internal_two(self, fakeicontrolsession):
+        mgmt = ManagementRoot('172.16.44.15', 'admin', 'admin')
+        dg1 = mgmt.tm.ltm.data_group.internals.internal
+        dg2 = mgmt.tm.ltm.data_group.internals.internal
+        assert dg1 is not dg2
+
+    def test_create_external_two(self, fakeicontrolsession):
+        mgmt = ManagementRoot('172.16.44.15', 'admin', 'admin')
+        dg1 = mgmt.tm.ltm.data_group.externals.external
+        dg2 = mgmt.tm.ltm.data_group.externals.external
+        assert dg1 is not dg2
+
+    def test_create_internal_no_args(self, FakeData_Group_Internal):
+        with pytest.raises(MissingRequiredCreationParameter):
+            FakeData_Group_Internal.create()
+
+    def test_create_external_no_args(self, FakeData_Group_External):
+        with pytest.raises(MissingRequiredCreationParameter):
+            FakeData_Group_External.create()

f5/bigip/tm/sys/__init__.py

@@ -34,6 +34,7 @@
 from f5.bigip.tm.sys.db import Dbs
 from f5.bigip.tm.sys.dns import Dns
 from f5.bigip.tm.sys.failover import Failover
+from f5.bigip.tm.sys.file import File
 from f5.bigip.tm.sys.folder import Folders
 from f5.bigip.tm.sys.global_settings import Global_Settings
 from f5.bigip.tm.sys.httpd import Httpd
@@ -49,6 +50,7 @@ def __init__(self, tm):
         self._meta_data['allowed_lazy_attributes'] = [
             Config,
             Crypto,
+            File,
             Folders,
             Application,
             Performances,

f5/bigip/tm/sys/file.py

@@ -0,0 +1,57 @@
+# coding=utf-8
+#
+# Copyright 2016 F5 Networks Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+"""BIG-IP® system file module
+
+REST URI
+    ``http://localhost/mgmt/tm/sys/file``
+
+GUI Path
+    N/A
+
+REST Kind
+    ``tm:sys:file:*``
+"""
+from f5.bigip.resource import Collection
+from f5.bigip.resource import OrganizingCollection
+from f5.bigip.resource import Resource
+
+
+class File(OrganizingCollection):
+    def __init__(self, sys):
+        super(File, self).__init__(sys)
+        self._meta_data['allowed_lazy_attributes'] = [
+            Data_Groups
+        ]
+
+
+class Data_Groups(Collection):
+    def __init__(self, File):
+        super(Data_Groups, self).__init__(File)
+        self._meta_data['allowed_lazy_attributes'] = [Data_Group]
+        self._meta_data['required_json_kind'] = \
+            u'tm:sys:file:data-group:data-groupcollectionstate'
+        self._meta_data['attribute_registry'] =\
+            {u'tm:sys:file:data-group:data-groupstate': Data_Group}
+        self._meta_data['uri'] = self._meta_data['uri'].replace('_', '-')
+
+
+class Data_Group(Resource):
+    def __init__(self, data_groups):
+        super(Data_Group, self).__init__(data_groups)
+        self._meta_data['required_json_kind'] =\
+            u'tm:sys:file:data-group:data-groupstate'
+        self._meta_data['required_creation_parameters'].update(('name', 'sourcePath', 'type'))