# 655 bugfix.sslfile_tests added/clarified tests; added ssl resource object modify exceptions

Author: f5-rahm

f5/bigip/tm/sys/file.py

@@ -103,6 +103,15 @@ def __init__(self, ssl_certs):
         self._meta_data['required_creation_parameters'].update(
             ('name', 'sourcePath'))
 
+    def modify(self, **kwargs):
+        '''Modify is not supported for iFiles
+
+        :raises: UnsupportedOperation
+        '''
+        raise UnsupportedMethod(
+            "%s does not support the update method" % self.__class__.__name__
+        )
+
 
 class Ssl_Crls(Collection):
     def __init__(self, File):
@@ -120,6 +129,15 @@ def __init__(self, ssl_crls):
         self._meta_data['required_creation_parameters'].update(
             ('name', 'sourcePath'))
 
+    def modify(self, **kwargs):
+        '''Modify is not supported for iFiles
+
+        :raises: UnsupportedOperation
+        '''
+        raise UnsupportedMethod(
+            "%s does not support the update method" % self.__class__.__name__
+        )
+
 
 class Ssl_Csrs(Collection):
     def __init__(self, File):
@@ -138,6 +156,15 @@ def __init__(self, ssl_csrs):
         self._meta_data['required_creation_parameters'].update(
             ('name', 'sourcePath'))
 
+    def modify(self, **kwargs):
+        '''Modify is not supported for iFiles
+
+        :raises: UnsupportedOperation
+        '''
+        raise UnsupportedMethod(
+            "%s does not support the update method" % self.__class__.__name__
+        )
+
 
 class Ssl_Keys(Collection):
     def __init__(self, File):
@@ -154,3 +181,12 @@ def __init__(self, ssl_keys):
             u'tm:sys:file:ssl-key:ssl-keystate'
         self._meta_data['required_creation_parameters'].update(
             ('name', 'sourcePath'))
+
+    def modify(self, **kwargs):
+        '''Modify is not supported for iFiles
+
+        :raises: UnsupportedOperation
+        '''
+        raise UnsupportedMethod(
+            "%s does not support the update method" % self.__class__.__name__
+        )

f5/bigip/tm/sys/test/test_file.py

@@ -66,6 +66,11 @@ def test_cert_create_missing_arg(FakeSysCert):
         assert 'sourcePath' in ex.value.message
 
 
+def test_cert_modify(FakeSysCert):
+    with pytest.raises(UnsupportedMethod):
+        FakeSysCert.modify(value='Fake')
+
+
 @pytest.fixture
 def FakeSysCrl():
     fake_crl_s = mock.MagicMock()
@@ -84,6 +89,11 @@ def test_crl_create_missing_arg(FakeSysCrl):
         assert 'sourcePath' in ex.value.message
 
 
+def test_crl_modify(FakeSysCrl):
+    with pytest.raises(UnsupportedMethod):
+        FakeSysCrl.modify(value='Fake')
+
+
 @pytest.fixture
 def FakeSysCsr():
     fake_csr_s = mock.MagicMock()
@@ -96,6 +106,11 @@ def test_csr_create_no_args(FakeSysCsr):
         FakeSysCsr.create()
 
 
+def test_csr_modify(FakeSysCsr):
+    with pytest.raises(UnsupportedMethod):
+        FakeSysCsr.modify(value='Fake')
+
+
 def test_csr_create_missing_arg(FakeSysCsr):
     with pytest.raises(MissingRequiredCreationParameter) as ex:
         FakeSysCsr.create(name='test_csr')
@@ -118,3 +133,8 @@ def test_key_create_missing_arg(FakeSysKey):
     with pytest.raises(MissingRequiredCreationParameter) as ex:
         FakeSysKey.create(name='test_key')
         assert 'sourcePath' in ex.value.message
+
+
+def test_key_modify(FakeSysKey):
+    with pytest.raises(UnsupportedMethod):
+        FakeSysKey.modify(value='Fake')

test/functional/tm/sys/test_file.py

@@ -42,9 +42,9 @@ def gen_csr(key, **name):
     return req
 
 
-def gen_cert(req, xxx_todo_changeme, serial):
+def gen_cert(req, ca_files, serial):
     # returns the signed certificate in an X509 object
-    (ca_cert, ca_key) = xxx_todo_changeme
+    ca_cert, ca_key = ca_files
     cert = crypto.X509()
     cert.set_serial_number(serial)
     cert.gmtime_adj_notBefore(0)
@@ -172,7 +172,7 @@ def teardown():
 def test_CURDL_sslkeyfile(request, mgmt_root):
     # Create temporary Key File.
     # Use extensions so tmui doesn't break in managing them.
-    ntf_key = NamedTemporaryFile(suffix='.key')
+    ntf_key = NamedTemporaryFile(suffix='.key', delete=False)
     ntf_key_basename = os.path.basename(ntf_key.name)
     ntf_key_sourcepath = 'file:/var/config/rest/downloads/{0}'.format(
         ntf_key_basename)
@@ -225,7 +225,7 @@ def test_CURDL_sslkeyfile(request, mgmt_root):
 def test_CURDL_sslcsrfile(request, mgmt_root):
     # Create temporary CSR File.
     # Use extensions so tmui doesn't break in managing them.
-    ntf_csr = NamedTemporaryFile(suffix='.csr')
+    ntf_csr = NamedTemporaryFile(suffix='.csr', delete=False)
     ntf_csr_basename = os.path.basename(ntf_csr.name)
     ntf_csr_sourcepath = 'file:/var/config/rest/downloads/{0}'.format(
         ntf_csr_basename)
@@ -272,7 +272,7 @@ def test_CURDL_sslcsrfile(request, mgmt_root):
 def test_CURDL_sslcertfile(request, mgmt_root):
     # Create temporary CSR File.
     # Use extensions so tmui doesn't break in managing them.
-    ntf_cert = NamedTemporaryFile(suffix='.crt')
+    ntf_cert = NamedTemporaryFile(suffix='.crt', delete=False)
     ntf_cert_basename = os.path.basename(ntf_cert.name)
     ntf_cert_sourcepath = 'file:/var/config/rest/downloads/{0}'.format(
         ntf_cert_basename)