Sqldb rip boltdb (#2341)

* serverless sqldb use same env for test config as normal

* rip boltdb implementation of controller backend out

it was replaced by postgres and no longer works properly.

This involved migrating a number of tests which only worked with
boltdb, which exposed several ways in which the postgres
implementation had slightly different behavior from the bolt
one:
1. ordering of results in some cases, and
2. (more importantly) erroring when a record to delete was not
found. The bolt implementation silently ignored it when things to
delete weren't found, so we make some changes to match that behavior.

Also stopped propagating CreatedAt and UpdatedAt from DB tables into
dax types. These were breaking existing tests. Perhaps it would be
better to actually use them, but for now they will only exist at the
DB level.

This change set also moves the insertion of the directive_versions
record out of migrations and into the startup/connection code. Having
this in the migrations was a bit ugly because you couldn't just
truncate all the tables and have everything work from
scratch. Inserting it during startup is fairly innocuous, and will
just continue on if it already exists.

* update directive_version test

I changed the initial value to 0 so that the first version that gets
sent out is 1

Author: jaffee

.gitlab/.gitlab-ci.yml

@@ -256,13 +256,13 @@ run go tests race:
   image: golang:$GOVERSION
   extends: .go-cache
   variables:
-    SQLDB_DB: run_go_tests_race
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_DATABASE: run_go_tests_race
     POSTGRES_DB: run_go_tests_race
-    SQLDB_USER: postgres
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_USER: postgres
     POSTGRES_USER: postgres
-    SQLDB_PASSWORD: $POSTGRES_PASSWORD
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_PASSWORD: $POSTGRES_PASSWORD
     POSTGRES_PASSWORD: $POSTGRES_PASSWORD
-    SQLDB_HOST: postgres
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_HOST: postgres
   services:
     - postgres:14.7
   rules:
@@ -287,13 +287,13 @@ run go tests:
   image: golang:$GOVERSION
   extends: .go-cache
   variables:
-    SQLDB_DB: run_go_tests
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_DATABASE: run_go_tests
     POSTGRES_DB: run_go_tests
-    SQLDB_USER: postgres
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_USER: postgres
     POSTGRES_USER: postgres
-    SQLDB_PASSWORD: $POSTGRES_PASSWORD
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_PASSWORD: $POSTGRES_PASSWORD
     POSTGRES_PASSWORD: $POSTGRES_PASSWORD
-    SQLDB_HOST: postgres
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_HOST: postgres
   services:
     - postgres:14.7
   rules:
@@ -319,13 +319,13 @@ run go tests dax/test/dax:
   tags:
     - docker
   variables:
-    SQLDB_DB: run_go_tests_dax
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_DATABASE: run_go_tests_dax
     POSTGRES_DB: run_go_tests_dax
-    SQLDB_USER: postgres
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_USER: postgres
     POSTGRES_USER: postgres
-    SQLDB_PASSWORD: $POSTGRES_PASSWORD
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_PASSWORD: $POSTGRES_PASSWORD
     POSTGRES_PASSWORD: $POSTGRES_PASSWORD
-    SQLDB_HOST: postgres
+    FEATUREBASE_CONTROLLER_CONFIG_SQLDB_HOST: postgres
   services:
     - postgres:14.7
   rules:

ctl/dax.go

@@ -17,7 +17,6 @@ func BuildDAXFlags(cmd *cobra.Command, srv *server.Command) {
 	// Controller
 	flags.BoolVar(&srv.Config.Controller.Run, "controller.run", srv.Config.Controller.Run, "Run the Controller service in process.")
 	flags.DurationVar(&srv.Config.Controller.Config.RegistrationBatchTimeout, "controller.config.registration-batch-timeout", srv.Config.Controller.Config.RegistrationBatchTimeout, "Timeout for node registration batches.")
-	flags.StringVar(&srv.Config.Controller.Config.DataDir, "controller.config.data-dir", srv.Config.Controller.Config.DataDir, "Controller directory to use in process.")
 	flags.StringVar(&srv.Config.Controller.Config.StorageMethod, "controller.config.storage-method", srv.Config.Controller.Config.StorageMethod, "Backing store. boltdb or sqldb.")
 	flags.DurationVar(&srv.Config.Controller.Config.SnappingTurtleTimeout, "controller.config.snapping-turtle-timeout", srv.Config.Controller.Config.SnappingTurtleTimeout, "Period for running automatic snapshotting routine.")