Skip to content

Commit 5254793

Browse files
committed
[CoreEngine] refactor the complete job callback.
1 parent 48c0a4c commit 5254793

3 files changed

Lines changed: 11 additions & 7 deletions

File tree

python/fedml/computing/scheduler/master/base_master_protocol_manager.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -291,10 +291,10 @@ def callback_complete_job(self, topic, payload):
291291
if server_id is None:
292292
server_id = request_json.get("server_id", None)
293293

294-
# Complete the job runner
295-
self._get_job_runner_manager().complete_job_runner(
296-
run_id, args=self.args, server_id=server_id, request_json=request_json,
297-
run_as_cloud_agent=self.run_as_cloud_agent, run_as_cloud_server=self.run_as_cloud_server)
294+
self._process_job_complete_status(run_id, server_id, request_json)
295+
296+
def _process_job_complete_status(self, run_id, server_id, complete_payload):
297+
pass
298298

299299
def callback_run_logs(self, topic, payload):
300300
run_id = str(topic).split('/')[-1]

python/fedml/computing/scheduler/master/master_protocol_manager.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,10 @@ def _init_extra_items(self):
3434
# Override
3535
def print_connected_info(self):
3636
super().print_connected_info()
37+
38+
# Override
39+
def _process_job_complete_status(self, run_id, server_id, complete_payload):
40+
# Complete the job runner
41+
self._get_job_runner_manager().complete_job_runner(
42+
run_id, args=self.args, server_id=server_id, request_json=complete_payload,
43+
run_as_cloud_agent=self.run_as_cloud_agent, run_as_cloud_server=self.run_as_cloud_server)

python/fedml/computing/scheduler/model_scheduler/master_protocol_manager.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ def callback_deployment_result_message(self, topic=None, payload=None):
103103
logging.info(f"Received deployment result")
104104
FedMLDeployJobRunnerManager.get_instance().save_deployment_result(topic, payload)
105105

106-
def callback_complete_job(self, topic, payload):
107-
pass
108-
109106
def callback_delete_deployment(self, topic, payload):
110107
logging.info("[Master] callback_delete_deployment")
111108
# Parse payload as the model message object.

0 commit comments

Comments
 (0)