Skip to content

Commit 5d8bbc5

Browse files
authored
Merge pull request #2102 from FedML-AI/alexleung/dev_branch_latest
[CoreEngine] make the deployment work.
2 parents c3436fe + 496732a commit 5d8bbc5

4 files changed

Lines changed: 17 additions & 4 deletions

File tree

python/fedml/computing/scheduler/master/base_master_job_runner_manager.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,17 @@ def stop_job_runner(
4747
target=FedMLCloudServerManager.stop_cloud_server, args=(run_id, server_id, args.agent_config))
4848
stopping_process.start()
4949

50+
def complete_job_runner(
51+
self, run_id, args=None, server_id=None, request_json=None,
52+
run_as_cloud_agent=False, run_as_cloud_server=False
53+
):
54+
super().complete_job_runner(run_id)
55+
56+
if run_as_cloud_agent or run_as_cloud_server:
57+
stopping_process = Process(
58+
target=FedMLCloudServerManager.stop_cloud_server, args=(run_id, server_id, args.agent_config))
59+
stopping_process.start()
60+
5061
def _start_cloud_server(
5162
self, args, run_id, request_json, edge_id=None,
5263
use_local_process_as_cloud_server=False

python/fedml/computing/scheduler/master/base_master_protocol_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ def callback_exit_train(self, topic, payload):
292292
server_id = request_json.get("server_id", None)
293293

294294
# Stop the job runner
295-
self._get_job_runner_manager().stop_job_runner(
295+
self._get_job_runner_manager().complete_job_runner(
296296
run_id, args=self.args, server_id=server_id, request_json=request_json,
297297
run_as_cloud_agent=self.run_as_cloud_agent, run_as_cloud_server=self.run_as_cloud_server)
298298

python/fedml/computing/scheduler/model_scheduler/master_job_runner.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,8 +361,7 @@ def process_deployment_result_message(self, topic=None, payload=None):
361361
# Update the global deployment result mapping
362362
self.slave_deployment_results_map[str(device_id)] = model_status
363363

364-
logging.info("callback_deployment_result_message: topic {}, payload {}, result mapping {}.".format(
365-
topic, payload, self.slave_deployment_results_map))
364+
logging.info("callback_deployment_result_message: topic {}, payload {}.".format(topic, payload))
366365

367366
request_json = self.request_json
368367
if request_json is None:

python/fedml/computing/scheduler/model_scheduler/master_protocol_manager.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,12 @@ def print_connected_info(self):
100100
pass
101101

102102
def callback_deployment_result_message(self, topic=None, payload=None):
103-
logging.info(f"Received deployment result: {self}")
103+
logging.info(f"Received deployment result")
104104
FedMLDeployJobRunnerManager.get_instance().save_deployment_result(topic, payload)
105105

106+
def callback_exit_train(self, topic, payload):
107+
pass
108+
106109
def callback_delete_deployment(self, topic, payload):
107110
logging.info("[Master] callback_delete_deployment")
108111
# Parse payload as the model message object.

0 commit comments

Comments
 (0)