Chore: Optimizations (#57)

* Some micro-ops index.js

* Update modification notes

* Get rid of strict

* Update numbers

* Update changelog

* ignore VS Code config

Co-authored-by: Chris Bolin, Phil Plückthun

Author: ryan-roemer

.eslintrc.yml

@@ -19,7 +19,7 @@ rules:
   no-eq-null: 2
   no-fallthrough: 2
   no-return-assign: 2
-  strict: [ 2, global ]
+  strict: 0
   no-use-before-define: [ 2, nofunc ]
   callback-return: 2
   no-path-concat: 2

.gitignore

@@ -60,4 +60,7 @@ package-lock.json
 # dotenv environment variables file
 .env
 
+# editors
+.vscode/
+
 .DS_Store

CHANGELOG.md

@@ -3,8 +3,8 @@
 ## 3.0.0 (2020-01-31)
 
 **Features:**
-
 - [#36](https://github.com/FormidableLabs/react-fast-compare/pull/36). Update to `fast-deep-equal@3.1.1` with modified support for ES.next data types: `Map`, `Set`, `ArrayBuffer`.
+- [#57](https://github.com/FormidableLabs/react-fast-compare/pull/57). Minor refactoring to reduce min+gz size.
 
 **Breaking changes:**
 

CONTRIBUTING.md

@@ -104,7 +104,6 @@ $ yarn -s compress
 
 # Display minified + gzip'ed size in bytes.
 $ yarn size-min-gz
-     687
 ```
 
 **Note**: If the min+gz size increases, please note it in the README. If it is a significant increase, please flag to your reviewers and have a discussion about whether or not the size addition is justified.

README.md

@@ -33,7 +33,7 @@ $ npm install react-fast-compare
 - handles React-specific circular references, like elements
 - checks equality Date and RegExp objects
 - should as fast as [fast-deep-equal](https://github.com/epoberezkin/fast-deep-equal) via a single unified library, and with added guardrails for circular references.
-- small: under 700 bytes minified+gzipped
+- small: under 650 bytes minified+gzipped
 
 ## Usage
 

index.js

@@ -1,4 +1,3 @@
-'use strict';
 /* global Map:readonly, Set:readonly, ArrayBuffer:readonly */
 
 var hasElementType = typeof Element !== 'undefined';
@@ -39,7 +38,7 @@ function equal(a, b) {
     //
     //    ```js
     //    it = a.entries();
-    //    for (i = it.next(); !i.done; i = it.next())
+    //    while (!(i = it.next()).done)
     //      if (!b.has(i.value[0])) return false;
     //    ```
     //
@@ -48,18 +47,18 @@ function equal(a, b) {
     if (hasMap && (a instanceof Map) && (b instanceof Map)) {
       if (a.size !== b.size) return false;
       it = a.entries();
-      for (i = it.next(); !i.done; i = it.next())
+      while (!(i = it.next()).done)
         if (!b.has(i.value[0])) return false;
       it = a.entries();
-      for (i = it.next(); !i.done; i = it.next())
+      while (!(i = it.next()).done)
         if (!equal(i.value[1], b.get(i.value[0]))) return false;
       return true;
     }
 
     if (hasSet && (a instanceof Set) && (b instanceof Set)) {
       if (a.size !== b.size) return false;
       it = a.entries();
-      for (i = it.next(); !i.done; i = it.next())
+      while (!(i = it.next()).done)
         if (!b.has(i.value[0])) return false;
       return true;
     }
@@ -91,8 +90,7 @@ function equal(a, b) {
 
     // custom handling for React
     for (i = length; i-- !== 0;) {
-      var key = keys[i];
-      if (key === '_owner' && a.$$typeof) {
+      if (keys[i] === '_owner' && a.$$typeof) {
         // React-specific: avoid traversing React elements' _owner.
         //  _owner contains circular references
         // and is not needed when comparing the actual elements (and not their owners)
@@ -101,7 +99,7 @@ function equal(a, b) {
       }
 
       // all other properties should be traversed as usual
-      if (!equal(a[key], b[key])) return false;
+      if (!equal(a[keys[i]], b[keys[i]])) return false;
     }
     // END: react-fast-compare
 
@@ -117,13 +115,13 @@ module.exports = function exportedEqual(a, b) {
   try {
     return equal(a, b);
   } catch (error) {
-    if (((error.message || '').match(/stack|recursion/i)) || (error.number === -2146828260)) {
+    if (((error.message || '').match(/stack|recursion/i))) {
       // warn on circular references, don't crash
       // browsers give this different errors name and messages:
       // chrome/safari: "RangeError", "Maximum call stack size exceeded"
       // firefox: "InternalError", too much recursion"
       // edge: "Error", "Out of stack space"
-      console.warn('Warning: react-fast-compare does not handle circular references.', error.name, error.message);
+      console.warn('react-fast-compare cannot handle circular refs');
       return false;
     }
     // some other error. we should definitely know about these