Skip to content

Commit d8142eb

Browse files
committed
Addons: remove defaultOptions
1 parent 351de5b commit d8142eb

52 files changed

Lines changed: 149 additions & 153 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

addons/src/bhc/addons-bhc.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323

2424
#include "addons-bhc.h"
2525
#include "bhcdialog.h" // for BHCDialog
26-
#include "bhcoptions.h" // for BHCOptions
2726

2827

2928
void Addons::doBhc(QWidget* parent, QSettings* settings)
@@ -35,7 +34,7 @@ void Addons::doBhc(QWidget* parent, QSettings* settings)
3534
if (!dlg) {
3635
dlg = new BHCDialog(parent, settings);
3736
dlg->setObjectName(key);
38-
dlg->loadSettings(BHCOptions());
37+
dlg->loadSettings();
3938
}
4039

4140
dlg->show();

addons/src/bhc/bhcdialog.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@ BHCOptions BHCDialog::options()
505505
return options;
506506
}
507507

508-
void BHCDialog::loadSettings(const BHCOptions& defaultOptions)
508+
void BHCDialog::loadSettings()
509509
{
510510
if (mSettings.isNull()) {
511511
return;
@@ -520,7 +520,7 @@ void BHCDialog::loadSettings(const BHCOptions& defaultOptions)
520520
}
521521

522522
BHCOptions opt;
523-
opt.load(mSettings, defaultOptions);
523+
opt.load(mSettings);
524524

525525
mSettings->endGroup();
526526

addons/src/bhc/bhcdialog.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class BHCDialog : public QDialog, private Ui::BHCDialog
5050
void setOptions(const BHCOptions& options);
5151
BHCOptions options();
5252

53-
void loadSettings(const BHCOptions& defaultOptions);
53+
void loadSettings();
5454
void saveSettings(bool saveOptions = true);
5555

5656
protected:

addons/src/bhc/bhcoptions.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,22 +37,22 @@ BHCOptions::BHCOptions() :
3737
{
3838
}
3939

40-
void BHCOptions::load(QSettings* settings, const BHCOptions& defaultOptions)
40+
void BHCOptions::load(QSettings* settings)
4141
{
4242
settings->beginGroup(CFG_SECTION_GREEN);
43-
green.load(settings, defaultOptions.green);
43+
green.load(settings);
4444
settings->endGroup();
4545

4646
settings->beginGroup(CFG_SECTION_BLUE);
47-
blue.load(settings, defaultOptions.blue);
47+
blue.load(settings);
4848
settings->endGroup();
4949

5050
settings->beginGroup(CFG_SECTION_RED);
51-
red.load(settings, defaultOptions.red);
51+
red.load(settings);
5252
settings->endGroup();
5353

5454
settings->beginGroup(CFG_SECTION_YELLOW);
55-
yellow.load(settings, defaultOptions.yellow);
55+
yellow.load(settings);
5656
settings->endGroup();
5757
}
5858

addons/src/bhc/bhcoptions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ struct BHCOptions {
3333
BHCTabOptions red;
3434
BHCTabOptions yellow;
3535

36-
void load(QSettings* settings, const BHCOptions& defaultOptions);
36+
void load(QSettings* settings);
3737
void save(QSettings* settings);
3838
};
3939

addons/src/bhc/bhctaboptions.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,18 @@ BHCTabOptions::BHCTabOptions() :
4949
{
5050
}
5151

52-
void BHCTabOptions::load(QSettings* settings, const BHCTabOptions& defaultOptions)
52+
void BHCTabOptions::load(QSettings* settings)
5353
{
54-
x = settings->value(CFG_KEY_X, defaultOptions.x).toDouble();
55-
y = settings->value(CFG_KEY_Y, defaultOptions.y).toDouble();
56-
diam = settings->value(CFG_KEY_DIAM, defaultOptions.diam).toDouble();
57-
start = settings->value(CFG_KEY_START, defaultOptions.start).toDouble();
58-
step = settings->value(CFG_KEY_STEP, defaultOptions.step).toDouble();
59-
count = settings->value(CFG_KEY_COUNT, defaultOptions.count).toInt();
60-
rotate = settings->value(CFG_KEY_ROTATE, defaultOptions.rotate).toInt();
61-
mirrorX = settings->value(CFG_KEY_MIRRORX, defaultOptions.mirrorX).toBool();
62-
mirrorY = settings->value(CFG_KEY_MIRRORY, defaultOptions.mirrorY).toBool();
63-
common = settings->value(CFG_KEY_COMMON, defaultOptions.common).toBool();
54+
x = settings->value(CFG_KEY_X, x).toDouble();
55+
y = settings->value(CFG_KEY_Y, y).toDouble();
56+
diam = settings->value(CFG_KEY_DIAM, diam).toDouble();
57+
start = settings->value(CFG_KEY_START, start).toDouble();
58+
step = settings->value(CFG_KEY_STEP, step).toDouble();
59+
count = settings->value(CFG_KEY_COUNT, count).toInt();
60+
rotate = settings->value(CFG_KEY_ROTATE, rotate).toInt();
61+
mirrorX = settings->value(CFG_KEY_MIRRORX, mirrorX).toBool();
62+
mirrorY = settings->value(CFG_KEY_MIRRORY, mirrorY).toBool();
63+
common = settings->value(CFG_KEY_COMMON, common).toBool();
6464
}
6565

6666
void BHCTabOptions::save(QSettings* settings)

addons/src/bhc/bhctaboptions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ struct BHCTabOptions {
3737
bool mirrorY;
3838
bool common;
3939

40-
void load(QSettings* settings, const BHCTabOptions& defaultOptions);
40+
void load(QSettings* settings);
4141
void save(QSettings* settings);
4242
};
4343

addons/src/chamfer/addons-chamfer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323

2424
#include "addons-chamfer.h"
2525
#include "chamferdialog.h" // for ChamferDialog
26-
#include "chamferoptions.h" // for ChamferOptions
2726

2827

2928
void Addons::doChamfer(QWidget* parent, QSettings* settings)
@@ -35,7 +34,7 @@ void Addons::doChamfer(QWidget* parent, QSettings* settings)
3534
if (!dlg) {
3635
dlg = new ChamferDialog(parent, settings);
3736
dlg->setObjectName(key);
38-
dlg->loadSettings(ChamferOptions());
37+
dlg->loadSettings();
3938
}
4039

4140
dlg->show();

addons/src/chamfer/chamferdialog.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ ChamferOptions ChamferDialog::options()
324324
return options;
325325
}
326326

327-
void ChamferDialog::loadSettings(const ChamferOptions& defaultOptions)
327+
void ChamferDialog::loadSettings()
328328
{
329329
if (mSettings.isNull()) {
330330
return;
@@ -339,7 +339,7 @@ void ChamferDialog::loadSettings(const ChamferOptions& defaultOptions)
339339
}
340340

341341
ChamferOptions opt;
342-
opt.load(mSettings, defaultOptions);
342+
opt.load(mSettings);
343343

344344
mSettings->endGroup();
345345

addons/src/chamfer/chamferdialog.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class ChamferDialog : public QDialog, private Ui::ChamferDialog
4848
void setOptions(const ChamferOptions& options);
4949
ChamferOptions options();
5050

51-
void loadSettings(const ChamferOptions& defaultOptions);
51+
void loadSettings();
5252
void saveSettings(bool saveOptions = true);
5353

5454
protected slots:

0 commit comments

Comments
 (0)