test(workflows): improve reliability of workflow execution tests

Author: angelcaamal

workflows/quickstart/test/executeWorkflow.test.js

@@ -51,8 +51,11 @@ describe('Cloud Workflows JavaScript Execution Samples', () => {
         });
         return workflowGet.state === 'ACTIVE';
       } catch (e) {
-        // If there is an error getting the workflow, it probably doesn't exist.
-        return false;
+        if (e.code === 5) {
+          // NOT_FOUND
+          return false;
+        }
+        throw e;
       }
     }
 
@@ -89,7 +92,7 @@ describe('Cloud Workflows JavaScript Execution Samples', () => {
   it('should execute the workflow using the executeWithoutArguments sample', async () => {
     // Execute workflow, with long test timeout
     const result = execSync(
-      `node --require ts-node/register ./executeWithoutArguments.js ${PROJECT_ID} ${LOCATION_ID} ${WORKFLOW_ID}`
+      `node ./executeWithoutArguments.js ${PROJECT_ID} ${LOCATION_ID} ${WORKFLOW_ID}`
     );
 
     assert.ok(
@@ -101,7 +104,7 @@ describe('Cloud Workflows JavaScript Execution Samples', () => {
   it('should execute the workflow using the executeWithArguments sample', async () => {
     // Execute workflow, with long test timeout
     const result = execSync(
-      `node --require ts-node/register ./executeWithArguments.js ${PROJECT_ID} ${LOCATION_ID} ${WORKFLOW_ID} ${SEARCH_TERM}`
+      `node ./executeWithArguments.js ${PROJECT_ID} ${LOCATION_ID} ${WORKFLOW_ID} ${SEARCH_TERM}`
     );
 
     assert.ok(

workflows/quickstart/test/executeWorkflow.test.ts

@@ -46,9 +46,13 @@ describe('Cloud Workflows TypeScript Execution Samples', () => {
           name: client.workflowPath(PROJECT_ID, LOCATION_ID, WORKFLOW_ID),
         });
         return workflowGet.state === 'ACTIVE';
-      } catch {
-        // If there is an error getting the workflow, it probably doesn't exist.
-        return false;
+      } catch (e) {
+        if ((e as {code?: number})?.code === 5) {
+          // NOT_FOUND
+          // If there is an error getting the workflow, it probably doesn't exist.
+          return false;
+        }
+        throw e;
       }
     }
 

workflows/quickstart/test/quickstart.test.js

@@ -50,8 +50,11 @@ describe('Cloud Workflows JavaScript Quickstart Tests', () => {
         });
         return workflowGet.state === 'ACTIVE';
       } catch (e) {
-        // If there is an error getting the workflow, it probably doesn't exist.
-        return false;
+        if (e.code === 5) {
+          // NOT_FOUND
+          return false;
+        }
+        throw e;
       }
     }
 
@@ -88,9 +91,9 @@ describe('Cloud Workflows JavaScript Quickstart Tests', () => {
   it('should execute the quickstart', async () => {
     // Execute workflow, with long test timeout
     const result = execSync(
-      `node --require ts-node/register ./index.js ${PROJECT_ID} ${LOCATION_ID} ${WORKFLOW_ID}`
+      `node ./index.js ${PROJECT_ID} ${LOCATION_ID} ${WORKFLOW_ID}`
     );
 
     assert.ok(result.length > 0, 'Quickstart must return non-empty result');
-  }).timeout(5000);
+  }).timeout(60000);
 });

workflows/quickstart/test/quickstart.test.ts

@@ -46,9 +46,12 @@ describe('Cloud Workflows TypeScript Quickstart Tests', () => {
           name: client.workflowPath(PROJECT_ID, LOCATION_ID, WORKFLOW_ID),
         });
         return workflowGet.state === 'ACTIVE';
-      } catch {
-        // If there is an error getting the workflow, it probably doesn't exist.
-        return false;
+      } catch (e) {
+        if ((e as {code?: number})?.code === 5) {
+          // If there is an error getting the workflow, it probably doesn't exist.
+          return false;
+        }
+        throw e;
       }
     }
 
@@ -89,7 +92,7 @@ describe('Cloud Workflows TypeScript Quickstart Tests', () => {
     );
 
     assert.ok(result.length > 0, 'Quickstart must return non-empty result');
-  }).timeout(5000);
+  }).timeout(60000);
 
   it('should execute the quickstart with optional search term', async () => {
     // Execute workflow, with long test timeout
@@ -98,5 +101,5 @@ describe('Cloud Workflows TypeScript Quickstart Tests', () => {
     );
 
     assert.ok(result.length > 0, 'Quickstart must return non-empty result');
-  }).timeout(5000);
+  }).timeout(60000);
 });