From aba58b99baace711d2f5c83bba08f90bb394675f Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Thu, 6 Mar 2025 14:47:56 +0000 Subject: [PATCH 1/3] chore(gae): Remove older region tag --- appengine/building-an-app/build/app.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/appengine/building-an-app/build/app.yaml b/appengine/building-an-app/build/app.yaml index 7c10aece83..ba941b763f 100755 --- a/appengine/building-an-app/build/app.yaml +++ b/appengine/building-an-app/build/app.yaml @@ -11,8 +11,6 @@ # See the License for the specific language governing permissions and # limitations under the License. -# [START app_yaml] # [START gae_app_yaml] runtime: nodejs20 # [END gae_app_yaml] -# [END app_yaml] From 5fe400f28441ecaa32c03e9215ef08b3853c54c2 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Tue, 18 Mar 2025 18:50:49 +0000 Subject: [PATCH 2/3] fix(gae): fix linting issues --- appengine/building-an-app/build/test/server.test.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/appengine/building-an-app/build/test/server.test.js b/appengine/building-an-app/build/test/server.test.js index f5af8ba230..a8472cdf2c 100644 --- a/appengine/building-an-app/build/test/server.test.js +++ b/appengine/building-an-app/build/test/server.test.js @@ -15,15 +15,14 @@ const supertest = require('supertest'); const path = require('path'); const app = require(path.join(__dirname, '../', 'server.js')); - describe('gae_app', () => { it('should be listening', async () => { await supertest(app).get('/').expect(200); }); -}) +}); describe('gae_build_web_server_app', () => { it('should be listening', async () => { await supertest(app).get('/').expect(200); }); -}) +}); \ No newline at end of file From 2e311d9803c31337ea66a3298afa58d5bc8a6d33 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Tue, 18 Mar 2025 18:57:23 +0000 Subject: [PATCH 3/3] fix(gae): fix linting issues --- appengine/building-an-app/build/test/server.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appengine/building-an-app/build/test/server.test.js b/appengine/building-an-app/build/test/server.test.js index a8472cdf2c..a701e00f68 100644 --- a/appengine/building-an-app/build/test/server.test.js +++ b/appengine/building-an-app/build/test/server.test.js @@ -25,4 +25,4 @@ describe('gae_build_web_server_app', () => { it('should be listening', async () => { await supertest(app).get('/').expect(200); }); -}); \ No newline at end of file +});