Attempt at mapping google spans to opentelemetry ones better (#90)

* Trying to use predefined labels as per https://cloud.google.com/trace/docs/reference/v1/rest/v1/projects.traces#get

* No need for a regexp

* Ok pylint

* Ok py35 no f-strings

* Using a mapping

* Update opentelemetry-exporter-google-cloud/src/opentelemetry/exporter/cloud_trace/__init__.py

Co-authored-by: Aaron Abbott <aaronabbott@google.com>

* Update opentelemetry-exporter-google-cloud/src/opentelemetry/exporter/cloud_trace/__init__.py

Co-authored-by: Aaron Abbott <aaronabbott@google.com>

* Update opentelemetry-exporter-google-cloud/src/opentelemetry/exporter/cloud_trace/__init__.py

Co-authored-by: Aaron Abbott <aaronabbott@google.com>

* Update opentelemetry-exporter-google-cloud/src/opentelemetry/exporter/cloud_trace/__init__.py

Co-authored-by: Aaron Abbott <aaronabbott@google.com>

* Update opentelemetry-exporter-google-cloud/src/opentelemetry/exporter/cloud_trace/__init__.py

Co-authored-by: Aaron Abbott <aaronabbott@google.com>

* Removed non-identified mappings

* Pylint

* Please mypy

* Test wip, troubles to run locally

* Corrected test

* Removed error and stacktrace mapping for now

* Removed pid

* Instanciated label mapping inside test case

* Useless line break

* Black magic for CI

* Used key directly

Co-authored-by: Aaron Abbott <aaronabbott@google.com>

* Modified CHANGELOG.md

* Pylint

Co-authored-by: Aaron Abbott <aaronabbott@google.com>

Author: euri10

opentelemetry-exporter-google-cloud/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+- Add mapping between opentelemetry and google traces attributes
+  ([#90](https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/pull/90))
+
 ## Version 0.15b0
 
 Released 2020-11-04

opentelemetry-exporter-google-cloud/src/opentelemetry/exporter/cloud_trace/__init__.py

@@ -364,6 +364,21 @@ def _extract_resources(resource: Resource) -> Dict[str, str]:
     }
 
 
+LABELS_MAPPING = {
+    # this one might be http.flavor? I'm not sure
+    "http.scheme": "/http/client_protocol",
+    "http.host": "/http/host",
+    "http.method": "/http/method",
+    # https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#common-attributes
+    "http.request_content_length": "/http/request/size",
+    "http.response_content_length": "/http/response/size",
+    "http.route": "/http/route",
+    "http.status_code": "/http/status_code",
+    "http.url": "/http/url",
+    "http.user_agent": "/http/user_agent",
+}
+
+
 def _extract_attributes(
     attrs: types.Attributes,
     num_attrs_limit: int,
@@ -374,6 +389,8 @@ def _extract_attributes(
     invalid_value_dropped_count = 0
     for key, value in attrs.items() if attrs else []:
         key = _truncate_str(key, 128)[0]
+        if key in LABELS_MAPPING:  # pylint: disable=consider-using-get
+            key = LABELS_MAPPING[key]
         value = _format_attribute_value(value)
 
         if value:

opentelemetry-exporter-google-cloud/tests/test_cloud_trace_exporter.py

@@ -213,6 +213,62 @@ def test_extract_variety_of_attributes(self):
             self.extracted_attributes_variety_pack,
         )
 
+    def test_extract_label_mapping_attributes(self):
+        attributes_labels_mapping = {
+            "http.scheme": "http",
+            "http.host": "172.19.0.4:8000",
+            "http.method": "POST",
+            "http.request_content_length": 321,
+            "http.response_content_length": 123,
+            "http.route": "/fuzzy/search",
+            "http.status_code": 200,
+            "http.url": "http://172.19.0.4:8000/fuzzy/search",
+            "http.user_agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36",
+        }
+        extracted_attributes_labels_mapping = ProtoSpan.Attributes(
+            attribute_map={
+                "/http/client_protocol": AttributeValue(
+                    string_value=TruncatableString(
+                        value="http", truncated_byte_count=0
+                    )
+                ),
+                "/http/host": AttributeValue(
+                    string_value=TruncatableString(
+                        value="172.19.0.4:8000", truncated_byte_count=0
+                    )
+                ),
+                "/http/method": AttributeValue(
+                    string_value=TruncatableString(
+                        value="POST", truncated_byte_count=0
+                    )
+                ),
+                "/http/request/size": AttributeValue(int_value=321),
+                "/http/response/size": AttributeValue(int_value=123),
+                "/http/route": AttributeValue(
+                    string_value=TruncatableString(
+                        value="/fuzzy/search", truncated_byte_count=0
+                    )
+                ),
+                "/http/status_code": AttributeValue(int_value=200),
+                "/http/url": AttributeValue(
+                    string_value=TruncatableString(
+                        value="http://172.19.0.4:8000/fuzzy/search",
+                        truncated_byte_count=0,
+                    )
+                ),
+                "/http/user_agent": AttributeValue(
+                    string_value=TruncatableString(
+                        value="Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36",
+                        truncated_byte_count=0,
+                    )
+                ),
+            }
+        )
+        self.assertEqual(
+            _extract_attributes(attributes_labels_mapping, num_attrs_limit=9),
+            extracted_attributes_labels_mapping,
+        )
+
     def test_ignore_invalid_attributes(self):
         self.assertEqual(
             _extract_attributes(