Review comments addressed.

Author: jeffmendoza

.rubocop.yml

@@ -20,6 +20,8 @@ Style/NumericLiterals:
   Enabled: false
 Style/SpaceAroundOperators:
   Enabled: false
+Style/AccessorMethodName:
+  Enabled: false
 Metrics/ClassLength:
   Enabled: false
 Style/EmptyElse:

pubsub/sample.rb

@@ -19,31 +19,31 @@
 pubsub = gcloud.pubsub
 # [END create_pubsub_client]
 
-# [START create_topic]
 def create_topic
+  # [START create_topic]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
 
   topic = pubsub.create_topic "my-topic"
 
   puts "Topic created #{topic.name}"
+  # [END create_topic]
 end
-# [END create_topic]
 
-# [START create_subscription]
 def create_subscription
+  # [START create_subscription]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   topic = pubsub.topic "my-topic"
 
   subscription = topic.subscribe "my-subscription"
 
   puts "Subscription created #{subscription.name}"
+  # [END create_subscription]
 end
-# [END create_subscription]
 
-# [START create_push_subscription]
 def create_push_subscription
+  # [START create_push_subscription]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   topic = pubsub.topic "my-topic"
@@ -54,21 +54,21 @@ def create_push_subscription
   )
 
   puts "Push subscription created #{subscription.name}"
+  # [END create_push_subscription]
 end
-# [END create_push_subscription]
 
-# [START publish_message]
 def publish_message
+  # [START publish_message]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   topic  = pubsub.topic "my-topic"
 
   topic.publish "A Message"
+  # [END publish_message]
 end
-# [END publish_message]
 
-# [START pull_messages]
 def pull_messages
+  # [START pull_messages]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   subscription = pubsub.subscription "my-subscription"
@@ -78,11 +78,11 @@ def pull_messages
     puts message.data
     message.acknowledge!
   end
+  # [END pull_messages]
 end
-# [END pull_messages]
 
-# [START list_topics]
 def list_topics
+  # [START list_topics]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   topics = pubsub.topics
@@ -91,11 +91,11 @@ def list_topics
   topics.each do |topic|
     puts topic.name
   end
+  # [END list_topics]
 end
-# [END list_topics]
 
-# [START list_subscriptions]
 def list_subscriptions
+  # [START list_subscriptions]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   subscriptions = pubsub.subscriptions
@@ -104,11 +104,11 @@ def list_subscriptions
   subscriptions.each do |subscription|
     puts subscription.name
   end
+  # [END list_subscriptions]
 end
-# [END list_subscriptions]
 
-# [START print_topic_policy]
-def print_topic_policy
+def get_topic_policy
+  # [START get_topic_policy]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   topic = pubsub.topic "my-topic"
@@ -117,11 +117,11 @@ def print_topic_policy
 
   puts "Topic policy:"
   puts policy.roles
+  # [END get_topic_policy]
 end
-# [END print_topic_policy]
 
-# [START print_subscription_policy]
-def print_subscription_policy
+def get_subscription_policy
+  # [START get_subscription_policy]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   subscription = pubsub.subscription "my-subscription"
@@ -130,11 +130,11 @@ def print_subscription_policy
 
   puts "Subscription policy:"
   puts policy.roles
+  # [END get_subscription_policy]
 end
-# [END print_subscription_policy]
 
-# [START set_subscription_policy]
 def set_subscription_policy
+  # [START set_subscription_policy]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   subscription = pubsub.subscription "my-subscription"
@@ -145,11 +145,11 @@ def set_subscription_policy
   end
 
   puts subscription.policy.roles
+  # [END set_subscription_policy]
 end
-# [END set_subscription_policy]
 
-# [START set_topic_policy]
 def set_topic_policy
+  # [START set_topic_policy]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   topic = pubsub.topic "my-topic"
@@ -160,11 +160,11 @@ def set_topic_policy
   end
 
   puts topic.policy.roles
+  # [END set_topic_policy]
 end
-# [END set_topic_policy]
 
-# [START test_subscription_permissions]
 def test_subscription_permissions
+  # [START test_subscription_permissions]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   subscription = pubsub.subscription "my-subscription"
@@ -174,11 +174,11 @@ def test_subscription_permissions
 
   puts permissions.include? "pubsub.subscriptions.consume"
   puts permissions.include? "pubsub.subscriptions.update"
+  # [END test_subscription_permissions]
 end
-# [END test_subscription_permissions]
 
-# [START test_topic_permissions]
 def test_topic_permissions
+  # [START test_topic_permissions]
   gcloud = Gcloud.new "my-gcp-project-id"
   pubsub = gcloud.pubsub
   topic = pubsub.topic "my-topic"
@@ -190,5 +190,5 @@ def test_topic_permissions
   puts permissions.include? "pubsub.topics.attachSubscription"
   puts permissions.include? "pubsub.topics.publish"
   puts permissions.include? "pubsub.topics.update"
+  # [END test_topic_permissions]
 end
-# [END test_topic_permissions]

pubsub/spec/sample_spec.rb

@@ -147,7 +147,7 @@ def expect_with_retry attempts: 5
   it "gets topic policy" do
     @pubsub.create_topic TOPIC_NAME
 
-    expect { print_topic_policy }.to output(/{}/).to_stdout
+    expect { get_topic_policy }.to output(/{}/).to_stdout
   end
 
   it "gets subscription policy" do
@@ -157,7 +157,7 @@ def expect_with_retry attempts: 5
       autocreate: true
     )
 
-    expect { print_subscription_policy }.to output(/{}/).to_stdout
+    expect { get_subscription_policy }.to output(/{}/).to_stdout
   end
 
   it "sets topic policy" do