portability fixes:

- store settings in registry;
- store .sys file in temp folder;

Author: sergiye

.editorconfig

@@ -38,9 +38,9 @@ dotnet_style_qualification_for_method = false:suggestion
 dotnet_style_qualification_for_event = false:suggestion
 
 # Types: use keywords instead of BCL types, and permit var only when the type is clear
-csharp_style_var_for_built_in_types = false:suggestion
-csharp_style_var_when_type_is_apparent = false:none
-csharp_style_var_elsewhere = false:suggestion
+csharp_style_var_for_built_in_types = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+csharp_style_var_elsewhere = true:suggestion
 dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
 dotnet_style_predefined_type_for_member_access = true:suggestion
 

GUI/MainForm.cs

@@ -48,6 +48,7 @@ public partial class MainForm : Form {
     private readonly UserOption logSensors;
     private readonly UserRadioGroup loggingInterval;
     private readonly Logger logger;
+    private readonly string configFilePath;
 
     private bool selectionDragging = false;
     //private readonly Timer checkUpdatesTimer;
@@ -59,7 +60,9 @@ public MainForm() {
       Icon = Icon.ExtractAssociatedIcon(Updater.CurrentFileLocation);
 
       settings = new PersistentSettings();
-      settings.Load(Application.ExecutablePath);
+
+      configFilePath = Path.ChangeExtension(Application.ExecutablePath, ".config");
+      settings.Load(configFilePath);
 
       unitManager = new UnitManager(settings);
 
@@ -383,16 +386,14 @@ private void SaveConfiguration() {
         settings.SetValue("listenerPort", server.ListenerPort);
       }
 
-      string fileName = Path.ChangeExtension(
-          Application.ExecutablePath, ".config");
       try {
-        settings.Save(fileName);
+        settings.Save(configFilePath);
       } catch (UnauthorizedAccessException) {
-        MessageBox.Show("Access to the path '" + fileName + "' is denied. " +
+        MessageBox.Show("Access to the path '" + configFilePath + "' is denied. " +
           "The current settings could not be saved.",
           "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
       } catch (IOException) {
-        MessageBox.Show("The path '" + fileName + "' is not writeable. " +
+        MessageBox.Show("The path '" + configFilePath + "' is not writeable. " +
           "The current settings could not be saved.",
           "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
       }

Hardware/Ring0.cs

@@ -23,13 +23,13 @@ private static IOControlCode
         IOControlCode.Access.Any),
       IOCTL_OLS_READ_MSR = new IOControlCode(OLS_TYPE, 0x821,
         IOControlCode.Access.Any),
-      IOCTL_OLS_WRITE_MSR = new IOControlCode(OLS_TYPE, 0x822, 
+      IOCTL_OLS_WRITE_MSR = new IOControlCode(OLS_TYPE, 0x822,
         IOControlCode.Access.Any),
       IOCTL_OLS_READ_IO_PORT_BYTE = new IOControlCode(OLS_TYPE, 0x833,
         IOControlCode.Access.Read),
-      IOCTL_OLS_WRITE_IO_PORT_BYTE = new IOControlCode(OLS_TYPE, 0x836, 
+      IOCTL_OLS_WRITE_IO_PORT_BYTE = new IOControlCode(OLS_TYPE, 0x836,
         IOControlCode.Access.Write),
-      IOCTL_OLS_READ_PCI_CONFIG = new IOControlCode(OLS_TYPE, 0x851, 
+      IOCTL_OLS_READ_PCI_CONFIG = new IOControlCode(OLS_TYPE, 0x851,
         IOControlCode.Access.Read),
       IOCTL_OLS_WRITE_PCI_CONFIG = new IOControlCode(OLS_TYPE, 0x852,
         IOControlCode.Access.Write),
@@ -40,46 +40,48 @@ private static Assembly GetAssembly() {
       return typeof(Ring0).Assembly;
     }
 
-    private static string GetTempFileName() {
-      
-      // try to create one in the application folder
-      string location = GetAssembly().Location;
-      if (!string.IsNullOrEmpty(location)) {        
-        try {
-          string fileName = Path.ChangeExtension(location, ".sys");
-          using (FileStream stream = File.Create(fileName)) {
-            return fileName;
-          }
-        } catch (Exception) { }
+    private static string GetTempFileName(bool useAppFolder = false) {
+
+      if (useAppFolder) {
+        // try to create one in the application folder
+        string location = GetAssembly().Location;
+        if (!string.IsNullOrEmpty(location)) {
+          try {
+            string fileName = Path.ChangeExtension(location, ".sys");
+            using (FileStream stream = File.Create(fileName)) {
+              return fileName;
+            }
+          } catch (Exception) { }
+        }
       }
 
       // if this failed, try to get a file in the temporary folder
       try {
-        return Path.GetTempFileName();        
-      } catch (IOException) { 
+        return Path.GetTempFileName();
+      } catch (IOException) {
           // some I/O exception
-      } 
-      catch (UnauthorizedAccessException) { 
+      }
+      catch (UnauthorizedAccessException) {
         // we do not have the right to create a file in the temp folder
       }
       catch (NotSupportedException) {
         // invalid path format of the TMP system environment variable
       }
-     
+
       return null;
     }
 
     private static bool ExtractDriver(string fileName) {
       string resourceName = "OpenHardwareMonitor.Hardware." +
-        (OperatingSystem.Is64BitOperatingSystem ? "WinRing0x64.sys" : 
+        (OperatingSystem.Is64BitOperatingSystem ? "WinRing0x64.sys" :
         "WinRing0.sys");
 
       string[] names = GetAssembly().GetManifestResourceNames();
       byte[] buffer = null;
       for (int i = 0; i < names.Length; i++) {
         if (names[i].Replace('\\', '.') == resourceName) {
           using (Stream stream = GetAssembly().
-            GetManifestResourceStream(names[i])) 
+            GetManifestResourceStream(names[i]))
           {
               buffer = new byte[stream.Length];
               stream.Read(buffer, 0, buffer.Length);
@@ -95,16 +97,16 @@ private static bool ExtractDriver(string fileName) {
           target.Write(buffer, 0, buffer.Length);
           target.Flush();
         }
-      } catch (IOException) { 
+      } catch (IOException) {
         // for example there is not enough space on the disk
-        return false; 
+        return false;
       }
 
       // make sure the file is actually writen to the file system
       for (int i = 0; i < 20; i++) {
         try {
           if (File.Exists(fileName) &&
-            new FileInfo(fileName).Length == buffer.Length) 
+            new FileInfo(fileName).Length == buffer.Length)
           {
             return true;
           }
@@ -113,22 +115,22 @@ private static bool ExtractDriver(string fileName) {
           Thread.Sleep(10);
         }
       }
-      
+
       // file still has not the right size, something is wrong
       return false;
     }
 
     public static void Open() {
       // no implementation for unix systems
       if (OperatingSystem.IsUnix)
-        return;  
-      
+        return;
+
       if (driver != null)
         return;
 
       // clear the current report
       report.Length = 0;
-     
+
       driver = new KernelDriver("WinRing0_1_2_0");
       driver.Open();
 
@@ -147,7 +149,7 @@ public static void Open() {
             }
           } else {
             string errorFirstInstall = installError;
-   
+
             // install failed, try to delete and reinstall
             driver.Delete();
 
@@ -180,11 +182,11 @@ public static void Open() {
           if (File.Exists(fileName))
             File.Delete(fileName);
           fileName = null;
-        } catch (IOException) { } 
+        } catch (IOException) { }
           catch (UnauthorizedAccessException) { }
       }
 
-      if (!driver.IsOpen) 
+      if (!driver.IsOpen)
         driver = null;
 
       string isaMutexName = "Global\\Access_ISABUS.HTP.Method";
@@ -239,7 +241,7 @@ public static void Close() {
         try {
           File.Delete(fileName);
           fileName = null;
-        } catch (IOException) { } 
+        } catch (IOException) { }
           catch (UnauthorizedAccessException) { }
       }
     }
@@ -303,7 +305,7 @@ public static bool Rdmsr(uint index, out uint eax, out uint edx) {
     }
 
     public static bool RdmsrTx(uint index, out uint eax, out uint edx,
-      GroupAffinity affinity) 
+      GroupAffinity affinity)
     {
       var previousAffinity = ThreadAffinity.Set(affinity);
 
@@ -370,8 +372,8 @@ private struct ReadPciConfigInput {
       public uint RegAddress;
     }
 
-    public static bool ReadPciConfig(uint pciAddress, uint regAddress, 
-      out uint value) 
+    public static bool ReadPciConfig(uint pciAddress, uint regAddress,
+      out uint value)
     {
       if (driver == null || (regAddress & 3) != 0) {
         value = 0;
@@ -383,7 +385,7 @@ public static bool ReadPciConfig(uint pciAddress, uint regAddress,
       input.RegAddress = regAddress;
 
       value = 0;
-      return driver.DeviceIOControl(IOCTL_OLS_READ_PCI_CONFIG, input, 
+      return driver.DeviceIOControl(IOCTL_OLS_READ_PCI_CONFIG, input,
         ref value);
     }
 
@@ -394,8 +396,8 @@ private struct WritePciConfigInput {
       public uint Value;
     }
 
-    public static bool WritePciConfig(uint pciAddress, uint regAddress, 
-      uint value) 
+    public static bool WritePciConfig(uint pciAddress, uint regAddress,
+      uint value)
     {
       if (driver == null || (regAddress & 3) != 0)
         return false;

Properties/AssemblyInfo.cs

@@ -14,4 +14,4 @@
 
 [assembly: DefaultDllImportSearchPaths(DllImportSearchPath.System32)]
 
-[assembly: AssemblyVersion("0.9.*")]
+[assembly: AssemblyVersion("1.0.*")]