Skip to content

Commit 58163e2

Browse files
committed
show in tray (T) hotkey;
show in gadget (G) hotkey; fixed 'Hide/show' sensor hotkey next node selection; 'Reset pen color' hotkey fix: next node selection disabled removed auto-updates check in background
1 parent b03bc37 commit 58163e2

3 files changed

Lines changed: 48 additions & 45 deletions

File tree

OpenHardwareMonitor/UI/MainForm.cs

Lines changed: 39 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public MainForm()
103103

104104
treeModel.Nodes.Add(_root);
105105
treeView.Model = treeModel;
106-
treeView.DrawControl += (sender, args) =>
106+
treeView.DrawControl += (_, args) =>
107107
{
108108
// if (args.Node.IsSelected)
109109
// return;
@@ -265,7 +265,7 @@ public MainForm()
265265
Server.StopHttpListener();
266266
};
267267

268-
openWebServerMenuItem.Click += (s, e) => {
268+
openWebServerMenuItem.Click += (_, _) => {
269269
System.Diagnostics.Process.Start("http://localhost:" + Server.ListenerPort);
270270
};
271271

@@ -293,7 +293,7 @@ public MainForm()
293293
},
294294
_settings);
295295

296-
_loggingInterval.Changed += (sender, e) =>
296+
_loggingInterval.Changed += (_, _) =>
297297
{
298298
switch (_loggingInterval.Value)
299299
{
@@ -352,7 +352,7 @@ public MainForm()
352352
},
353353
_settings);
354354

355-
_updateInterval.Changed += (sender, e) =>
355+
_updateInterval.Changed += (_, _) =>
356356
{
357357
switch (_updateInterval.Value)
358358
{
@@ -378,7 +378,7 @@ public MainForm()
378378
};
379379

380380
_throttleAtaUpdate = new UserOption("throttleAtaUpdateMenuItem", false, throttleAtaUpdateMenuItem, _settings);
381-
_throttleAtaUpdate.Changed += (sender, e) =>
381+
_throttleAtaUpdate.Changed += (_, _) =>
382382
{
383383
switch (_throttleAtaUpdate.Value)
384384
{
@@ -413,7 +413,7 @@ public MainForm()
413413
perSessionFileRotationMenuItem.Checked = _logger.FileRotationMethod == LoggerFileRotation.PerSession;
414414
dailyFileRotationMenuItem.Checked = _logger.FileRotationMethod == LoggerFileRotation.Daily;
415415

416-
_sensorValuesTimeWindow.Changed += (sender, e) =>
416+
_sensorValuesTimeWindow.Changed += (_, _) =>
417417
{
418418
TimeSpan timeWindow = TimeSpan.Zero;
419419
switch (_sensorValuesTimeWindow.Value)
@@ -453,7 +453,7 @@ public MainForm()
453453
break;
454454
}
455455

456-
_computer.Accept(new SensorVisitor(delegate(ISensor sensor) { sensor.ValuesTimeWindow = timeWindow; }));
456+
_computer.Accept(new SensorVisitor(delegate(ISensor s) { s.ValuesTimeWindow = timeWindow; }));
457457
};
458458

459459
InitializeTheme();
@@ -680,15 +680,6 @@ private void MainForm_Load(object sender, EventArgs e)
680680
Application.Exit
681681
);
682682

683-
//will display prompt only if update available & when main form displayed
684-
var timer = new Timer();
685-
timer.Interval = 3000;
686-
timer.Tick += async (_, _) => {
687-
timer.Enabled = false;
688-
timer.Enabled = ! await Updater.CheckForUpdatesAsync(true);
689-
};
690-
timer.Enabled = true;
691-
692683
FormClosed += MainForm_FormClosed;
693684
}
694685

@@ -755,18 +746,35 @@ private void TreeView_KeyDown(object sender, KeyEventArgs e)
755746
var node = treeView.SelectedNode;
756747
if (node is not {Tag: SensorNode sensorNode} || sensorNode.Sensor == null)
757748
return;
758-
switch (e.KeyCode) {
759-
case Keys.H:
760-
sensorNode.IsVisible = !sensorNode.IsVisible;
761-
treeView.SelectedNode = node.NextNode;
762-
break;
763-
case Keys.P:
764-
ShowParameterForm(sensorNode.Sensor);
765-
break;
766-
case Keys.R:
767-
sensorNode.PenColor = null;
768-
treeView.SelectedNode = node.NextNode;
769-
break;
749+
if (e.KeyCode == Keys.H)
750+
{
751+
treeView.SelectedNode = node.NextNode ?? node.PreviousNode;
752+
sensorNode.IsVisible = !sensorNode.IsVisible;
753+
e.SuppressKeyPress = true;
754+
e.Handled = true;
755+
}
756+
else if (e.KeyCode == Keys.P)
757+
{
758+
ShowParameterForm(sensorNode.Sensor);
759+
}
760+
else if (e.KeyCode == Keys.R)
761+
{
762+
sensorNode.PenColor = null;
763+
// treeView.SelectedNode = node.NextNode ?? node.PreviousNode;
764+
e.SuppressKeyPress = true;
765+
e.Handled = true;
766+
}
767+
else if (e.KeyCode == Keys.T && e.Control)
768+
{
769+
if (!_systemTray.Add(sensorNode.Sensor))
770+
_systemTray.Remove(sensorNode.Sensor);
771+
e.Handled = true;
772+
}
773+
else if (e.KeyCode == Keys.G && e.Control)
774+
{
775+
if (!_gadget.Add(sensorNode.Sensor))
776+
_gadget.Remove(sensorNode.Sensor);
777+
e.Handled = true;
770778
}
771779
}
772780

@@ -829,21 +837,21 @@ private void TreeView_Click(object sender, EventArgs e)
829837
treeContextMenu.Items.Add(item);
830838

831839
treeContextMenu.Items.Add(new ToolStripSeparator());
832-
item = new ToolStripMenuItem("Show in Tray") { Checked = _systemTray.Contains(node.Sensor) };
840+
item = new ToolStripMenuItem("Show in Tray (Ctrl+T)") { Checked = _systemTray.Contains(node.Sensor) };
833841
item.Click += (s, _) =>
834842
{
835843
if (s is not ToolStripMenuItem menuItem)
836844
return;
837845
if (menuItem.Checked)
838846
_systemTray.Remove(node.Sensor);
839847
else
840-
_systemTray.Add(node.Sensor, true);
848+
_systemTray.Add(node.Sensor);
841849
};
842850
treeContextMenu.Items.Add(item);
843851

844852
if (_gadget != null)
845853
{
846-
item = new ToolStripMenuItem("Show in Gadget") { Checked = _gadget.Contains(node.Sensor) };
854+
item = new ToolStripMenuItem("Show in Gadget (Ctrl+G)") { Checked = _gadget.Contains(node.Sensor) };
847855
item.Click += (s, _) =>
848856
{
849857
if (s is not ToolStripMenuItem menuItem)

OpenHardwareMonitor/UI/SensorGadget.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,11 +347,10 @@ public bool Contains(ISensor sensor)
347347
return _sensors.Values.Any(list => list.Contains(sensor));
348348
}
349349

350-
public void Add(ISensor sensor)
350+
public bool Add(ISensor sensor)
351351
{
352352
if (Contains(sensor))
353-
return;
354-
353+
return false;
355354

356355
// get the right hardware
357356
IHardware hardware = sensor.Hardware;
@@ -374,6 +373,7 @@ public void Add(ISensor sensor)
374373

375374
_settings.SetValue(new Identifier(sensor.Identifier, "gadget").ToString(), true);
376375
Resize();
376+
return true;
377377
}
378378

379379
public void Remove(ISensor sensor)

OpenHardwareMonitor/UI/SystemTray.cs

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.Collections.Generic;
3+
using System.Linq;
34
using System.Windows.Forms;
45
using OpenHardwareMonitor.Hardware;
56
using OpenHardwareMonitor.Utilities;
@@ -74,7 +75,7 @@ private void HardwareAdded(IHardware hardware)
7475
private void SensorAdded(ISensor sensor)
7576
{
7677
if (_settings.GetValue(new Identifier(sensor.Identifier, "tray").ToString(), false))
77-
Add(sensor, false);
78+
Add(sensor);
7879
}
7980

8081
private void SensorRemoved(ISensor sensor)
@@ -96,23 +97,17 @@ public void Redraw()
9697
icon.Update(ShowPercentageIcons);
9798
}
9899

99-
public bool Contains(ISensor sensor)
100-
{
101-
foreach (SensorNotifyIcon icon in _sensorList)
102-
if (icon.Sensor == sensor)
103-
return true;
104-
return false;
105-
}
100+
public bool Contains(ISensor sensor) => _sensorList.Any(icon => icon.Sensor == sensor);
106101

107-
public void Add(ISensor sensor, bool balloonTip)
102+
public bool Add(ISensor sensor)
108103
{
109104
if (Contains(sensor))
110-
return;
111-
105+
return false;
112106

113107
_sensorList.Add(new SensorNotifyIcon(this, sensor, _settings));
114108
UpdateMainIconVisibility();
115109
_settings.SetValue(new Identifier(sensor.Identifier, "tray").ToString(), true);
110+
return true;
116111
}
117112

118113
public void Remove(ISensor sensor)

0 commit comments

Comments
 (0)