HttpServer fix: return 400 bad request instead of no response

sergiye · sergiye · commit 5dca34c0906e · 2026-03-30T11:12:05.000+03:00
diff --git a/OpenHardwareMonitor/Utilities/HttpServer.cs b/OpenHardwareMonitor/Utilities/HttpServer.cs
@@ -341,6 +341,8 @@ private async Task HandleContextAsync(HttpListenerContext context)
             }
         }
 
+        try
+        {
         if (authenticated)
         {
             switch (request.HttpMethod)
@@ -422,15 +424,23 @@ private async Task HandleContextAsync(HttpListenerContext context)
             await SendResponseAsync(context.Response, responseString, "text/html");
         }
 
-        try
+        context.Response.Close();
+        }
+        catch(ArgumentException ex)
         {
+            context.Response.StatusCode = 400;
+            string responseString = @$"<HTML><HEAD><TITLE>400 Bad Request</TITLE></HEAD>
+    <BODY><H4>400 Bad Request</H4>
+    {ex.Message}</BODY></HTML> ";
+            await SendResponseAsync(context.Response, responseString, "text/html");
             context.Response.Close();
         }
         catch
         {
             // client closed connection before the content was sent
         }
     }
+
     private async Task ServeResourceFileAsync(HttpListenerResponse response, string name, string ext)
     {
         // resource names do not support the hyphen

Original file line number	Diff line number	Diff line change
`@@ -341,6 +341,8 @@ private async Task HandleContextAsync(HttpListenerContext context)`
`341`	`341`	`}`
`342`	`342`	`}`
`343`	`343`
	`344`	`+ try`
	`345`	`+ {`
`344`	`346`	`if (authenticated)`
`345`	`347`	`{`
`346`	`348`	`switch (request.HttpMethod)`
`@@ -422,15 +424,23 @@ private async Task HandleContextAsync(HttpListenerContext context)`
`422`	`424`	`await SendResponseAsync(context.Response, responseString, "text/html");`
`423`	`425`	`}`
`424`	`426`
`425`		`- try`
	`427`	`+ context.Response.Close();`
	`428`	`+ }`
	`429`	`+ catch(ArgumentException ex)`
`426`	`430`	`{`
	`431`	`+ context.Response.StatusCode = 400;`
	`432`	`+ string responseString = @$"<HTML><HEAD><TITLE>400 Bad Request</TITLE></HEAD>`
	`433`	`+ <BODY><H4>400 Bad Request</H4>`
	`434`	`+ {ex.Message}</BODY></HTML> ";`
	`435`	`+ await SendResponseAsync(context.Response, responseString, "text/html");`
`427`	`436`	`context.Response.Close();`
`428`	`437`	`}`
`429`	`438`	`catch`
`430`	`439`	`{`
`431`	`440`	`// client closed connection before the content was sent`
`432`	`441`	`}`
`433`	`442`	`}`
	`443`	`+`
`434`	`444`	`private async Task ServeResourceFileAsync(HttpListenerResponse response, string name, string ext)`
`435`	`445`	`{`
`436`	`446`	`// resource names do not support the hyphen`