Fix issues with missing samsung nvme data. (#1818)

Reorder read out order in the same way as CrystalDiskInfo

Author: sebastian-dev

LibreHardwareMonitorLib/Hardware/Storage/NVMeSamsung.cs

@@ -36,7 +36,6 @@ public bool IdentifyController(SafeHandle hDevice, out Kernel32.NVME_IDENTIFY_CO
         buffers.Spt.TargetId = 0;
         buffers.Spt.Lun = 0;
         buffers.Spt.SenseInfoLength = 24;
-        buffers.Spt.DataIn = 1;
         buffers.Spt.DataTransferLength = (uint)buffers.DataBuf.Length;
         buffers.Spt.TimeOutValue = 2;
         buffers.Spt.DataBufferOffset = Marshal.OffsetOf(typeof(Kernel32.SCSI_PASS_THROUGH_WITH_BUFFERS), nameof(Kernel32.SCSI_PASS_THROUGH_WITH_BUFFERS.DataBuf));
@@ -67,7 +66,6 @@ public bool IdentifyController(SafeHandle hDevice, out Kernel32.NVME_IDENTIFY_CO
             buffers.Spt.Lun = 0;
             buffers.Spt.SenseInfoLength = 24;
             buffers.Spt.DataTransferLength = (uint)buffers.DataBuf.Length;
-            buffers.Spt.DataIn = 1;
             buffers.Spt.TimeOutValue = 2;
             buffers.Spt.DataBufferOffset = Marshal.OffsetOf<Kernel32.SCSI_PASS_THROUGH_WITH_BUFFERS>(nameof(Kernel32.SCSI_PASS_THROUGH_WITH_BUFFERS.DataBuf));
             buffers.Spt.SenseInfoOffset = (uint)Marshal.OffsetOf<Kernel32.SCSI_PASS_THROUGH_WITH_BUFFERS>(nameof(Kernel32.SCSI_PASS_THROUGH_WITH_BUFFERS.SenseBuf));

LibreHardwareMonitorLib/Hardware/Storage/NVMeSmart.cs

@@ -21,6 +21,16 @@ internal NVMeSmart(StorageInfo storageInfo)
         NVMeDrive = null;
         string name = storageInfo.Name;
 
+        // Test Windows generic driver protocol.
+        if (NVMeDrive == null)
+        {
+            _handle = NVMeWindows.IdentifyDevice(storageInfo);
+            if (_handle != null)
+            {
+                NVMeDrive = new NVMeWindows();
+            }
+        }
+
         // Test Samsung protocol.
         if (NVMeDrive == null && name.IndexOf("Samsung", StringComparison.OrdinalIgnoreCase) > -1)
         {
@@ -54,16 +64,6 @@ internal NVMeSmart(StorageInfo storageInfo)
                 NVMeDrive = new NVMeIntelRst();
             }
         }
-
-        // Test Windows generic driver protocol.
-        if (NVMeDrive == null)
-        {
-            _handle = NVMeWindows.IdentifyDevice(storageInfo);
-            if (_handle != null)
-            {
-                NVMeDrive = new NVMeWindows();
-            }
-        }
     }
 
     public bool IsValid
@@ -187,4 +187,4 @@ public NVMeHealthInfo(Kernel32.NVME_HEALTH_INFO_LOG log)
                 TemperatureSensors[i] = KelvinToCelsius(log.TemperatureSensor[i]);
         }
     }
-}
+}