settings save optimized

Author: sergiye

OpenHardwareMonitor/UI/HardwareNode.cs

@@ -69,6 +69,7 @@ public bool Expanded
         get => _expanded;
         set
         {
+            if (_expanded == value) return;
             _expanded = value;
             _settings.SetValue(_expandedIdentifier, _expanded);
         }

OpenHardwareMonitor/UI/TypeNode.cs

@@ -136,6 +136,7 @@ public bool Expanded
         get => _expanded;
         set
         {
+            if (_expanded == value) return;
             _expanded = value;
             _settings.SetValue(_expandedIdentifier, _expanded);
         }

OpenHardwareMonitor/Utilities/PersistentSettings.cs

@@ -112,15 +112,18 @@ public void SaveToFile(string configFilePath)
         }
     }
 
+    private bool isPortable = true;
     public bool IsPortable
     {
         get
         {
-            return GetValue("portable", true);
+            return isPortable;
         }
         set
         {
-            SetValue("portable", value);
+            if (isPortable == value) return;
+            isPortable = value;
+            Save();
         }
     }
 
@@ -131,6 +134,7 @@ public bool Contains(string name)
 
     public void SetValue(string name, string value)
     {
+        if (_settings.TryGetValue(name, out var prevValue) && prevValue == value) return;
         _settings[name] = value;
         Save();
     }
@@ -152,6 +156,7 @@ public void Remove(string name)
 
     public void SetValue(string name, int value)
     {
+        if (_settings.TryGetValue(name, out var prevValue) && int.TryParse(prevValue, out var oldValue) && oldValue == value) return;
         _settings[name] = value.ToString();
         Save();
     }
@@ -172,6 +177,7 @@ public int GetValue(string name, int value)
 
     public void SetValue(string name, float value)
     {
+        if (_settings.TryGetValue(name, out var prevValue) && float.TryParse(prevValue, out var oldValue) && oldValue == value) return;
         _settings[name] = value.ToString(CultureInfo.InvariantCulture);
         Save();
     }
@@ -201,6 +207,7 @@ public double GetValue(string name, double value)
 
     public void SetValue(string name, bool value)
     {
+        if (_settings.TryGetValue(name, out var prevValue) && bool.TryParse(prevValue, out var oldValue) && oldValue == value) return;
         _settings[name] = value ? "true" : "false";
         Save();
     }
@@ -217,6 +224,7 @@ public bool GetValue(string name, bool value)
 
     public void SetValue(string name, Color color)
     {
+        if (_settings.TryGetValue(name, out var prevValue) && int.TryParse(prevValue, NumberStyles.HexNumber, CultureInfo.InvariantCulture, out int parsedValue) && Color.FromArgb(parsedValue) == color) return;
         _settings[name] = color.ToArgb().ToString("X8");
         Save();
     }

OpenHardwareMonitorLib/Hardware/Sensor.cs

@@ -85,6 +85,7 @@ public string Name
         get { return _name; }
         set
         {
+            if (_name == value) return;
             _name = !string.IsNullOrEmpty(value) ? value : _defaultName;
 
             _settings.SetValue(new Identifier(Identifier, "name").ToString(), _name);