Enable more lenient parsing of report descriptor on Windows.

HidSharp has trouble parsing some report descriptors on Windows.
This makes some devices unusable with HidSharp. By discarding report items
which overlap or report items having undefined usage values (0)
we enable more lenient parsing. This makes HidSharp usable with more devices.

Author: Joop-Schilder

HidSharp/Platform/Windows/WinHidDevice.ReportDescriptorReconstructor.cs

@@ -69,8 +69,6 @@ void AddButtonGlobalItems(int bitCount)
 
             void PadReport(MainItemTag mainItemTag, int padToBit, ref int currentBit)
             {
-                if (currentBit > padToBit) { throw new NotImplementedException(); } // Overlapping...
-
                 // Padding...
                 int paddingBitCount = padToBit - currentBit;
                 if (paddingBitCount > 0)
@@ -195,11 +193,20 @@ the capability array contains only one capability structure that describes one b
                     var reportItems = report.Where(x => x.BitOffset != maxBit).OrderBy(x => x.BitOffset).ToArray();
                     foreach (var reportItem in reportItems)
                     {
-                        var button = reportItem.Button;
                         var item = reportItem.Item;
                         int startBit = reportItem.BitOffset;
                         int bitCount = reportItem.ReportCount * reportItem.ReportSize;
-                        if (currentBit > startBit) { throw new NotImplementedException(); } // Overlapping...
+
+                        // This usage value is of no use.
+                        if (item.UsageIndex == 0)
+                        {
+                            continue;
+                        }
+                        // This report item overlaps another.
+                        if (currentBit > startBit)
+                        {
+                            break;
+                        }
 
                         SetCollection(item.LinkCollection);
                         PadReport(mainItemTag, startBit, ref currentBit);
@@ -218,7 +225,7 @@ the capability array contains only one capability structure that describes one b
                             _builder.AddLocalItem(LocalItemTag.Usage, usageMin);
                         }
 
-                        if (button)
+                        if (reportItem.Button)
                         {
                             AddButtonGlobalItems(reportItem.ReportCount);
                         }

HidSharp/Reports/Input/DeviceItemInputParser.cs

@@ -121,9 +121,19 @@ public bool TryParseReport(byte[] buffer, int offset, Report report)
                 var rangeOfElementsByIndexOfDataItem = _rangesOfElementsByIndexOfDataItem[reportIndex];
                 report.Read(buffer, offset, (reportBuffer, bitOffset, dataItem, indexOfDataItem) =>
                     {
+                        // This usage value is of no use.
+                        if (dataItem.Usages.GetAllValues().FirstOrDefault() == 0)
+                        {
+                            return;
+                        }
+
                         int dataItemStartElement = rangeOfElementsByIndexOfDataItem[indexOfDataItem];
                         int dataItemEndElement = rangeOfElementsByIndexOfDataItem[indexOfDataItem + 1];
-                        if (dataItemStartElement == dataItemEndElement) { return; } // We skipped this one.
+                        // We skipped this one.
+                        if (dataItemStartElement == dataItemEndElement)
+                        {
+                            return;
+                        }
 
                         int elementCount = dataItem.ElementCount;
                         for (int elementIndex = 0; elementIndex < elementCount; elementIndex++)
@@ -132,6 +142,12 @@ public bool TryParseReport(byte[] buffer, int offset, Report report)
                             if (dataItem.TryReadValue(reportBuffer, bitOffset, elementIndex, out newDataValue))
                             {
                                 int indexOfElement = dataItemStartElement + newDataValue.DataIndex;
+                                // This index is out of bounds.
+                                if (indexOfElement >= _newDataValues.Count())
+                                {
+                                    continue;
+                                }
+
                                 _newDataValues[indexOfElement] = newDataValue;
                             }
                         }