Skip to content

Commit da120a7

Browse files
committed
Merge remote-tracking branch 'libre/master'
# Conflicts: # .github/workflows/master.yml # .github/workflows/pull requests.yml # Directory.Build.props # LibreHardwareMonitor/UI/MainForm.Designer.cs # LibreHardwareMonitor/UI/PortForm.cs # OpenHardwareMonitor/UI/InterfacePortForm.Designer.cs # OpenHardwareMonitor/UI/InterfacePortForm.cs # OpenHardwareMonitor/UI/InterfacePortForm.resx # OpenHardwareMonitor/UI/PortForm.cs # OpenHardwareMonitor/Utilities/HttpServer.cs # OpenHardwareMonitorLib/Hardware/Controller/AquaComputer/Quadro.cs # OpenHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs
2 parents dc85912 + 5e17858 commit da120a7

35 files changed

Lines changed: 1225 additions & 617 deletions

OpenHardwareMonitor/OpenHardwareMonitor.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@
4646
<Compile Update="UI\ParameterForm.Designer.cs">
4747
<DependentUpon>ParameterForm.cs</DependentUpon>
4848
</Compile>
49-
<Compile Update="UI\PortForm.Designer.cs">
50-
<DependentUpon>PortForm.cs</DependentUpon>
49+
<Compile Update="UI\InterfacePortForm.Designer.cs">
50+
<DependentUpon>InterfacePortForm.cs</DependentUpon>
5151
</Compile>
5252
</ItemGroup>
5353
<ItemGroup>
@@ -63,8 +63,8 @@
6363
<EmbeddedResource Update="UI\ParameterForm.resx">
6464
<DependentUpon>ParameterForm.cs</DependentUpon>
6565
</EmbeddedResource>
66-
<EmbeddedResource Update="UI\PortForm.resx">
67-
<DependentUpon>PortForm.cs</DependentUpon>
66+
<EmbeddedResource Update="UI\InterfacePortForm.resx">
67+
<DependentUpon>InterfacePortForm.cs</DependentUpon>
6868
</EmbeddedResource>
6969
</ItemGroup>
7070
<ItemGroup>

OpenHardwareMonitor/UI/InterfacePortForm.Designer.cs

Lines changed: 215 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

OpenHardwareMonitor/UI/PortForm.cs renamed to OpenHardwareMonitor/UI/InterfacePortForm.cs

Lines changed: 35 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,37 +3,51 @@
33
using System.Net;
44
using System.Net.Sockets;
55
using System.Diagnostics;
6+
using static System.Windows.Forms.VisualStyles.VisualStyleElement;
7+
using System.Net.NetworkInformation;
68

79
namespace OpenHardwareMonitor.UI;
810

9-
public partial class PortForm : Form
11+
public partial class InterfacePortForm : Form
1012
{
1113
private readonly MainForm _parent;
12-
private readonly string _localIP;
13-
public PortForm(MainForm m)
14+
private string _localIP;
15+
16+
public InterfacePortForm(MainForm m)
1417
{
1518
InitializeComponent();
1619
Icon = System.Drawing.Icon.ExtractAssociatedIcon(Utilities.Updater.CurrentFileLocation);
1720
_parent = m;
18-
_localIP = GetLocalIP();
21+
_localIP = LoadNetworkInterfaces(_parent.Server.ListenerIp);
1922
}
2023

21-
private void PortTextBox_TextChanged(object sender, EventArgs e)
22-
{
23-
24-
}
25-
26-
private string GetLocalIP()
24+
private string LoadNetworkInterfaces(string selectedListenerIp)
2725
{
2826
IPHostEntry host;
29-
string localIP = "?";
27+
interfaceComboBox.Items.Clear();
3028
host = Dns.GetHostEntry(Dns.GetHostName());
3129
foreach (IPAddress ip in host.AddressList)
3230
{
3331
if (ip.AddressFamily == AddressFamily.InterNetwork)
34-
localIP = ip.ToString();
32+
interfaceComboBox.Items.Add(ip.ToString());
33+
}
34+
// select the last one by default to match the existing behavior
35+
if (interfaceComboBox.Items.Count > 0)
36+
{
37+
interfaceComboBox.SelectedIndex = interfaceComboBox.Items.Count - 1;
38+
} else
39+
{
40+
// default to ? just like previous version
41+
interfaceComboBox.Items.Add("?");
42+
interfaceComboBox.SelectedIndex = 0;
3543
}
36-
return localIP;
44+
// check to see if the selected listener IP is in our list.
45+
if (interfaceComboBox.Items.Contains(selectedListenerIp))
46+
{
47+
// default it to the previously selected IP.
48+
interfaceComboBox.SelectedItem = selectedListenerIp;
49+
}
50+
return interfaceComboBox.SelectedItem as string;
3751
}
3852

3953
private void PortNumericUpDn_ValueChanged(object sender, EventArgs e)
@@ -47,6 +61,7 @@ private void PortNumericUpDn_ValueChanged(object sender, EventArgs e)
4761
private void PortOKButton_Click(object sender, EventArgs e)
4862
{
4963
_parent.Server.ListenerPort = (int)portNumericUpDn.Value;
64+
_parent.Server.ListenerIp = _localIP;
5065
Close();
5166
}
5267

@@ -57,6 +72,7 @@ private void PortCancelButton_Click(object sender, EventArgs e)
5772

5873
private void PortForm_Load(object sender, EventArgs e)
5974
{
75+
interfaceComboBox.SelectedValue = _parent.Server.ListenerIp;
6076
portNumericUpDn.Value = _parent.Server.ListenerPort;
6177
PortNumericUpDn_ValueChanged(null, null);
6278
}
@@ -74,4 +90,10 @@ private void PortNumericUpDn_KeyUp(object sender, KeyEventArgs e)
7490
{
7591
PortNumericUpDn_ValueChanged(null, null);
7692
}
93+
94+
private void interfaceComboBox_SelectedIndexChanged(object sender, EventArgs e)
95+
{
96+
_localIP = interfaceComboBox.SelectedItem as string;
97+
PortNumericUpDn_ValueChanged(null, null);
98+
}
7799
}

0 commit comments

Comments
 (0)