Log

Author: rohe

src/oidcrp/oauth2/utils.py

@@ -1,5 +1,9 @@
+import logging
+
 from oidcmsg.exception import MissingParameter
 
+logger = logging.getLogger(__name__)
+
 
 def get_state_parameter(request_args, kwargs):
     """Find a state value from a set of possible places."""
@@ -23,23 +27,21 @@ def pick_redirect_uris(request_args=None, service=None, **kwargs):
 
     _callback = _context.callback
     if _callback:
-        try:
-            _response_type = request_args['response_type']
-        except KeyError:
-            _response_type = _context.behaviour['response_types'][0]
-            request_args['response_type'] = _response_type
+        _response_type = request_args.get('response_type', _context.behaviour['response_types'][0])
+        request_args['response_type'] = _response_type
 
-        try:
-            _response_mode = request_args['response_mode']
-        except KeyError:
-            _response_mode = ''
+        _response_mode = request_args.get('response_mode')
 
         if _response_mode == 'form_post':
             request_args['redirect_uri'] = _callback['form_post']
         elif _response_type == 'code':
             request_args['redirect_uri'] = _callback['code']
         else:
             request_args['redirect_uri'] = _callback['implicit']
+
+        logger.debug(
+            f"pick_redirect_uris: response_type={_response_type}, response_mode={_response_mode}, "
+            f"redirect_uri={request_args['redirect_uri']}")
     else:
         request_args['redirect_uri'] = _context.redirect_uris[0]
 

src/oidcrp/rp_handler.py

@@ -775,7 +775,7 @@ def finalize(self, issuer, response, behaviour_args: Optional[dict] = None):
         client = self.issuer2rp[issuer]
 
         if behaviour_args:
-            logger.debug(f"Behaviour args: {behaviour_args}")
+            logger.debug(f"Finalize behaviour args: {behaviour_args}")
 
         authorization_response = self.finalize_auth(client, issuer, response)
         if is_error_message(authorization_response):