Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Commit 94e3d43

Browse files
committed
Use get() to handle invalid assumptions.
1 parent 18b37d6 commit 94e3d43

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

flask_rp/views.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ def finalize(op_hash, request_args):
9696
logger.error(rp.response[0].decode())
9797
return rp.response[0], rp.status_code
9898

99-
session['client_id'] = rp.service_context.registration_response.\
100-
get('client_id', rp.service_context.client_id)
99+
session['client_id'] = rp.service_context.registration_response. \
100+
get('client_id', rp.service_context.client_id)
101101

102102
session['state'] = request_args.get('state')
103103

@@ -126,15 +126,14 @@ def finalize(op_hash, request_args):
126126
endp = endp.capitalize()
127127
endpoints[endp] = v
128128

129-
try:
130-
kwargs = {
131-
'check_session_iframe': rp.service_context.provider_info[
132-
'check_session_iframe']
133-
}
134-
except KeyError:
135-
kwargs = {}
136-
else:
137-
kwargs["status_check_iframe"] = rp.service_context.add_on['status_check']
129+
kwargs = {}
130+
_chk_iframe = rp.service_context.provider_info.get('check_session_iframe')
131+
if _chk_iframe:
132+
kwargs['check_session_iframe'] = _chk_iframe
133+
134+
_status_iframe = rp.service_context.add_on.get('status_check')
135+
if _status_iframe:
136+
kwargs["status_check_iframe"] = _status_iframe
138137

139138
kwargs['logout_url'] = "{}/logout".format(rp.service_context.base_url)
140139

0 commit comments

Comments
 (0)