v1.0.3

Author: peppelinux

CHANGES

@@ -1,6 +1,10 @@
 Changes
 =======
 
+v1.0.3 (2020-02-04)
+- Django Logout behaviour improved
+
+
 v1.0.2 (2020-01-24)
 - RequestVersionTooLow exception handled in ACS
 - Better exception handling for Malformed SAML Response

djangosaml2/views.py

@@ -469,7 +469,7 @@ def get(self, request, *args, **kwargs):
             logger.exception('Error Handled - SLO not supported by IDP: {}'.format(exp))
             auth.logout(request)
             state.sync()
-            return HttpResponseRedirect(settings.LOGOUT_REDIRECT_URL)
+            return HttpResponseRedirect(getattr(settings, 'LOGOUT_REDIRECT_URL', '/'))
 
         auth.logout(request)
         state.sync()
@@ -570,8 +570,8 @@ def do_logout_service(self, request, data, binding):
 
 def finish_logout(request, response, next_page=None):
     if (getattr(settings, 'SAML_IGNORE_LOGOUT_ERRORS', False) or (response and response.status_ok())):
-        if next_page is None and hasattr(settings, 'LOGOUT_REDIRECT_URL'):
-            next_page = settings.LOGOUT_REDIRECT_URL
+        if not next_page:
+            next_page = getattr(settings, 'LOGOUT_REDIRECT_URL', '/')
         logger.debug('Performing django logout with a next_page of %s', next_page)
         return AuthLogoutView.as_view()(request, next_page=next_page)
     logger.error('Unknown error during the logout')

setup.py

@@ -24,7 +24,7 @@ def read(*rnames):
 
 setup(
     name='djangosaml2',
-    version='1.0.2',
+    version='1.0.3',
     description='pysaml2 integration for Django',
     long_description=read('README.rst'),
     classifiers=[