v1.1.1 - RTD and Information exposure prevention

Author: peppelinux

djangosaml2/views.py

@@ -246,15 +246,16 @@ def get(self, request, *args, **kwargs):
         sso_kwargs['nsprefix'] = get_namespace_prefixes()
 
         logger.debug(f'Redirecting user to the IdP via {binding} binding.')
+        _msg = 'Unable to know which IdP to use'
         if binding == saml2.BINDING_HTTP_REDIRECT:
             try:
                 session_id, result = client.prepare_for_authenticate(
                     entityid=selected_idp, relay_state=next_path,
                     binding=binding, sign=sign_requests,
                     **sso_kwargs)
             except TypeError as e:
-                logger.error('Unable to know which IdP to use')
-                return HttpResponse(str(e))
+                logger.error(f'{_msg}: {e}')
+                return HttpResponse(_msg)
             else:
                 http_response = HttpResponseRedirect(get_location(result))
         elif binding == saml2.BINDING_HTTP_POST:
@@ -263,8 +264,8 @@ def get(self, request, *args, **kwargs):
                 try:
                     location = client.sso_location(selected_idp, binding)
                 except TypeError as e:
-                    logger.error('Unable to know which IdP to use')
-                    return HttpResponse(str(e))
+                    logger.error(f'{_msg}: {e}')
+                    return HttpResponse(_msg)
                 session_id, request_xml = client.create_authn_request(
                     location,
                     binding=binding,
@@ -293,8 +294,9 @@ def get(self, request, *args, **kwargs):
                         entityid=selected_idp, relay_state=next_path,
                         binding=binding)
                 except TypeError as e:
-                    logger.error('Unable to know which IdP to use')
-                    return HttpResponse(str(e))
+                    _msg = f"Can't prepare the authentication for {selected_idp}"
+                    logger.error(f'{_msg}: {e}')
+                    return HttpResponse(_msg)
                 else:
                     http_response = HttpResponse(result['data'])
         else:

setup.py

@@ -24,7 +24,7 @@ def read(*rnames):
 
 setup(
     name='djangosaml2',
-    version='1.1.0',
+    version='1.1.1',
     description='pysaml2 integration for Django',
     long_description=read('README.md'),
     long_description_content_type='text/markdown',