some cleanup

Author: mhindery

djangosaml2/backends.py

@@ -215,6 +215,17 @@ def _update_user(self, user, attributes, attribute_mapping, force_save=False):
                 else:
                     logger.debug('Could not find attribute "%s" on user "%s"', attr, user)
 
+        signal_modified = self.send_user_update_signal(user, attributes, user_modified)
+
+        if user_modified or signal_modified or force_save:
+            user.save()
+            logger.debug('User updated with incoming attributes')
+
+        return user
+
+    def send_user_update_signal(self, user, attributes, user_modified) -> bool:
+        """ Send out a pre-save signal after the user has been updated with the SAML attributes.
+        """
         logger.debug('Sending the pre_save signal')
         signal_modified = any(
             [response for receiver, response
@@ -223,9 +234,4 @@ def _update_user(self, user, attributes, attribute_mapping, force_save=False):
                                           attributes=attributes,
                                           user_modified=user_modified)]
             )
-
-        if user_modified or signal_modified or force_save:
-            user.save()
-            logger.debug('User updated with incoming attributes')
-
-        return user
+        return signal_modified

djangosaml2/utils.py

@@ -77,5 +77,6 @@ def fail_acs_response(request, *args, **kwargs):
     The default behavior uses SAML specific template that is rendered on any ACS error,
     but this can be simply changed so that PermissionDenied exception is raised instead.
     """
-    failure_function = import_string(get_custom_setting('SAML_ACS_FAILURE_RESPONSE_FUNCTION', 'djangosaml2.acs_failures.template_failure'))
+    failure_function = import_string(get_custom_setting('SAML_ACS_FAILURE_RESPONSE_FUNCTION',
+                                                        'djangosaml2.acs_failures.template_failure'))
     return failure_function(request, *args, **kwargs)