Skip to content

Commit ea89ee3

Browse files
committed
fix(#26) No more results with no prev results
1 parent 8b810e6 commit ea89ee3

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

dashboard/core/bots/reports/views.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def build_filters(self, is_improvement=True) -> dict:
7979
'root_test__in': tests,
8080
'bot__in': bot,
8181
'browser__in': browsers,
82-
'is_improvement': is_improvement
82+
'is_improvement': is_improvement,
8383
}
8484

8585

@@ -91,7 +91,8 @@ def get_queryset(self):
9191
queryset = super(BotDataReportImprovementListView, self).get_queryset()
9292
filter_params = self.build_filters(is_improvement=True)
9393
limit = int(self.kwargs.get('limit', 10))
94-
return queryset.filter(**filter_params).order_by('-delta')[:limit]
94+
return queryset.filter(**filter_params).exclude(
95+
prev_result__isnull=True).order_by('-delta')[:limit]
9596

9697

9798
class BotDataReportRegressionListView(ReportDataBaseListViewSerializer):
@@ -102,7 +103,8 @@ def get_queryset(self):
102103
queryset = super(BotDataReportRegressionListView, self).get_queryset()
103104
filter_params = self.build_filters(is_improvement=False)
104105
limit = int(self.kwargs.get('limit', 10))
105-
return queryset.filter(**filter_params).order_by('-delta')[:limit]
106+
return queryset.filter(**filter_params).exclude(
107+
prev_result__isnull=True).order_by('-delta')[:limit]
106108

107109

108110
class TestPathList(ListAPIView):

0 commit comments

Comments
 (0)