Skip to content

Commit b862387

Browse files
refactor(agents): address comments
1 parent 0f2c8be commit b862387

4 files changed

Lines changed: 25 additions & 12 deletions

File tree

.github/agents/bug-fixing-implementer-agent.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ Check the relevant skill file for component APIs and patterns:
3939
- Grid components → `skills/igniteui-angular-grids/SKILL.md`
4040
- Theming & styling → `skills/igniteui-angular-theming/SKILL.md`
4141

42-
Each skill file is a routing hub pointing to detailed reference files under its `references/` folder. **Read the relevant reference files in full** before modifying any component code.
43-
4442
---
4543

4644
## GREEN Phase — Fix the Bug

.github/agents/bug-fixing-orchestrator-agent.md

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,13 @@ src/app/<component>/ ← demo pages
134134

135135
Run `npm start` if the bug involves UI behavior or user interaction to visually confirm the issue.
136136

137-
### Step 2 — Present a Scope Summary
137+
### Step 2 — Request Missing Context
138+
139+
If the report is missing information needed to reproduce or scope the bug safely, pause and ask for the missing context before routing any work.
140+
141+
Keep the follow-up short and specific.
142+
143+
### Step 3 — Present a Scope Summary
138144

139145
Present a brief scope summary to the user:
140146

@@ -149,7 +155,7 @@ Keep it short and high-level. Confirm scope, not solution details.
149155

150156
Wait for user confirmation.
151157

152-
### Step 3 — Route Work
158+
### Step 4 — Route Work
153159

154160
Delegate work only through isolated subagent execution when available. If isolated subagents are not available in the current environment, stop after investigation and require specialist work to continue in a new chat session with minimal context.
155161

@@ -168,11 +174,11 @@ Use agents in this order:
168174
4. **`migration-agent`** — only if the fix introduces a breaking change
169175
5. **`changelog-agent`** — only if the fix warrants an entry under an existing CHANGELOG sections; otherwise leave `CHANGELOG.md` unchanged
170176

171-
### Step 4 — Verify Completeness
177+
### Step 5 — Verify Completeness
172178

173179
After all agents finish, check:
174180

175-
- Does the failing test now pass?
181+
- Does the newly added failing test now pass?
176182
- Were all affected areas covered?
177183
- Were public exports preserved or updated?
178184
- Was the component README updated (if needed)?
@@ -199,7 +205,7 @@ Report what was done and any remaining items.
199205

200206
## Multi-branch Fixes
201207

202-
When a bug exists in multiple release branches:
208+
When a bug exists in multiple supported release branches:
203209
1. Target the fix at the **oldest affected branch** first.
204210
2. Cherry-pick the commit to each newer branch up to and including `master`.
205211
3. Create separate PRs for each cherry-pick.

.github/agents/feature-orchestrator-agent.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,13 @@ src/app/<component>/ ← demo pages
119119
- Whether i18n strings are affected
120120
- Which test suite to use (grid vs non-grid)
121121

122-
### Step 2 — Present a Scope Summary
122+
### Step 2 — Request Missing Context
123+
124+
If the request is missing information needed to discover scope safely, pause and ask for the missing context before routing any work.
125+
126+
Keep the follow-up short and specific.
127+
128+
### Step 3 — Present a Scope Summary
123129

124130
Present a brief scope summary to the user:
125131

@@ -133,7 +139,7 @@ Keep it short and high-level. Confirm scope, not solution details.
133139

134140
Wait for user confirmation.
135141

136-
### Step 3 — Route Work
142+
### Step 4 — Route Work
137143

138144
Delegate work only through isolated subagent execution when available. If isolated subagents are not available in the current environment, stop after scope discovery and require specialist work to continue in a new chat session with minimal context.
139145

@@ -158,7 +164,7 @@ Use agents in this order:
158164
4. **`migration-agent`** — only if breaking changes exist
159165
5. **`changelog-agent`** — updates CHANGELOG.md
160166

161-
### Step 4 — Verify Completeness
167+
### Step 5 — Verify Completeness
162168

163169
After all agents finish, check:
164170

AGENTS.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ css-naming-convention.md ← CSS naming rules
5454
- Keep accessibility intact: ARIA, keyboard navigation, focus behavior, and screen reader semantics.
5555
- Keep i18n intact when user-facing text changes.
5656
- Add JSDoc with `@param`, `@returns`, and `@example` on every new public member.
57-
- Add or update ng update migrations for breaking changes.
57+
- Add or update `ng update` migrations for true breaking changes such as removals, renames, moved entry points, selector changes, or incompatible default-behavior changes.
5858
- Update the component `README.md` when the public API surface changes.
5959
- Consider demo/sample updates in `src/app/` for user-visible changes.
60-
- Update `CHANGELOG.md` for every new feature, deprecation, or breaking change.
60+
- Update `CHANGELOG.md` for new features, deprecations, breaking changes, and notable user-visible fixes when they fit the existing changelog section structure.
6161

6262
### Never
6363

@@ -118,6 +118,9 @@ Feature implementation is handled by a set of specialized agents in `.github/age
118118
| `migration-agent` | `migration-agent.md` | Creates `ng update` migration schematics for breaking changes |
119119
| `changelog-agent` | `changelog-agent.md` | Updates `CHANGELOG.md` following repo conventions |
120120

121+
Feature and bug orchestrators route work in this order:
122+
TDD → implementer → README (if needed) → migration (if breaking) → changelog (if needed).
123+
121124
## Commit Message Conventions
122125

123126
When creating or suggesting a commit message, follow this format:

0 commit comments

Comments
 (0)