cleaning up warnings

ig-robstoffers · ig-robstoffers · commit f5fac0320132 · 2020-07-29T15:31:40.000-04:00
diff --git a/DataSource.DataProviders.SQLite/SQLiteDataProvider/SQLiteDataSourceFilterExpressionVisitor.cs b/DataSource.DataProviders.SQLite/SQLiteDataProvider/SQLiteDataSourceFilterExpressionVisitor.cs
@@ -283,7 +283,6 @@ public override void VisitFunctionExpression(IFunctionFilterExpression expressio
                 case FilterExpressionFunctionType.Ceiling:
                     throw new NotImplementedException();
                     //functionName = "ceiling";
-                    break;
                 case FilterExpressionFunctionType.Concat:
                     between = " || ";
                     break;
@@ -294,18 +293,15 @@ public override void VisitFunctionExpression(IFunctionFilterExpression expressio
                     break;
 				case FilterExpressionFunctionType.Day:
                     throw new NotImplementedException();
-                    break;
 				case FilterExpressionFunctionType.EndsWith:
                     unquote = true;
                     between = " LIKE '%";
                     postfix = "'";
                     break;
                 case FilterExpressionFunctionType.Floor:
                     throw new NotImplementedException();
-                    break;
                 case FilterExpressionFunctionType.Hour:
                     throw new NotImplementedException();
-                    break;
                 case FilterExpressionFunctionType.IndexOf:
                     functionName = "intstr";
                     break;
@@ -314,10 +310,8 @@ public override void VisitFunctionExpression(IFunctionFilterExpression expressio
                     break;
                 case FilterExpressionFunctionType.Minute:
                     throw new NotImplementedException();
-                    break;
                 case FilterExpressionFunctionType.Month:
                     throw new NotImplementedException();
-                    break;
                 case FilterExpressionFunctionType.Replace:
                     functionName = "replace";
                     break;
@@ -326,7 +320,6 @@ public override void VisitFunctionExpression(IFunctionFilterExpression expressio
                     break;
                 case FilterExpressionFunctionType.Second:
                     throw new NotImplementedException();
-                    break;
                 case FilterExpressionFunctionType.StartsWith:
                     unquote = true;
                     between = " LIKE '";
@@ -346,7 +339,6 @@ public override void VisitFunctionExpression(IFunctionFilterExpression expressio
                     break;
                 case FilterExpressionFunctionType.Year:
                     throw new NotImplementedException();
-                    break;
             }
 
             if (functionName != null)
diff --git a/DataSource.DataProviders.SQLite/SQLiteDataProvider/SQLiteVirtualDataSourceDataProviderWorker.cs b/DataSource.DataProviders.SQLite/SQLiteDataProvider/SQLiteVirtualDataSourceDataProviderWorker.cs
@@ -497,7 +497,7 @@ protected override void ProcessCompletedTask(AsyncDataSourcePageTaskHolder compl
                     return;
                 }
             }
-            catch (TaskCanceledException e)
+            catch (TaskCanceledException)
             {
                 RetryIndex(pageIndex, currentDelay);
                 //TODO: other exceptions? Is there a way to skip this state for canceled stuff?
diff --git a/ODataDataProvider/ODataVirtualDataSourceDataProviderWorker.cs b/ODataDataProvider/ODataVirtualDataSourceDataProviderWorker.cs
@@ -94,8 +94,9 @@ protected override void Initialize()
 
             lock (SyncLock)
             {
-                _client = new ODataClient(new ODataClientSettings(_baseUri)
+                _client = new ODataClient(new ODataClientSettings()
                 {
+                    BaseUri = new Uri(_baseUri),
                     IgnoreUnmappedProperties = true
                 });
             }
@@ -206,7 +207,7 @@ protected override void ProcessCompletedTask(AsyncDataSourcePageTaskHolder compl
                     return;
                 }
             }
-            catch (TaskCanceledException e)
+            catch (TaskCanceledException)
             {
                 RetryIndex(pageIndex, currentDelay);
                 //TODO: other exceptions? Is there a way to skip this state for canceled stuff?
@@ -436,7 +437,7 @@ private ISectionInformation[] ResolveGroupInformation()
 
                     return groupInformation.ToArray();
                 }
-                catch (Exception e)
+                catch (Exception)
                 {
                     return null;
                 }
@@ -518,7 +519,7 @@ private ISummaryResult[] ResolveSummaryInformation()
 
                     return CreateSummaryResults(summaryData);
                 }
-                catch (Exception e)
+                catch (Exception)
                 {
                     return null;
                 }
@@ -666,7 +667,6 @@ private DataSourceSchemaPropertyType ResolvePropertyType(string propertyName)
         }
 
         private string _filterString = null;
-        private string _selectedString = null;
         public const int SchemaRequestIndex = -1;
         private SortDescriptionCollection _groupDescriptions;
         private bool _isAggregationSupportedByServer = false;

Original file line number	Diff line number	Diff line change
`@@ -497,7 +497,7 @@ protected override void ProcessCompletedTask(AsyncDataSourcePageTaskHolder compl`
`497`	`497`	`return;`
`498`	`498`	`}`
`499`	`499`	`}`
`500`		`- catch (TaskCanceledException e)`
	`500`	`+ catch (TaskCanceledException)`
`501`	`501`	`{`
`502`	`502`	`RetryIndex(pageIndex, currentDelay);`
`503`	`503`	`//TODO: other exceptions? Is there a way to skip this state for canceled stuff?`
Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,9 @@ protected override void Initialize()`
`94`	`94`
`95`	`95`	`lock (SyncLock)`
`96`	`96`	`{`
`97`		`- _client = new ODataClient(new ODataClientSettings(_baseUri)`
	`97`	`+ _client = new ODataClient(new ODataClientSettings()`
`98`	`98`	`{`
	`99`	`+ BaseUri = new Uri(_baseUri),`
`99`	`100`	`IgnoreUnmappedProperties = true`
`100`	`101`	`});`
`101`	`102`	`}`
`@@ -206,7 +207,7 @@ protected override void ProcessCompletedTask(AsyncDataSourcePageTaskHolder compl`
`206`	`207`	`return;`
`207`	`208`	`}`
`208`	`209`	`}`
`209`		`- catch (TaskCanceledException e)`
	`210`	`+ catch (TaskCanceledException)`
`210`	`211`	`{`
`211`	`212`	`RetryIndex(pageIndex, currentDelay);`
`212`	`213`	`//TODO: other exceptions? Is there a way to skip this state for canceled stuff?`
`@@ -436,7 +437,7 @@ private ISectionInformation[] ResolveGroupInformation()`
`436`	`437`
`437`	`438`	`return groupInformation.ToArray();`
`438`	`439`	`}`
`439`		`- catch (Exception e)`
	`440`	`+ catch (Exception)`
`440`	`441`	`{`
`441`	`442`	`return null;`
`442`	`443`	`}`
`@@ -518,7 +519,7 @@ private ISummaryResult[] ResolveSummaryInformation()`
`518`	`519`
`519`	`520`	`return CreateSummaryResults(summaryData);`
`520`	`521`	`}`
`521`		`- catch (Exception e)`
	`522`	`+ catch (Exception)`
`522`	`523`	`{`
`523`	`524`	`return null;`
`524`	`525`	`}`
`@@ -666,7 +667,6 @@ private DataSourceSchemaPropertyType ResolvePropertyType(string propertyName)`
`666`	`667`	`}`
`667`	`668`
`668`	`669`	`private string _filterString = null;`
`669`		`- private string _selectedString = null;`
`670`	`670`	`public const int SchemaRequestIndex = -1;`
`671`	`671`	`private SortDescriptionCollection _groupDescriptions;`
`672`	`672`	`private bool _isAggregationSupportedByServer = false;`