Skip to content

Commit 38795e9

Browse files
author
Benjamin Michaelis
committed
fix: prod concurrency cancel-in-progress false; remove dead CONTAINER_APP_ENVIRONMENT env var
- Change deploy-production cancel-in-progress from true to false to prevent broken state if deploy is cancelled mid-flight (secrets set but revision not yet updated) - Remove unused CONTAINER_APP_ENVIRONMENT env var from both dev and prod Assign MI steps (vestigial from az containerapp up era)
1 parent 08890a3 commit 38795e9

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

.github/workflows/Build-Test-And-Deploy.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ jobs:
139139
CONTAINER_APP_NAME: ${{ vars.CONTAINER_APP_NAME }}
140140
RESOURCEGROUP: ${{ vars.RESOURCEGROUP }}
141141
CONTAINER_REGISTRY: ${{ vars.DEVCONTAINER_REGISTRY }}
142-
CONTAINER_APP_ENVIRONMENT: ${{ vars.CONTAINER_APP_ENVIRONMENT }}
143142
KEYVAULTURI: ${{ secrets.ESSENTIALCSHARP_KEYVAULT_URI }}
144143
MANAGEDIDENTITYID: ${{ secrets.WEB_UAMI_RESOURCE_ID }}
145144
AZURECLIENTID: ${{ secrets.WEB_UAMI_CLIENT_ID }}
@@ -182,7 +181,7 @@ jobs:
182181
needs: [deploy-development]
183182
concurrency:
184183
group: deploy-production
185-
cancel-in-progress: true
184+
cancel-in-progress: false
186185
environment:
187186
name: "Production"
188187

@@ -232,7 +231,6 @@ jobs:
232231
CONTAINER_APP_NAME: ${{ vars.CONTAINER_APP_NAME }}
233232
RESOURCEGROUP: ${{ vars.RESOURCEGROUP }}
234233
CONTAINER_REGISTRY: ${{ vars.PRODCONTAINER_REGISTRY }}
235-
CONTAINER_APP_ENVIRONMENT: ${{ vars.CONTAINER_APP_ENVIRONMENT }}
236234
KEYVAULTURI: ${{ secrets.ESSENTIALCSHARP_KEYVAULT_URI }}
237235
MANAGEDIDENTITYID: ${{ secrets.WEB_UAMI_RESOURCE_ID }}
238236
AZURECLIENTID: ${{ secrets.WEB_UAMI_CLIENT_ID }}

0 commit comments

Comments
 (0)