Remove unnecessary constant from several scripts

Author: JasonNumberThirteen

Assets/Project/Scripts/Extensions/VectorExtensions.cs

@@ -2,10 +2,10 @@
 
 public static class VectorExtensions
 {
-	public static Vector3 ToTiledPosition(this Vector3 vector, float tileSize)
+	public static Vector3 ToTiledPosition(this Vector3 vector)
 	{
-		var x = MathMethods.GetTiledCoordinate(vector.x, tileSize);
-		var y = MathMethods.GetTiledCoordinate(vector.y, tileSize);
+		var x = MathMethods.GetTiledCoordinate(vector.x, 1);
+		var y = MathMethods.GetTiledCoordinate(vector.y, 1);
 
 		return new Vector3(x, y, 0f);
 	}

Assets/Project/Scripts/Game Objects/Map Tile/MapTile.cs

@@ -4,7 +4,6 @@
 [RequireComponent(typeof(MapTileNode))]
 public class MapTile : MonoBehaviour
 {
-	public static readonly float GRID_SIZE = 1f;
 	public static readonly int MIN_WEIGHT = -1;
 	public static readonly int MAX_WEIGHT = 10;
 

Assets/Project/Scripts/Managers/MapGenerationManager.cs

@@ -20,8 +20,8 @@ public class MapGenerationManager : MonoBehaviour
 
 	private Vector2 mapDimensions;
 
-	public Vector2 GetCenterOfMap() => (GetMapSize() - Vector2.one*MapTile.GRID_SIZE)*0.5f;
-	public Vector2 GetMapSize() => GetMapDimensions()*MapTile.GRID_SIZE;
+	public Vector2 GetCenterOfMap() => (GetMapSize() - Vector2.one)*0.5f;
+	public Vector2 GetMapSize() => GetMapDimensions();
 	public Vector2 GetMapDimensions() => mapDimensions;
 	public List<MapTile> GetMapTiles() => mapTiles;
 	public int GetMaximumMapDimension() => (int)Mathf.Max(mapDimensions.x, mapDimensions.y);
@@ -115,7 +115,7 @@ private List<MapTile> GetMapTilesToAdd(Vector2 newMapSize)
 
 				if(!mapTiles.Any(mapTile => (Vector2)mapTile.transform.position == position))
 				{
-					mapTilesToAdd.Add(Instantiate(mapTilePrefab, position*MapTile.GRID_SIZE, Quaternion.identity, goParentTransform));
+					mapTilesToAdd.Add(Instantiate(mapTilePrefab, position, Quaternion.identity, goParentTransform));
 				}
 			}
 		}

Assets/Project/Scripts/Managers/SelectedMapTileMovementManager.cs

@@ -93,7 +93,7 @@ private void Update()
 		}
 
 		var mapTileRealPosition = GetMousePositionToWorldPoint() + translationPositionOffset;
-		var mapTileTiledPosition = mapTileRealPosition.ToTiledPosition(MapTile.GRID_SIZE);
+		var mapTileTiledPosition = mapTileRealPosition.ToTiledPosition();
 
 		if(!DetectedAnyUnacceptableCollider(mapTileTiledPosition))
 		{
@@ -110,7 +110,7 @@ private Vector3 GetMousePositionToWorldPoint()
 
 	private bool DetectedAnyUnacceptableCollider(Vector2 position)
 	{
-		var collisionBoxSize = Vector2.one*MapTile.GRID_SIZE;
+		var collisionBoxSize = Vector2.one;
 		var collisionBoxSizeOffset = Vector2.one*COLLISION_BOX_SIZE_OFFSET;
 		var colliders = Physics2D.OverlapBoxAll(position, collisionBoxSize - collisionBoxSizeOffset, 0f, unacceptableGameObjects);
 

Assets/Project/Scripts/Static Methods/VectorMethods.cs

@@ -10,18 +10,17 @@ public static class VectorMethods
 
 	public static List<Vector2> GetDirectionsForFindingNeighbouringNodes(bool allowDiagonal)
 	{
-		var gridSize = MapTile.GRID_SIZE;
 		var directions = new List<Vector2>()
 		{
-			Vector2.up*gridSize,
-			Vector2.down*gridSize,
-			Vector2.left*gridSize,
-			Vector2.right*gridSize
+			Vector2.up,
+			Vector2.down,
+			Vector2.left,
+			Vector2.right
 		};
 
 		if(allowDiagonal)
 		{
-			directions.AddRange(GetNorthEastDirection()*gridSize, GetSouthEastDirection()*gridSize, GetSouthWestDirection()*gridSize, GetNorthWestDirection()*gridSize);
+			directions.AddRange(GetNorthEastDirection(), GetSouthEastDirection(), GetSouthWestDirection(), GetNorthWestDirection());
 		}
 
 		return directions;