Skip to content

Appcompat version 1.1.0 breaks resource interception #23

@pr0t3us

Description

@pr0t3us

Describe the bug
Updating Appcompat library to 1.1.0 on the app side stop's Philology intercepting the text value on devices with API levels 21-25. Since the problem doesn't reproduce on versions bellow 1.1.0-rc01 most likely it is caused by the 26079d8 commit (diff) with the description:

Turned out to be a gnarly framework bug on API levels 21-25. The test was failing due to the application Resources seemingly being updated when it shouldn't have been. Worked around by always using applyOverrideConfiguration() on those API levels, to force a new Resources instance.

To Reproduce

  1. Update the Appcompat by changing Dependencies#APP_COMPAT_VERSION to 1.1.0 or change implementation Dependencies.appCompat to implementation "androidx.appcompat:appcompat:1.1.0" just for the sample module.
  2. Run the sample app

Expected behavior
Philology should replace the text in the sample app based on the device locale.

Actual behavior
Philology doesn't replace the text in the sample app.

Logs/Screenshots

Library version
2.0.1

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinghelp wantedExtra attention is needed

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions