Skip to content

Commit 3fd1b2f

Browse files
authored
Fix release workflow network config for sigstore domains (#3487)
## Summary: The last fix for the release failed because I used a comma to separate the extra domains instead of a space. This broke the action and caused the release to fail. This PR just removes the comma and leave the space. Issue: <none> ## Test plan: - After merging, trigger a release (the push-to-main trigger should handle it, or manually via `gh workflow run publish.yml --ref main -f run_type=release`) - Confirm the publish succeeds and packages show up on npm with provenance Author: jeremywiebe Reviewers: claude[bot], nishasy, jeresig, SonicScrewdriver Required Reviewers: Approved By: nishasy, jeresig Checks: ✅ 11 checks were successful, ⏭️ 1 check has been skipped Pull Request URL: #3487
1 parent 89e94d6 commit 3fd1b2f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ jobs:
8282
conf-files: .github/npm-extra-domains.conf
8383
# hooks.slack.com: Slack webhook for publish success/failure notifications
8484
# fulcio.sigstore.dev,rekor.sigstore.dev: signing certificates are stored here
85-
extra-domains: hooks.slack.com, fulcio.sigstore.dev rekor.sigstore.dev
85+
extra-domains: hooks.slack.com fulcio.sigstore.dev rekor.sigstore.dev
8686

8787
- name: Install & cache node_modules
8888
uses: ./.github/actions/shared-node-cache

0 commit comments

Comments
 (0)