Drop support for SQS queues (#3651)

Using the database queue allows CDash to have more consistent control
over the behavior of the queue. Given that this isn't a particularly
high-performance queue, the database driver is sufficient for all use
cases.

Author: williamjallen

app/Jobs/ProcessSubmission.php

@@ -100,13 +100,7 @@ private function requeueSubmissionFile($buildid): bool
         // Requeue the file with exponential backoff.
         PendingSubmissions::where('buildid', $this->buildid)->increment('numfiles');
         $delay = ((int) config('cdash.retry_base')) ** $retry_handler->Retries;
-        if (config('queue.default') === 'sqs-fifo') {
-            // Special handling for sqs-fifo, which does not support per-message delays.
-            sleep(10);
-            self::dispatch($this->filename, $this->projectid, $buildid, $this->expected_md5);
-        } else {
-            self::dispatch($this->filename, $this->projectid, $buildid, $this->expected_md5)->delay(now()->addSeconds($delay));
-        }
+        self::dispatch($this->filename, $this->projectid, $buildid, $this->expected_md5)->delay(now()->addSeconds($delay));
 
         return true;
     }

composer.json

@@ -25,7 +25,6 @@
     "ext-xsl": "*",
     "ext-zlib": "*",
     "24slides/laravel-saml2": "2.4.2",
-    "aws/aws-sdk-php": "3.374.0",
     "directorytree/ldaprecord-laravel": "3.4.3",
     "guzzlehttp/guzzle": "7.10.0",
     "knplabs/github-api": "3.16.0",
@@ -39,7 +38,6 @@
     "pear/archive_tar": "1.6.0",
     "php-di/php-di": "7.1.1",
     "ramsey/uuid": "4.9.2",
-    "shiftonelabs/laravel-sqs-fifo-queue": "3.0.3",
     "socialiteproviders/github": "4.1.0",
     "socialiteproviders/gitlab": "4.1.0",
     "socialiteproviders/google": "4.1.0",

composer.lock

@@ -23,7 +23,7 @@
     | is used by your application. A default configuration has been added
     | for each back-end shipped with Laravel. You are free to add more.
     |
-    | Drivers: "sync", "database", "beanstalkd", "sqs", "null"
+    | Drivers: "sync", "database", "null"
     |
     */
 
@@ -38,36 +38,6 @@
             'queue' => 'default',
             'retry_after' => env('QUEUE_TIMEOUT', 2000) + 60,
         ],
-
-        'beanstalkd' => [
-            'driver' => 'beanstalkd',
-            'host' => 'localhost',
-            'queue' => 'default',
-            'retry_after' => env('QUEUE_TIMEOUT', 2000) + 60,
-        ],
-
-        'sqs' => [
-            'driver' => 'sqs',
-            'key' => env('SQS_KEY', 'your-public-key'),
-            'secret' => env('SQS_SECRET', 'your-secret-key'),
-            'prefix' => env('SQS_PREFIX', 'https://sqs.us-east-1.amazonaws.com/your-account-id'),
-            'queue' => env('SQS_QUEUE', 'your-queue-name'),
-            'region' => env('SQS_REGION', 'us-east-1'),
-        ],
-
-        'sqs-fifo' => [
-            'driver' => 'sqs-fifo',
-            'key' => env('SQS_KEY'),
-            'secret' => env('SQS_SECRET'),
-            'prefix' => env('SQS_FIFO_PREFIX', 'https://sqs.us-east-1.amazonaws.com/your-account-id'),
-            'queue' => env('SQS_FIFO_QUEUE', 'default.fifo'),
-            'suffix' => env('SQS_FIFO_SUFFIX'),
-            'region' => env('SQS_REGION', 'us-east-1'),
-            'after_commit' => false,
-            'group' => 'default',
-            'deduplicator' => env('SQS_FIFO_DEDUPLICATOR', 'unique'),
-            'allow_delay' => env('SQS_FIFO_ALLOW_DELAY', false),
-        ],
     ],
 
     /*

config/queue.php

@@ -24165,7 +24165,7 @@ parameters:
 		-
 			rawMessage: Binary operation "+" between 2000|bool|string and 60 results in an error.
 			identifier: binaryOp.invalid
-			count: 2
+			count: 1
 			path: config/queue.php
 
 		-