fix tests

Author: LD250

jenkins_cli/cli.py

@@ -44,7 +44,9 @@
                    }
 
 
-def get_formated_status(job_color, format_pattern="%(color)s%(symbol)s%(run_status)s%(endcollor)s", extra_params={}):
+def get_formated_status(job_color, format_pattern="%(color)s%(symbol)s%(run_status)s%(endcollor)s", extra_params=None):
+    if not extra_params:
+        extra_params = {}
     color_status = job_color.split('_')
     color = color_status[0]
     run_status = color_status[1] if len(color_status) == 2 else None
@@ -194,7 +196,7 @@ def setbranch(self, args):
         job_name = self._check_job(args.job_name)
         xml = self.jenkins.get_job_config(job_name)
         root = ElementTree.fromstring(xml.encode('utf-8'))
-        scm_name, branch_node = self._get_scm_name_and_node(root)
+        _, branch_node = self._get_scm_name_and_node(root)
         if branch_node is not None:
             branch_node.text = args.branch_name
             new_xml = xml_to_string(root)

tests/test_cli.py

@@ -191,7 +191,7 @@ def test_get_scm_name_and_node(self):
 
         root = ElementTree.fromstring(EMPTY_SCM_XML.encode('utf-8'))
         name, branch_node = JenkinsCli(self.args)._get_scm_name_and_node(root)
-        self.assertEqual(name, 'UnknownSCM')
+        self.assertEqual(name, 'UnknownVCS')
         self.assertEqual(branch_node, None)
 
     @mock.patch.object(jenkins.Jenkins, 'get_job_config')
@@ -202,7 +202,7 @@ def test_info(self, patched_get_job_name, patched_get_job_info, patched_get_job_
         patched_get_job_info.return_value = {}
         patched_get_job_config.return_value = EMPTY_SCM_XML
         JenkinsCli(self.args).info(self.args)
-        arg = JenkinsCli.INFO_TEMPLATE % ('Not Built', 'Not Built', 'Not Built', 'Not Built', 'No', 'UnknownSCM', 'Unknown branch')
+        arg = JenkinsCli.INFO_TEMPLATE % ('Not Built', 'Not Built', 'Not Built', 'Not Built', 'No', 'UnknownVCS', 'Unknown branch')
         self.patched_print.assert_called_once_with(arg)
         self.patched_print.reset_mock()
 
@@ -234,7 +234,7 @@ def test_setbranch(self, patched_get_job_name, patched_get_job_config, patched_r
         self.args.branch_name = 'b1'
         JenkinsCli(self.args).setbranch(self.args)
         self.assertFalse(patched_reconfig_job.called)
-        self.patched_print.assert_called_once_with("Can't set branch name")
+        self.patched_print.assert_called_once_with("Cannot set branch name")
         self.patched_print.reset_mock()
 
         patched_get_job_config.return_value = GIT_SCM_XML
@@ -289,7 +289,7 @@ def test_building(self, patched_job_name, patched_job_info, patched_build_info,
         JenkinsCli(self.args).building(self.args)
         self.assertFalse(patched_job_info.called)
         self.assertFalse(patched_build_info.called)
-        self.patched_print.assert_called_once_with("Nothing is building now")
+        self.patched_print.assert_called_once_with("Nothing is being built now")
         self.patched_print.reset_mock()
 
         get_jobs_patched.return_value = [{'name': 'Job1', 'color': 'blue_anime'},