feat: add setting to revert changes

This introduces a new setting in the "Startup" category that allows users to easily revert any changes made by the app.

Author: Lennoard

app/src/main/kotlin/com/androidvip/sysctlgui/ui/settings/SettingsScreen.kt

@@ -17,13 +17,15 @@ import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.size
-import androidx.compose.foundation.lazy.grid.GridCells
-import androidx.compose.foundation.lazy.grid.GridItemSpan
-import androidx.compose.foundation.lazy.grid.LazyVerticalGrid
+import androidx.compose.foundation.lazy.staggeredgrid.LazyVerticalStaggeredGrid
+import androidx.compose.foundation.lazy.staggeredgrid.StaggeredGridCells
+import androidx.compose.foundation.lazy.staggeredgrid.StaggeredGridItemSpan
 import androidx.compose.foundation.shape.RoundedCornerShape
+import androidx.compose.material3.AlertDialog
 import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.Text
+import androidx.compose.material3.TextButton
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
@@ -34,6 +36,7 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.platform.LocalUriHandler
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextAlign
@@ -60,8 +63,8 @@ import com.androidvip.sysctlgui.ui.settings.components.SwitchSettingComponent
 import com.androidvip.sysctlgui.ui.settings.components.TextSettingComponent
 import com.androidvip.sysctlgui.ui.settings.model.SettingsViewEffect
 import com.androidvip.sysctlgui.ui.settings.model.SettingsViewEvent
-import com.androidvip.sysctlgui.utils.browse
 import org.koin.androidx.compose.koinViewModel
+import com.androidvip.sysctlgui.data.R as DataR
 
 internal const val DISABLED_ALPHA = 0.38f
 
@@ -71,8 +74,10 @@ internal fun SettingsScreen(
     viewModel: SettingsViewModel = koinViewModel(),
     onNavigate: (UiRoute) -> Unit
 ) {
-    val state = viewModel.uiState.collectAsStateWithLifecycle()
+    val state by viewModel.uiState.collectAsStateWithLifecycle()
     val context = LocalContext.current
+    val uriHandler = LocalUriHandler.current
+    var showRevertChangesDialog by remember { mutableStateOf(false) }
     var hasNotificationPermission by remember {
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
             mutableStateOf(
@@ -117,7 +122,7 @@ internal fun SettingsScreen(
                 }
 
                 is SettingsViewEffect.OpenBrowser -> {
-                    context.browse(effect.url)
+                    uriHandler.openUri(effect.url)
                 }
 
                 is SettingsViewEffect.Navigate -> {
@@ -127,19 +132,27 @@ internal fun SettingsScreen(
                 is SettingsViewEffect.ShowToast -> {
                     Toast.makeText(context, effect.message, Toast.LENGTH_SHORT).show()
                 }
+
+                SettingsViewEffect.ShowRevertDialog -> {
+                    showRevertChangesDialog = true
+                }
             }
         }
     }
 
     SettingsScreenContent(
-        settings = state.value.settings,
+        settings = state.settings,
         onSettingHeaderClicked = { appSetting ->
             viewModel.onEvent(SettingsViewEvent.SettingHeaderClicked(appSetting))
         },
         onValueChanged = { appSetting, newValue ->
             viewModel.onEvent(SettingsViewEvent.SettingValueChanged(appSetting, newValue))
         }
     )
+
+    if (showRevertChangesDialog) {
+        RevertChangesDialog(onDismissRequest = { showRevertChangesDialog = false })
+    }
 }
 
 @Composable
@@ -152,15 +165,15 @@ private fun SettingsScreenContent(
     val columns = if (isLandscape()) 2 else 1
     val containerColor = MaterialTheme.colorScheme.surfaceContainer
 
-    LazyVerticalGrid(
-        columns = GridCells.Fixed(columns),
+    LazyVerticalStaggeredGrid(
+        columns = StaggeredGridCells.Fixed(columns),
         modifier = Modifier.fillMaxSize(),
         contentPadding = PaddingValues(16.dp),
-        verticalArrangement = Arrangement.spacedBy(16.dp),
+        verticalItemSpacing = 16.dp,
         horizontalArrangement = Arrangement.spacedBy(16.dp)
     ) {
         groupedSettings.forEach { (category, settingsGroup) ->
-            item(span = { GridItemSpan(columns) }) {
+            item {
                 Column(
                     modifier = Modifier
                         .fillMaxWidth()
@@ -187,7 +200,7 @@ private fun SettingsScreenContent(
             }
         }
 
-        item(span = { GridItemSpan(columns) }) {
+        item {
             Box(
                 modifier = Modifier
                     .clip(RoundedCornerShape(24.dp))
@@ -216,7 +229,7 @@ private fun SettingsScreenContent(
             }
         }
 
-        item(span = { GridItemSpan(columns) }) {
+        item(span = StaggeredGridItemSpan.FullLine) {
             Text(
                 text = "Developed with ❤️ by Lennoard Silva\nAndroid enthusiast 🤖",
                 style = MaterialTheme.typography.bodySmall,
@@ -297,6 +310,31 @@ private fun SettingsGroupItem(
     }
 }
 
+
+@Composable
+fun RevertChangesDialog(onDismissRequest: () -> Unit) {
+    AlertDialog(
+        onDismissRequest = onDismissRequest,
+        confirmButton = {
+            TextButton(onClick = onDismissRequest) {
+                Text(text = stringResource(android.R.string.ok))
+            }
+        },
+        icon = {
+            Icon(
+                painter = painterResource(R.drawable.ic_restore_settings),
+                contentDescription = null
+            )
+        },
+        title = {
+            Text(text = stringResource(DataR.string.prefs_startup_revert_changes))
+        },
+        text = {
+            Text(text = stringResource(DataR.string.prefs_startup_revert_changes_message))
+        }
+    )
+}
+
 @Composable
 @PreviewLightDark
 @Preview(device = "spec:parent=pixel_5,orientation=landscape")

app/src/main/kotlin/com/androidvip/sysctlgui/ui/settings/SettingsViewModel.kt

@@ -11,6 +11,7 @@ import com.androidvip.sysctlgui.domain.enums.SettingItemType
 import com.androidvip.sysctlgui.domain.models.KEY_CONTRIBUTORS
 import com.androidvip.sysctlgui.domain.models.KEY_DELETE_HISTORY
 import com.androidvip.sysctlgui.domain.models.KEY_MANAGE_PARAMS
+import com.androidvip.sysctlgui.domain.models.KEY_REVERT_CHANGES
 import com.androidvip.sysctlgui.domain.models.KEY_SOURCE_CODE
 import com.androidvip.sysctlgui.domain.models.KEY_TRANSLATIONS
 import com.androidvip.sysctlgui.domain.usecase.GetAppSettingsUseCase
@@ -78,6 +79,16 @@ class SettingsViewModel(
 
             is SettingsViewEvent.SettingHeaderClicked<*> -> {
                 when (event.appSetting.key) {
+                    KEY_REVERT_CHANGES -> {
+                        setEffect { SettingsViewEffect.ShowRevertDialog }
+                        viewModelScope.launch {
+                            sharedPreferences.edit(commit = true) {
+                                putBoolean(Prefs.RunOnStartup.key, false)
+                            }
+                            loadSettings()
+                        }
+                    }
+
                     KEY_MANAGE_PARAMS -> {
                         setEffect { SettingsViewEffect.Navigate(UiRoute.UserParams) }
                     }

app/src/main/kotlin/com/androidvip/sysctlgui/ui/settings/model/SettingsViewEvent.kt

@@ -13,6 +13,7 @@ sealed interface SettingsViewEffect {
     class OpenBrowser(val url: String) : SettingsViewEffect
     class Navigate(val route: UiRoute) : SettingsViewEffect
     class ShowToast(val message: String) : SettingsViewEffect
+    data object ShowRevertDialog : SettingsViewEffect
 }
 
 data class SettingsViewState(

data/src/main/java/com/androidvip/sysctlgui/data/repository/AppSettingsRepositoryImpl.kt

@@ -12,6 +12,7 @@ import com.androidvip.sysctlgui.domain.models.AppSetting
 import com.androidvip.sysctlgui.domain.models.KEY_CONTRIBUTORS
 import com.androidvip.sysctlgui.domain.models.KEY_DELETE_HISTORY
 import com.androidvip.sysctlgui.domain.models.KEY_MANAGE_PARAMS
+import com.androidvip.sysctlgui.domain.models.KEY_REVERT_CHANGES
 import com.androidvip.sysctlgui.domain.models.KEY_SOURCE_CODE
 import com.androidvip.sysctlgui.domain.models.KEY_TRANSLATIONS
 import com.androidvip.sysctlgui.domain.repository.AppSettingsRepository
@@ -171,6 +172,14 @@ class AppSettingsRepositoryImpl(
                 type = SettingItemType.Slider,
                 values = (0..10).toList(),
             ),
+            AppSetting(
+                key = KEY_REVERT_CHANGES,
+                value = Unit,
+                category = context.getString(R.string.prefs_category_startup),
+                title = context.getString(R.string.prefs_startup_revert_changes),
+                description = context.getString(R.string.prefs_startup_revert_changes_description),
+                type = SettingItemType.Text
+            ),
 
             ///////////  OTHERS  ////////////
             AppSetting(

data/src/main/res/values-pt-rBR/strings.xml

@@ -37,4 +37,7 @@
     <string name="pref_contributors_title">Contribuidores</string>
     <string name="pref_translations_title">Traduções</string>
     <string name="pref_translations_description">Ajude a traduzir este aplicativo</string>
+    <string name="prefs_startup_revert_changes">Reverter mudanças</string>
+    <string name="prefs_startup_revert_changes_description">Reverter alterações feitas por este aplicativo</string>
+    <string name="prefs_startup_revert_changes_message">Devido à natureza do kernel, as alterações feitas em tempo de execução podem ser revertidas com uma simples reinicialização do dispositivo. O aplicativo não tentará mais reaplicar as alterações após um ciclo de inicialização completo.</string>
 </resources>

data/src/main/res/values/strings.xml

@@ -37,4 +37,7 @@
     <string name="pref_contributors_title">Contributors</string>
     <string name="pref_translations_title">Translations</string>
     <string name="pref_translations_description">Help translate this application</string>
+    <string name="prefs_startup_revert_changes">Revert changes</string>
+    <string name="prefs_startup_revert_changes_description">Revert changes made by this app</string>
+    <string name="prefs_startup_revert_changes_message">By the nature of the kernel, changes done at runtime can be reverted by a simple device reboot. The app will no longer attempt to reapply changes right after a completed boot cycle.</string>
 </resources>

domain/src/main/java/com/androidvip/sysctlgui/domain/models/AppSetting.kt

@@ -32,6 +32,7 @@ data class AppSetting<T>(
     val iconResource: Int? = null
 )
 
+const val KEY_REVERT_CHANGES = "revertChanges"
 const val KEY_MANAGE_PARAMS = "manageParams"
 const val KEY_DELETE_HISTORY = "deleteHistory"
 const val KEY_SOURCE_CODE = "sauce"