refactor: Move exploreCheat from GM to GENERAL

Author: LightDestory

Commands/Commands_GM.lua

@@ -60,12 +60,6 @@ GM_genericCommands = {
     [GENERICS_command] = ".cheat taxi ",
     [GENERICS_message] = "logGM_cheatTaxi"
   },
-  [GM_cheatExploreMapsCommand] = {
-    [GENERICS_isValueNeeded] = true,
-    [GENERICS_isTargetCheckNeeded] = true,
-    [GENERICS_command] = ".cheat explore ",
-    [GENERICS_message] = "logGM_cheatExploreMaps"
-  },
   [GM_cheatWaterWalkCommand] = {
     [GENERICS_isValueNeeded] = true,
     [GENERICS_isTargetCheckNeeded] = true,

Commands/Commands_Generics.lua

@@ -15,6 +15,14 @@
 --
 -------------------------------------------------------------------------------------------------------------
 
+genericCommands = {
+    [cheatExploreMapsCommand] = {
+        [GENERICS_isValueNeeded] = true,
+        [GENERICS_isTargetCheckNeeded] = true,
+        [GENERICS_command] = ".cheat explore ",
+        [GENERICS_message] = "log_cheatExploreMaps"
+    },
+}
 function commandTargetCheck()
     return (MangAdmin:Selection("player") or MangAdmin:Selection("self") or MangAdmin:Selection("none"))
 end
@@ -28,8 +36,8 @@ function getCallsDictionary(ID)
         return GM_genericCommands
     elseif ID == CHAR_KEY then
         return CHAR_genericCommands
-    else
-        return nil
+    elseif ID == GENERAL_KEY then
+        return genericCommands
     end
 end
 

Commands/declarations/command_keys.lua

@@ -3,6 +3,7 @@ ON_OPTION = "on"
 OFF_OPTION = "off"
 
 -- Role identity Keys
+GENERAL_KEY = "GENERAL"
 GM_KEY = "GM"
 CHAR_KEY = "CHAR"
 
@@ -16,14 +17,15 @@ GENERICS_command = "command"
 GENERICS_message = "message"
 
 -- Spells Keys
+--General
+cheatExploreMapsCommand = "cheatExploreMaps"
 -- GM
 GM_displayAccountGMLevelCommand = "displayAccountLevel"
 GM_flyModeCommand = "flyMode"
 GM_godModeCommand = "godMode"
 GM_acceptWhispersCommand = "acceptWhispers"
 GM_visibilityCommand = "visibility"
 GM_cheatTaxiCommand = "cheatTaxi"
-GM_cheatExploreMapsCommand = "cheatExploreMaps"
 GM_cheatWaterWalkCommand = "cheatWaterWalk"
 GM_cheatNoCastTimeCommand = "cheatNoCastTime"
 GM_cheatNoCooldownCommand = "cheatNoCooldown"

FunctionInit.lua

@@ -113,16 +113,16 @@ function InitControls()
     )
     MangAdmin:PrepareScript(
             GM_cheatExploreMapsOnButton,
-            Locale["ttGM_cheatExploreMapsOn"],
+            Locale["tt_cheatExploreMapsOn"],
             function()
-                genericCaller(GM_KEY, GM_cheatExploreMapsCommand, "1")
+                genericCaller(GENERAL_KEY, cheatExploreMapsCommand, "1")
             end
     )
     MangAdmin:PrepareScript(
             GM_cheatExploreMapsOffButton,
-            Locale["ttGM_cheatExploreMapsOff"],
+            Locale["tt_cheatExploreMapsOff"],
             function()
-                genericCaller(GM_KEY, GM_cheatExploreMapsCommand, "0")
+                genericCaller(GENERAL_KEY, cheatExploreMapsCommand, "0")
             end
     )
     MangAdmin:PrepareScript(

Locales/enUS.lua

@@ -59,6 +59,8 @@ function Return_enUS()
     ["tt_closeWindow"] = "Close AzerothCoreAdmin",
     ["tt_clearParameterBox"] = "Clears the parameter box.",
     ["tt_bag"] = "Show the bag of the selected character or yours [[Parameters: $bagSlot: 0-4]]",
+    ["tt_cheatExploreMapsOn"] = "Reveals maps for the selected character.",
+    ["tt_cheatExploreMapsOff"] = "Hides maps for the selected character.",
     --[[General-Control Labels]]
     ["label_languageButton"] = "Change language",
     ["label_infoRevision"] = "|cFF00FF00AzerothCore rev:|r ", --Updated: Matched string output to AzerothCore
@@ -91,6 +93,7 @@ function Return_enUS()
     ["mustBeANumber"] = "Value must be a number!",
     ["log_resetSlider"] = "Reset slider to 1.0",
     ["log_bag"] = "Opened _T_'s bag on slot _V1_ ",
+    ["log_cheatExploreMaps"] = "Explore maps cheat for _T_ has been set to _V1_",
     --[[GM-Name]]
     ["tabname_GM"] = "GM",
     --[[GM-Tooltips]]
@@ -108,8 +111,6 @@ function Return_enUS()
     ["ttGM_visibilityOff"] = "Make you visible.",
     ["ttGM_cheatTaxiOn"] = "Show all taxi-routes to the selected player. This cheat will be deactivated on logout.",
     ["ttGM_cheatTaxiOff"] = "Deactivate the taxi-cheat and restore the players known taxi-routes.",
-    ["ttGM_cheatExploreMapsOn"] = "Reveals maps for the selected character.",
-    ["ttGM_cheatExploreMapsOff"] = "Hides maps for the selected character.",
     ["ttGM_cheatWaterWalkOn"] = "Turn Waterwalk ON for the selected character",
     ["ttGM_cheatWaterWalkOff"] = "Turn Waterwalk OFF for the selected character",
     ["ttGM_cheatNoCastTimeOn"] = "Disable spell's casting time",
@@ -231,7 +232,6 @@ function Return_enUS()
     ["logGM_acceptWhispers"] = "Turned accepting whispers to _V1_",
     ["logGM_visibility"] = "Turned your visibility to _V1_",
     ["logGM_cheatTaxi"] = "Taxi cheat for _T_ has been set to _V1_",
-    ["logGM_cheatExploreMaps"] = "Explore maps cheat for _T_ has been set to _V1_",
     ["logGM_cheatWaterWalk"] = "WaterWalk cheat for _T_ has been set to _V1_",
     ["logGM_cheatNoCastTime"] = "Turned NoCastTime to _V1_",
     ["logGM_cheatNoCooldown"] = "Turned NoCooldown to _V1_",