feat/fix: Add Learn/Unlearn Spell, fix LearnDropmenu

Author: LightDestory

Commands/Commands_Char.lua

@@ -423,8 +423,11 @@ function LearnAndUnlearnSpell(isLearn, value)
         elseif value == "all_lang" then
             MangAdmin:ChatMsg(command .. " all lang")
             MangAdmin:LogAction(log .. " all languages to " .. player .. ".")
+        elseif value == "all_default" then
+            MangAdmin:ChatMsg(command .. " all default")
+            MangAdmin:LogAction(log .. " all defaults to " .. player .. ".")
         elseif value == "all_myclass" then
-            MangAdmin:ChatMsg(command .. " all myclass")
+            MangAdmin:ChatMsg(command .. " all my class")
             MangAdmin:LogAction(log .. " all spells available to the "  .. "-class to " .. player .. ".")
         else
             MangAdmin:ChatMsg(command .. " " .. value)
@@ -464,7 +467,7 @@ function Modify(case, value)
             MangAdmin:ChatMsg(".modify mana " .. value)
             MangAdmin:LogAction("Modified mana for " .. player .. " to " .. value .. " mana")
         elseif case == "aspeed" then
-            MangAdmin:ChatMsg(".modify aspeed " .. value)
+            MangAdmin:ChatMsg(".modify speed all " .. value)
             MangAdmin:LogAction("Modified AllSpeeds for " .. player .. " to " .. value .. " mana")
         elseif case == "arena" then
             MangAdmin:ChatMsg(".modify arenapoints " .. value)
@@ -514,6 +517,10 @@ function LearnPresetDropDownInitialize()
     local info = UIDropDownMenu_CreateInfo()
     local buttons = {
         { Locale["labelCHAR_languageClass"], "all_lang" },
+        { Locale["labelCHAR_defaultClass"], "all_default" },
+        { Locale["labelCHAR_myClass"], "all_myclass" },
+        { Locale["labelCHAR_craftClass"], "all_crafts" },
+        { Locale["labelCHAR_GMClass"], "all_gm" },
         { Locale["labelCHAR_languageCommon"], "668" },
         { Locale["labelCHAR_languageOrcish"], "669" },
         { Locale["labelCHAR_languageTaurahe"], "670" },
@@ -588,7 +595,6 @@ function ResetDropDownInitialize()
     local level = 1
     local info = UIDropDownMenu_CreateInfo()
     local buttons = {
-        { Locale["labelCHAR_resetAchievementsOption"], "achievements" },
         { Locale["labelCHAR_resetHonorOption"], "honor" },
         { Locale["labelCHAR_resetLevelOption"], "level" },
         { Locale["labelCHAR_resetSpellsOption"], "spells" },
@@ -606,5 +612,5 @@ function ResetDropDownInitialize()
         info.keepShownOnClick = nil
         UIDropDownMenu_AddButton(info, level)
     end
-    UIDropDownMenu_SetSelectedValue(CHAR_resetDropdown, "achievements")
+    UIDropDownMenu_SetSelectedValue(CHAR_resetDropdown, "honor")
 end

Frames/MangFrames_SectionChar.lua

@@ -1268,6 +1268,46 @@ function MangAdmin:CreateCharSection()
         },
         text = Locale["label_bagButton"]
     })
+    -- Learn Button
+    FrameLib:BuildButton({
+        name = "CHAR_learnSpellButton",
+        group = "char",
+        parent = ma_midframe,
+        texture = {
+            name = "CHAR_learnSpellButton_texture",
+            color = { color.btn.r, color.btn.g, color.btn.b, transparency.btn }
+        },
+        size = {
+            width = 80,
+            height = 20
+        },
+        setpoint = {
+            pos = "TOPLEFT",
+            offX = 632, --charColSix
+            offY = -96 --charRowNine
+        },
+        text = Locale["labelCHAR_learnSpellButton"]
+    })
+    -- Unlearn Button
+    FrameLib:BuildButton({
+        name = "CHAR_unlearnSpellButton",
+        group = "char",
+        parent = ma_midframe,
+        texture = {
+            name = "CHAR_unlearnSpellButton_texture",
+            color = { color.btn.r, color.btn.g, color.btn.b, transparency.btn }
+        },
+        size = {
+            width = 80,
+            height = 20
+        },
+        setpoint = {
+            pos = "TOPLEFT",
+            offX = 632, --charColSix
+            offY = -118 --charRowNine
+        },
+        text = Locale["labelCHAR_unlearnSpellButton"]
+    })
     -- Learn Preset Dropdown
     FrameLib:BuildFrame({
         name = "CHAR_learnPresetDropdown",
@@ -1304,95 +1344,96 @@ function MangAdmin:CreateCharSection()
         },
         text = Locale["labelCHAR_learnPresetButton"]
     })
-    -- Modify Dropdown
+    -- Reset Dropdown
     FrameLib:BuildFrame({
-        name = "CHAR_modifyDropdown",
+        name = "CHAR_resetDropdown",
         group = "char",
         parent = ma_midframe,
         size = {
-            width = 80,
+            width = 40,
             height = 20
         },
         setpoint = {
             pos = "TOPLEFT",
-            offX = 315,
+            offX = 190,
             offY = 0
         },
         inherits = "UIDropDownMenuTemplate"
     })
-    -- Modify Input Box
-    FrameLib:BuildFrame({
-        type = "EditBox",
-        name = "CHAR_modifyInputBox",
+    -- Reset Button
+    FrameLib:BuildButton({
+        name = "CHAR_resetButton",
         group = "char",
         parent = ma_midframe,
+        texture = {
+            name = "CHAR_resetButton_texture",
+            color = { color.btn.r, color.btn.g, color.btn.b, transparency.btn }
+        },
         size = {
-            width = 30,
+            width = 40,
             height = 20
         },
         setpoint = {
             pos = "TOPLEFT",
-            offX = 455,
+            offX = 330,
             offY = -4
         },
-        inherits = "InputBoxTemplate"
+        text = Locale["labelCHAR_resetButton"]
     })
-    -- Modify Button
-    FrameLib:BuildButton({
-        name = "CHAR_modifyButton",
+    -- Modify Dropdown
+    FrameLib:BuildFrame({
+        name = "CHAR_modifyDropdown",
         group = "char",
         parent = ma_midframe,
-        texture = {
-            name = "CHAR_modifyButton_texture",
-            color = { color.btn.r, color.btn.g, color.btn.b, transparency.btn }
-        },
         size = {
-            width = 40,
+            width = 80,
             height = 20
         },
         setpoint = {
             pos = "TOPLEFT",
-            offX = 485,
-            offY = -4
+            offX = 365,
+            offY = 0
         },
-        text = Locale["labelCHAR_modifyButton"]
+        inherits = "UIDropDownMenuTemplate"
     })
-    -- Reset Dropdown
+    -- Modify Input Box
     FrameLib:BuildFrame({
-        name = "CHAR_resetDropdown",
+        type = "EditBox",
+        name = "CHAR_modifyInputBox",
         group = "char",
         parent = ma_midframe,
         size = {
-            width = 40,
+            width = 60,
             height = 20
         },
         setpoint = {
             pos = "TOPLEFT",
-            offX = 150,
-            offY = 0
+            offX = 505,
+            offY = -4
         },
-        inherits = "UIDropDownMenuTemplate"
+        inherits = "InputBoxTemplate"
     })
-    -- Reset Button
+    -- Modify Button
     FrameLib:BuildButton({
-        name = "CHAR_resetButton",
+        name = "CHAR_modifyButton",
         group = "char",
         parent = ma_midframe,
         texture = {
-            name = "CHAR_resetButton_texture",
+            name = "CHAR_modifyButton_texture",
             color = { color.btn.r, color.btn.g, color.btn.b, transparency.btn }
         },
         size = {
-            width = 40,
+            width = 50,
             height = 20
         },
         setpoint = {
             pos = "TOPLEFT",
-            offX = 285,
+            offX = 570,
             offY = -4
         },
-        text = Locale["labelCHAR_resetButton"]
+        text = Locale["labelCHAR_modifyButton"]
     })
+
     -- Input Box Label
     FrameLib:BuildFontString({
         name = "ma_parameterboxtext",

FunctionInit.lua

@@ -753,6 +753,21 @@ function InitControls()
             end
     )
 
+    MangAdmin:PrepareScript(
+            CHAR_learnSpellButton,
+            Locale["ttCHAR_learnSpell"],
+            function()
+                LearnAndUnlearnSpell(true, CHAR_genericCommands[GENERICS_parametersGet]())
+            end
+    )
+
+    MangAdmin:PrepareScript(
+            CHAR_unlearnSpellButton,
+            Locale["ttCHAR_unlearnSpell"],
+            function()
+                LearnAndUnlearnSpell(false, CHAR_genericCommands[GENERICS_parametersGet]())
+            end
+    )
 
     MangAdmin:PrepareScript(
             CHAR_learnPresetButton,
@@ -776,7 +791,7 @@ function InitControls()
             end
     )
     LearnPresetDropDownInitialize()
-    UIDropDownMenu_Initialize(CHAR_learnPresetDropdown, LearnLangDropDownInitialize)
+    UIDropDownMenu_Initialize(CHAR_learnPresetDropdown, LearnPresetDropDownInitialize)
     UIDropDownMenu_SetWidth(CHAR_learnPresetDropdown, 100)
     UIDropDownMenu_SetButtonWidth(CHAR_learnPresetDropdown, 20)
     ModifyDropDownInitialize()

Locales/enUS.lua

@@ -335,6 +335,8 @@ function Return_enUS()
     ["ttCHAR_modify"] = "Modify the selected attribute by the entered amount of the selected player",
     ["ttCHAR_reset"] = "Reset the selected attribute of the selected player",
     ["ttCHAR_learnPreset"] = "Learn the selected spell(s)",
+    ["ttCHAR_learnSpell"] = "Learn for selected player the specified spellID [[Parameters: $spellID]]",
+    ["ttCHAR_unlearnSpell"] = "Unlearn for selected player the specified spellID [[Parameters: $spellID]]",
     --[[CHAR-Control-Labels]]
     ["labelCHAR_killButton"] = "Kill",
     ["labelCHAR_reviveButton"] = "Revive",
@@ -390,6 +392,8 @@ function Return_enUS()
     ["labelCHAR_hideAreaButton"] = "HideArea",
     ["labelCHAR_honorAddButton"] = "HonorAdd",
     ["labelCHAR_honorUpdateButton"] = "HonorUpdt",
+    ["labelCHAR_learnSpellButton"] = "Learn Spell",
+    ["labelCHAR_unlearnSpellButton"] = "Unlearn Spell",
     ["labelCHAR_showMapsButton"] = "Show Maps",
     ["labelCHAR_hideMapsButton"] = "Hide Maps",
     ["labelCHAR_modifyButton"] = "Modify",
@@ -409,7 +413,7 @@ function Return_enUS()
     ["labelCHAR_modifyFlySpeedOption"] = "FlySpeed",
     ["labelCHAR_modifyGenderOption"] = "Gender",
     ["labelCHAR_modifyHonorOption"] = "Honor",
-    ["labelCHAR_modifyMountSpeedOption"] = "MountSpeed",
+    ["labelCHAR_modifyMountSpeedOption"] = "MountDisplay",
     ["labelCHAR_modifyPhaseOption"] = "Phase",
     ["labelCHAR_modifyRunicPowerOption"] = "RunicPower",
     ["labelCHAR_modifyStandSateOption"] = "StandState",
@@ -420,8 +424,11 @@ function Return_enUS()
     ["labelCHAR_resetSpellsOption"] = "Spells",
     ["labelCHAR_resetHonorOption"] = "Honor",
     ["labelCHAR_resetLevelOption"] = "Level",
-    ["labelCHAR_resetAchievementsOption"] = "Achievements",
     ["labelCHAR_languageClass"] = "All Class Langs",
+    ["labelCHAR_defaultClass"] = "All My Class Spells and Talents",
+    ["labelCHAR_myClass"] = "All Class Default",
+    ["labelCHAR_craftClass"] = "All Craft",
+    ["labelCHAR_GMClass"] = "All GM skills",
     ["labelCHAR_languageCommon"] = "Common",
     ["labelCHAR_languageOrcish"] = "Orcish",
     ["labelCHAR_languageTaurahe"] = "Taurahe",

TODO.md

@@ -1 +1,2 @@
-- Add to GM: reset all lvl 4
+- Add to GM: reset all lvl 4
+- Add reset achiemements