Skip to content

Commit a160ba1

Browse files
JeremiahM37julek-wolfssl
authored andcommitted
Supported_group unit test fix
1 parent 9d342ba commit a160ba1

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

tests/api/test_tls.c

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,15 @@ int test_tls12_curve_intersection(void) {
151151
struct test_memio_ctx test_ctx;
152152
int ret;
153153
const char* curve_name;
154-
154+
int test1[] = {WOLFSSL_ECC_SECP256R1};
155+
int test2[] = {WOLFSSL_ECC_SECP384R1};
156+
int test3[] = {WOLFSSL_ECC_SECP256R1, WOLFSSL_ECC_SECP384R1};
157+
int test4[] = {WOLFSSL_ECC_SECP384R1, WOLFSSL_ECC_SECP256R1};
155158
XMEMSET(&test_ctx, 0, sizeof(test_ctx));
156159
ExpectIntEQ(test_memio_setup(&test_ctx, &ctx_c, &ctx_s, &ssl_c, &ssl_s,
157160
wolfTLSv1_2_client_method, wolfTLSv1_2_server_method), 0);
158161
ExpectIntEQ(wolfSSL_set_groups(ssl_c,
159-
(int[]){WOLFSSL_ECC_SECP256R1}, 1), WOLFSSL_SUCCESS);
162+
test1, 1), WOLFSSL_SUCCESS);
160163
ExpectIntEQ(test_memio_do_handshake(ssl_c, ssl_s, 10, NULL), 0);
161164

162165
// Fix: Get curve name and compare with string comparison or use curve ID function
@@ -178,9 +181,9 @@ int test_tls12_curve_intersection(void) {
178181
ExpectIntEQ(test_memio_setup(&test_ctx, &ctx_c, &ctx_s, &ssl_c, &ssl_s,
179182
wolfTLSv1_2_client_method, wolfTLSv1_2_server_method), 0);
180183
ExpectIntEQ(wolfSSL_set_groups(ssl_c,
181-
(int[]){WOLFSSL_ECC_SECP384R1}, 1), WOLFSSL_SUCCESS);
184+
test2, 1), WOLFSSL_SUCCESS);
182185
ExpectIntEQ(wolfSSL_set_groups(ssl_s,
183-
(int[]){WOLFSSL_ECC_SECP256R1}, 1), WOLFSSL_SUCCESS);
186+
test1, 1), WOLFSSL_SUCCESS);
184187
ExpectIntNE(test_memio_do_handshake(ssl_c, ssl_s, 10, NULL), 0);
185188
ret = wolfSSL_get_error(ssl_s, WOLFSSL_FATAL_ERROR);
186189

@@ -200,10 +203,10 @@ int test_tls12_curve_intersection(void) {
200203
ExpectIntEQ(test_memio_setup(&test_ctx, &ctx_c, &ctx_s, &ssl_c, &ssl_s,
201204
wolfTLSv1_2_client_method, wolfTLSv1_2_server_method), 0);
202205
ExpectIntEQ(wolfSSL_set_groups(ssl_c,
203-
(int[]){WOLFSSL_ECC_SECP256R1, WOLFSSL_ECC_SECP384R1}, 2),
206+
test3, 2),
204207
WOLFSSL_SUCCESS);
205208
ExpectIntEQ(wolfSSL_set_groups(ssl_s,
206-
(int[]){WOLFSSL_ECC_SECP384R1, WOLFSSL_ECC_SECP256R1}, 2),
209+
test4, 2),
207210
WOLFSSL_SUCCESS);
208211
ExpectIntEQ(test_memio_do_handshake(ssl_c, ssl_s, 10, NULL), 0);
209212

@@ -228,12 +231,13 @@ int test_tls13_curve_intersection(void) {
228231
WOLFSSL *ssl_c = NULL, *ssl_s = NULL;
229232
struct test_memio_ctx test_ctx;
230233
const char* curve_name;
234+
int test1[] ={WOLFSSL_ECC_SECP256R1};
231235

232236
XMEMSET(&test_ctx, 0, sizeof(test_ctx));
233237
ExpectIntEQ(test_memio_setup(&test_ctx, &ctx_c, &ctx_s, &ssl_c, &ssl_s,
234238
wolfTLSv1_3_client_method, wolfTLSv1_3_server_method), 0);
235239
ExpectIntEQ(wolfSSL_set_groups(ssl_c,
236-
(int[]){WOLFSSL_ECC_SECP256R1}, 1), WOLFSSL_SUCCESS);
240+
test1, 1), WOLFSSL_SUCCESS);
237241
ExpectIntEQ(test_memio_do_handshake(ssl_c, ssl_s, 10, NULL), 0);
238242

239243
curve_name = wolfSSL_get_curve_name(ssl_s);

0 commit comments

Comments
 (0)