TODOs and package clean up

fan-zhang-sv · fan-zhang-sv · commit 182ccf7c84fa · 2024-08-09T10:08:06.000-07:00
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -31,15 +31,13 @@
     "@noble/ciphers": "^0.5.3",
     "@noble/curves": "^1.4.2",
     "@noble/hashes": "^1.4.0",
-    "clsx": "^1.2.1",
     "eventemitter3": "^5.0.1"
   },
   "peerDependencies": {
     "@react-native-async-storage/async-storage": "*",
     "expo": "*",
     "expo-web-browser": "*",
     "react": "*",
-    "react-dom": "*",
     "react-native": "*"
   },
   "devDependencies": {
@@ -51,7 +49,6 @@
     "@peculiar/webcrypto": "^1.4.3",
     "@react-native-async-storage/async-storage": "^1.24.0",
     "@testing-library/jest-dom": "^5.17.0",
-    "@testing-library/preact": "^2.0.1",
     "@testing-library/react": "14.3.1",
     "@types/jest": "^27.5.2",
     "@types/node": "^14.18.54",
diff --git a/packages/client/src/components/communicator/webBased/Communicator.ts b/packages/client/src/components/communicator/webBased/Communicator.ts
@@ -5,6 +5,7 @@ import { HashedContent } from './types';
 import { standardErrors } from ':core/error';
 import { MessageID, RPCRequestMessage, RPCResponseMessage } from ':core/message';
 
+// TODO: singleton pattern
 export class WebBasedWalletCommunicator implements CommunicatorInterface {
   static communicators = new Map<string, WebBasedWalletCommunicator>();
 
diff --git a/packages/client/src/core/cipher/cipher.ts b/packages/client/src/core/cipher/cipher.ts
@@ -143,6 +143,7 @@ export async function encryptContent(
 
 export async function decryptContent<R extends RPCRequest | RPCResponse>(
   encryptedData: {
+    // TODO: this is temp
     iv: unknown;
     cipherText: unknown;
   },
diff --git a/packages/client/src/core/provider/interface.ts b/packages/client/src/core/provider/interface.ts
@@ -37,6 +37,7 @@ export interface AppMetadata {
   /** Application name */
   appName: string;
   /** Application logo image URL; favicon is used if unspecified */
+  // TODO: make this required
   appLogoUrl?: string;
   /** Array of chainIds your dapp supports */
   appChainIds?: number[];
diff --git a/packages/client/src/interfaces/eip1193/EIP1193Provider.ts b/packages/client/src/interfaces/eip1193/EIP1193Provider.ts
@@ -33,6 +33,7 @@ export class EIP1193Provider extends ProviderEventEmitter implements ProviderInt
       if (!this.client) throw standardErrors.rpc.internal('MWPClient not initialized');
 
       if (args.method === 'eth_requestAccounts') {
+        // TODO: emit connect
         const accounts = await this.client.handshake();
         return accounts;
       }
diff --git a/yarn.lock b/yarn.lock
@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ export class EIP1193Provider extends ProviderEventEmitter implements ProviderInt`
`33`	`33`	`if (!this.client) throw standardErrors.rpc.internal('MWPClient not initialized');`
`34`	`34`
`35`	`35`	`if (args.method === 'eth_requestAccounts') {`
	`36`	`+ // TODO: emit connect`
`36`	`37`	`const accounts = await this.client.handshake();`
`37`	`38`	`return accounts;`
`38`	`39`	`}`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
 +# yarn lockfile v1
++
++