Skip to content

Commit af4a2cb

Browse files
committed
Randomizing resource group and leaving in tfvars only the min the cust needs to mod
1 parent c25d0c2 commit af4a2cb

4 files changed

Lines changed: 34 additions & 27 deletions

File tree

quickstart/201-k8s-cluster-with-aks-applicationgateway-ingress/main.tf

Lines changed: 25 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
1-
# # Locals block for hardcoded names.
1+
# Randomized resource group name to ensure uniqueness in your environment
2+
resource "random_pet" "rg-name" {
3+
prefix = var.name_prefix
4+
}
5+
6+
resource "azurerm_resource_group" "default" {
7+
name = random_pet.rg-name.id
8+
location = var.location
9+
}
10+
11+
# Locals block for hardcoded names
212
locals {
313
backend_address_pool_name = "${azurerm_virtual_network.test.name}-beap"
414
frontend_port_name = "${azurerm_virtual_network.test.name}-feport"
@@ -10,13 +20,13 @@ locals {
1020
}
1121

1222
data "azurerm_resource_group" "rg" {
13-
name = var.resource_group_name
23+
name = azurerm_resource_group.default.name
1424
}
1525

1626
# User Assigned Identities
1727
resource "azurerm_user_assigned_identity" "testIdentity" {
18-
resource_group_name = data.azurerm_resource_group.rg.name
19-
location = data.azurerm_resource_group.rg.location
28+
resource_group_name = azurerm_resource_group.default.name
29+
location = azurerm_resource_group.default.location
2030

2131
name = "identity1"
2232

@@ -25,8 +35,8 @@ resource "azurerm_user_assigned_identity" "testIdentity" {
2535

2636
resource "azurerm_virtual_network" "test" {
2737
name = var.virtual_network_name
28-
location = data.azurerm_resource_group.rg.location
29-
resource_group_name = data.azurerm_resource_group.rg.name
38+
location = azurerm_resource_group.default.location
39+
resource_group_name = azurerm_resource_group.default.name
3040
address_space = [var.virtual_network_address_prefix]
3141

3242
subnet {
@@ -45,22 +55,22 @@ resource "azurerm_virtual_network" "test" {
4555
data "azurerm_subnet" "kubesubnet" {
4656
name = var.aks_subnet_name
4757
virtual_network_name = azurerm_virtual_network.test.name
48-
resource_group_name = data.azurerm_resource_group.rg.name
58+
resource_group_name = azurerm_resource_group.default.name
4959
depends_on = [azurerm_virtual_network.test]
5060
}
5161

5262
data "azurerm_subnet" "appgwsubnet" {
5363
name = "appgwsubnet"
5464
virtual_network_name = azurerm_virtual_network.test.name
55-
resource_group_name = data.azurerm_resource_group.rg.name
65+
resource_group_name = azurerm_resource_group.default.name
5666
depends_on = [azurerm_virtual_network.test]
5767
}
5868

5969
# Public Ip
6070
resource "azurerm_public_ip" "test" {
6171
name = "publicIp1"
62-
location = data.azurerm_resource_group.rg.location
63-
resource_group_name = data.azurerm_resource_group.rg.name
72+
location = azurerm_resource_group.default.location
73+
resource_group_name = azurerm_resource_group.default.name
6474
allocation_method = "Static"
6575
sku = "Standard"
6676

@@ -69,8 +79,8 @@ resource "azurerm_public_ip" "test" {
6979

7080
resource "azurerm_application_gateway" "network" {
7181
name = var.app_gateway_name
72-
resource_group_name = data.azurerm_resource_group.rg.name
73-
location = data.azurerm_resource_group.rg.location
82+
resource_group_name = azurerm_resource_group.default.name
83+
location = azurerm_resource_group.default.location
7484

7585
sku {
7686
name = var.app_gateway_sku
@@ -153,18 +163,18 @@ resource "azurerm_role_assignment" "ra3" {
153163
}
154164

155165
resource "azurerm_role_assignment" "ra4" {
156-
scope = data.azurerm_resource_group.rg.id
166+
scope = azurerm_resource_group.default.id
157167
role_definition_name = "Reader"
158168
principal_id = azurerm_user_assigned_identity.testIdentity.principal_id
159169
depends_on = [azurerm_user_assigned_identity.testIdentity, azurerm_application_gateway.network]
160170
}
161171

162172
resource "azurerm_kubernetes_cluster" "k8s" {
163173
name = var.aks_name
164-
location = data.azurerm_resource_group.rg.location
174+
location = azurerm_resource_group.default.location
165175
dns_prefix = var.aks_dns_prefix
166176

167-
resource_group_name = data.azurerm_resource_group.rg.name
177+
resource_group_name = azurerm_resource_group.default.name
168178

169179
linux_profile {
170180
admin_username = var.vm_user_name

quickstart/201-k8s-cluster-with-aks-applicationgateway-ingress/output.tf

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
output "resource_group_name" {
2+
value = azurerm_resource_group.default.name
3+
}
4+
15
output "client_key" {
26
value = azurerm_kubernetes_cluster.k8s.kube_config.0.client_key
37
}
Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
1-
resource_group_name = "<Name of the Resource Group already created>"
2-
3-
location = "<Location of the Resource Group>"
1+
aks_service_principal_app_id = "<Service principal appId>"
42

5-
aks_service_principal_app_id = "<Service Principal AppId>"
3+
aks_service_principal_client_secret = "<Service principal password>"
64

7-
aks_service_principal_client_secret = "<Service Principal Client Secret>"
8-
9-
aks_service_principal_object_id = "<Service Principal Object Id>"
5+
aks_service_principal_object_id = "<Service principal object ID>"

quickstart/201-k8s-cluster-with-aks-applicationgateway-ingress/variables.tf

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
variable "resource_group_name" {
2-
description = "Name of the resource group."
3-
}
4-
51
variable "location" {
6-
description = "Location of the cluster."
2+
default = "eastus"
3+
description = "Location of the cluster"
74
}
85

96
variable "aks_service_principal_app_id" {

0 commit comments

Comments
 (0)