Skip to content

Commit c01f39b

Browse files
committed
kp: kp_set_mode: Avoid unnecessary checks for arguments
The kernel wont even compile if the required arguments are not passed so its unnecessary to check for them again in the function. Also while there, move auto_kprofiles check in kp_set_mode_rollback() to avoid initializing mutex locks when auto_kprofiles is disabled. Signed-off-by: Dakkshesh <dakkshesh5@gmail.com>
1 parent 216edf2 commit c01f39b

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

main.c

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,20 @@ void kp_set_mode_rollback(unsigned int level, unsigned int duration_ms)
5757
return;
5858
#endif
5959

60+
if (!auto_kprofiles)
61+
return;
62+
6063
if (unlikely(level > 3)) {
6164
pr_err("%s: Invalid mode requested, Skipping mode change",
6265
__func__);
6366
return;
6467
}
6568

6669
mutex_lock(&kplock);
67-
if (level && duration_ms && auto_kprofiles) {
68-
kp_override_mode = level;
69-
kp_override = true;
70-
msleep(duration_ms);
71-
kp_override = false;
72-
}
70+
kp_override_mode = level;
71+
kp_override = true;
72+
msleep(duration_ms);
73+
kp_override = false;
7374
mutex_unlock(&kplock);
7475
}
7576

@@ -94,7 +95,7 @@ void kp_set_mode(unsigned int level)
9495
return;
9596
}
9697

97-
if (level && auto_kprofiles)
98+
if (auto_kprofiles)
9899
kp_mode = level;
99100
}
100101

0 commit comments

Comments
 (0)