more file checks

Signed-off-by: John Seekins <john.seekins@spoileralert.com>

Author: johnseekins

.lefthook.yml

@@ -56,8 +56,11 @@ pre-commit:
     - name: check for merge conflicts
       run: tools/check-merge-conflicts.sh {staged_files}
 
-    - name: check for file format
-      run: tools/check-file-format.sh {staged_files}
+    - name: check for bad file details
+      run: tools/check-file-details.sh {staged_files}
+      env:
+        - FILE_SIZE: 107374182400
+      stage_fixed: true
 
 output:
   - success

.pre-commit-config.yaml

@@ -4,16 +4,8 @@ repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v6.0.0
     hooks:
-      - id: check-json
-      - id: trailing-whitespace
       - id: end-of-file-fixer
       - id: check-added-large-files
         args:
           - "--maxkb=5000"
-      - id: check-merge-conflict
       - id: check-symlinks
-
-  - repo: https://github.com/igorshubovych/markdownlint-cli
-    rev: v0.45.0
-    hooks:
-      - id: markdownlint

main.py

@@ -0,0 +1,61 @@
+#!/usr/bin/env bash
+
+set -eou pipefail
+
+SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
+pushd "${SCRIPT_DIR}" > /dev/null || exit 1
+pushd "$(git rev-parse --show-toplevel)" > /dev/null || exit 1
+
+. tools/.library.sh
+
+if [[ $# -eq 0 ]]; then
+	FILES=$(git_files | xargs)
+else
+	FILES=$*
+fi
+SHEBANG_FIXED=()
+WHITESPACE_TO_FIX=()
+FILE_SIZE=${FILE_SIZE:-5000}
+TOO_BIG=()
+exit_code=0
+
+for fn in ${FILES}; do
+	set +e
+	shebang=$(grep -l "^#!/" "${fn}")
+	if [[ -n "${shebang}" && ! -x "${fn}" ]]; then
+		chmod +x "${fn}"
+		SHEBANG_FIXED+=("${fn}")
+		exit_code=1
+	fi
+	set +e
+	# grep exits non-0 when it doesn't find anything
+	whitespace=$(grep -l ' +$' "${fn}")
+	set -e
+	if [[ -n "${whitespace}" ]]; then
+		WHITESPACE_TO_FIX+=("${whitespace}")
+		exit_code=1
+	fi
+	size=$(stat --printf="%s" "${fn}")
+	if [[ "${size}" -gt "${FILE_SIZE}" ]]; then
+		TOO_BIG+=("${fn}: ${size}")
+		exit_code=1
+	fi
+done
+
+if [[ "${#SHEBANG_FIXED[@]}" -gt 0 ]]; then
+	echo "Fixed executable bit on:"
+	printf '\t%s\n' "${SHEBANG_FIXED[@]}"
+fi
+if [[ "${#WHITESPACE_TO_FIX[@]}" -gt 0 ]]; then
+	echo "Should clean whitespace on:"
+	printf '\t%s\n' "${WHITESPACE_TO_FIX[@]}"
+fi
+
+if [[ "${#TOO_BIG[@]}" -gt 0 ]]; then
+	echo "Files larger than ${FILE_SIZE}:"
+	printf '\t%s\n' "${TOO_BIG[@]}"
+fi
+
+popd > /dev/null || exit 1
+popd > /dev/null || exit 1
+exit "${exit_code}"

tools/check-file-details.sh

@@ -13,17 +13,22 @@ if [[ $# -eq 0 ]]; then
 else
 	FILES=$*
 fi
-exit_code=0
 
+TO_FIX=()
+exit_code=0
+set +e
 for fn in ${FILES}; do
-	if [[ "${fn}" == *".sh" || "${fn}" == *".zsh" || "${fn}" == *".bash" ]]; then
-		if [[ ! -x "${fn}" ]]; then
-			echo "${fn} is not executable, but probably should be"
-			exit_code=1
-		fi
+	found=$(grep -l ' +$' "${fn}")
+	if [[ -n "${found}" ]]; then
+		TO_FIX+=("${found}")
+		exit_code=1
 	fi
 done
+set -e
 
+if [[ "${#TO_FIX[@]}" -gt 0 ]]; then
+	printf '%s\n' "${TO_FIX[@]}"
+fi
 popd > /dev/null || exit 1
 popd > /dev/null || exit 1
 exit "${exit_code}"