Skip to content

Saving wrong networking settings in UserSettings.json #1226

@yoshi-sheep

Description

@yoshi-sheep

Problem

When I save networking settings, wrong protocol is saved in the UserSettings.json. For example, if I save the settings while selecting UDP, GUI saves Serial protocol settings instead. I checked the code and found out that swith statements in SessionSettings class does not corresponde to the protocols variable in W_Networking class.

The order of the protocol is different in those classes.

W_Networking: "UDP", "LSL", "OSC", "Serial"
SessionSettings: "Serial", "LSL", "UDP", "OSC"

I think you just forgot to change the order in SessionSettings class when you updated networking protocol dropdown order in Commit c94e160.

Operating System and Version

Windows 10

GUI Version

v6.0.0-beta.1

Are you running the downloaded app or from Processing/VSCode?

Both app and VSCode

Type of OpenBCI Board

Ganglion

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions