Fix and optimize the handling logic of Inputs and Outputs (#35)

Signed-off-by: laminar <fangtian@kubesphere.io>

Author: tpiperatgod

context/context.go

@@ -7,7 +7,6 @@ import (
 	"fmt"
 	"net/http"
 	"os"
-	"reflect"
 	"strconv"
 	"strings"
 	"sync"
@@ -333,7 +332,7 @@ func NewResponseWriterWrapper(w http.ResponseWriter, statusCode int) *ResponseWr
 }
 
 func (ctx *FunctionContext) Send(outputName string, data []byte) ([]byte, error) {
-	if ctx.HasOutputs() {
+	if !ctx.HasOutputs() {
 		return nil, errors.New("no output")
 	}
 
@@ -384,19 +383,17 @@ func (ctx *FunctionContext) Send(outputName string, data []byte) ([]byte, error)
 }
 
 func (ctx *FunctionContext) HasInputs() bool {
-	nilInputs := map[string]*Input{}
-	if reflect.DeepEqual(ctx.Inputs, nilInputs) {
-		return false
+	if len(ctx.GetInputs()) > 0 {
+		return true
 	}
-	return true
+	return false
 }
 
 func (ctx *FunctionContext) HasOutputs() bool {
-	nilOutputs := map[string]*Output{}
-	if reflect.DeepEqual(ctx.Outputs, nilOutputs) {
-		return false
+	if len(ctx.GetOutputs()) > 0 {
+		return true
 	}
-	return true
+	return false
 }
 
 func (ctx *FunctionContext) ReturnOnSuccess() Out {
@@ -694,17 +691,17 @@ func parseContext() (*FunctionContext, error) {
 	ctx.Event = &EventRequest{}
 	ctx.SyncRequest = &SyncRequest{}
 
-	if !ctx.HasInputs() {
-		for name, in := range ctx.Inputs {
+	if ctx.HasInputs() {
+		for name, in := range ctx.GetInputs() {
 			if _, err := getBuildingBlockType(in.ComponentType); err != nil {
 				klog.Errorf("failed to get building block type for input %s: %v", name, err)
 				return nil, err
 			}
 		}
 	}
 
-	if !ctx.HasOutputs() {
-		for name, out := range ctx.Outputs {
+	if ctx.HasOutputs() {
+		for name, out := range ctx.GetOutputs() {
 			if _, err := getBuildingBlockType(out.ComponentType); err != nil {
 				klog.Errorf("failed to get building block type for output %s: %v", name, err)
 				return nil, err

context/context_test.go

@@ -208,6 +208,37 @@ func TestParseFunctionContext(t *testing.T) {
 		t.Fatal("Error set function context env")
 	}
 
+	// test `inputs`, `outputs` fields
+	if err := os.Setenv(FunctionContextEnvName, funcCtx); err == nil {
+		if ctx, err := GetRuntimeContext(); err != nil {
+			t.Fatalf("Error parse function context: %s", err.Error())
+		} else {
+			// test `inputs`
+			if !ctx.HasInputs() || len(ctx.GetInputs()) != 2 {
+				t.Fatal("Error parse function context: failed to parse inputs")
+			}
+			if cron, exist := ctx.GetInputs()["cron"]; exist {
+				if cron.Uri == "cron_input" && cron.ComponentType == "bindings.cron" {
+
+				} else {
+					t.Fatal("Error parse function context: failed to parse input cron")
+				}
+			}
+
+			// test `outputs`
+			if !ctx.HasOutputs() || len(ctx.GetOutputs()) != 3 {
+				t.Fatal("Error parse function context: failed to parse outputs")
+			}
+			if echo, exist := ctx.GetOutputs()["echo"]; exist {
+				if path, exist := echo.Metadata["path"]; exist && echo.Uri == "echo" && path == "echo" {
+
+				} else {
+					t.Fatal("Error parse function context: failed to parse output echo")
+				}
+			}
+		}
+	}
+
 	// test `prePlugins`, `postPlugins`, `pluginsTracing` fields
 	if err := os.Setenv(FunctionContextEnvName, funcCtxWithPlugins); err == nil {
 		if ctx, err := GetRuntimeContext(); err != nil {

context/innerevent.go

@@ -3,7 +3,6 @@ package context
 import (
 	"encoding/json"
 	"fmt"
-	"reflect"
 	"sync"
 	"time"
 
@@ -167,7 +166,7 @@ func (inner *innerEvent) Clone(event *cloudevents.Event) {
 }
 
 func (inner *innerEvent) save() {
-	if inner.cloudevent == nil || (inner.data != nil && reflect.DeepEqual(inner.data.Metadata, map[string]string{}) && inner.data.UserData == nil) {
+	if inner.cloudevent == nil || (inner.data != nil && len(inner.data.Metadata) > 0 && inner.data.UserData == nil) {
 		fmt.Println(inner.data.UserData)
 		return
 	}