Skip to content

Commit 17002ed

Browse files
authored
[CI] Add approval check for logging-related modifications (#7429)
1 parent de0c5e6 commit 17002ed

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

scripts/check_approval.sh

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,25 @@ if [ "${HAS_ENV_MODIFY}" != "" ] && [ "${PR_ID}" != "" ]; then
7777
check_approval "$echo_line1" 1 Jiang-Jia-Jun yuanlehome rainyfly Wanglongzhi2001
7878
fi
7979

80+
LOG_KEYWORDS=(
81+
"\.info\("
82+
"\.debug\("
83+
"\.error\("
84+
"log_request\("
85+
"log_request_error"
86+
)
87+
88+
HAS_LOG_MODIFY=$(git diff upstream/$BRANCH \
89+
-- . ':(exclude)scripts/check_approval.sh' \
90+
| grep -E "^\+" \
91+
| grep -vE "^\+\+\+" \
92+
| grep -E $(printf -- "%s|" "${LOG_KEYWORDS[@]}" | sed 's/|$//') || true)
93+
94+
if [ -n "${HAS_LOG_MODIFY}" ] && [ -n "${PR_ID}" ]; then
95+
echo_line1="You must have one FastDeploy RD (xyxinyang(zhouchong), zyyzghb(zhangyongyue)) approval for modifying logging behavior (.info/.debug/.error/log_request)."
96+
check_approval "$echo_line1" 1 xyxinyang zyyzghb
97+
fi
98+
8099
if [[ "${BRANCH}" != "develop" ]] && [[ -n "${PR_ID}" ]]; then
81100
pr_info=$(curl -H "Authorization: token ${GITHUB_TOKEN}" \
82101
https://api.github.com/repos/PaddlePaddle/FastDeploy/pulls/${PR_ID})

0 commit comments

Comments
 (0)