Merge pull request #135 from RandomAPI/bugfix/rug-133

Remove spaces from email address #133

Author: keitharm

api/1.3/api.js

@@ -170,7 +170,7 @@ class Generator {
           timezone
         });
 
-        this.include('email', tr.transliterate(name[0]) + '.' + tr.transliterate(name[1]).replace(/ /g, '') + '@example.com');
+        this.include('email', tr.transliterate(`${name[0]}.${name[1]}`).replace(/ /g, '') + '@example.com');
 
         let salt = random(2, 8);
         let password = this.password === undefined ? randomItem(this.datasets.common.passwords) : this.genPassword();

spec/api/modern/1.3.js

@@ -5,6 +5,19 @@ const defVersion = "1.3";
 
 module.exports = (server, version=defVersion) => {
 
+  describe(`Email address formatting`, () => {
+
+    // No spaces in email address
+    it(`should not include spaces in email address`, async () => {
+      const res = await request(server).get(`/api/${version}?results=5000&inc=email`);
+      const result = JSON.parse(res.text);
+
+      expect(result.results.every(user => {
+        return user.email.indexOf(' ') === -1;
+      })).to.equal(true);
+    });
+  });
+
   // 1.3 should support all previous version features as well
   describe(`Checking support of previous version features`, () => {
     describe('1.2', require('./1.2').bind(this, server, version));