#41 Dark mode on Windows

Author: Ravbug

source/Info.plist

@@ -28,7 +28,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>1.57</string>
+	<string>1.58</string>
 	<key>CFBundleSignature</key>
 	<string>UNHn</string>
 	<key>CFBundleVersion</key>

source/activation.cpp

@@ -94,9 +94,9 @@ void PersonalActivationDlg::OnActivateHit(wxCommandEvent&)
 
 void PlusProActivationDlg::OnActivateHit(wxCommandEvent&)
 {
-	const std::string& username = plusProActivUsernameCtrl->GetValue();
-    const std::string& password = plusProActivPasswordCtrl->GetValue();
-    const std::string& serial = plusProActivationSerialCtrl->GetValue();
+	const std::string& username = plusProActivUsernameCtrl->GetValue().ToStdString();
+    const std::string& password = plusProActivPasswordCtrl->GetValue().ToStdString();
+    const std::string& serial = plusProActivationSerialCtrl->GetValue().ToStdString();
 
 	auto cmd = fmt::format("{} -batchmode -username {} -password {} -serial {} -quit",the_editor.executablePath().string(),username,password,serial);
 

source/globals.cpp

@@ -31,7 +31,6 @@ void reveal_in_explorer(const std::filesystem::path& path) {
 		std::string command = "xdg-open \"" + path.string() + "\"";
 		launch_process(command);
 #elif defined _WIN32
-
 		PIDLIST_ABSOLUTE pidl; 
 		SFGAOF attributes; 
 		HRESULT hr = SHParseDisplayName(path.c_str(), nullptr, &pidl, 0, &attributes);

source/globals.h

@@ -14,7 +14,7 @@
 static constexpr std::string_view projectsFile = "projects.txt";
 static constexpr std::string_view editorPathsFile = "editorPaths.txt";
 static constexpr std::string_view templatePrefix = "com.unity.template";
-static constexpr std::string_view AppVersion = "v1.57";
+static constexpr std::string_view AppVersion = "v1.58";
 
 struct wxListCtrl;
 struct wxWindow;

source/interface_derived.cpp

@@ -83,7 +83,9 @@ MainFrameDerived::MainFrameDerived() : MainFrame(NULL){
 	#elif defined _WIN32
 		int status = mkdir(datapath.string().c_str());
 		//on windows also make the main window background white
-		this->SetBackgroundColour(*wxWHITE);
+        if (!wxSystemSettings::GetAppearance().IsDark()) {
+            this->SetBackgroundColour(*wxWHITE);
+        }
 		//high DPI scaling fixes
 		dpi_scale(this);
 		//set reveal label
@@ -95,7 +97,7 @@ MainFrameDerived::MainFrameDerived() : MainFrame(NULL){
 	#if defined __linux__
 	launchHubBtn->Hide();
 	#endif
-	
+
 	//if no projects to load, the interface will be blank
 
 	//show current version in titlebar
@@ -211,7 +213,7 @@ void MainFrameDerived::Filter(wxKeyEvent &){
     wxListEvent e;
     OnDeselectProject(e);
     projects.clear();
-    auto filter = projSearchCtrl->GetValue();
+    auto filter = projSearchCtrl->GetValue().ToStdString();
     transform(filter.begin(), filter.end(), filter.begin(), ::tolower);
     LoadProjects(filter);
 }

source/main.cpp

@@ -20,19 +20,23 @@
 class UnityHubNative: public wxApp
 {
 public:
-    virtual bool OnInit();
+	virtual bool OnInit();
 };
 
 wxIMPLEMENT_APP(UnityHubNative);
 bool UnityHubNative::OnInit()
 {
+#if _WIN32
+	MSWEnableDarkMode();
+#endif
     MainFrame *frame = new MainFrameDerived();
 	//set the icon (windows and linux only)
 #ifdef _WIN32
 	//name is the same as the one used in the resource file definition
 	//the resource file definition must have the same ending as the name of the icon file itself
 	//in this case, the icon file is wxwin.ico, so the definition is IDI_WXWIN
 	frame->SetIcon(wxIcon("IDI_WXWIN"));
+	SetAppearance(Appearance::System);
 #elif __linux
 	frame->SetIcon(wxIcon(wxICON(wxlin)));
 #endif

wxWidgets/.circleci/config.yml

@@ -5,14 +5,44 @@
 # It's supported by Git 2.23 or later and to use it by default for all the
 # future git-blame invocations, run the following command:
 #
-#   git config blame.ignoreRevsFile misc/git/ignore_revs
+#   git config blame.ignoreRevsFile .git-blame-ignore-revs
+#
+# When adding entries to this file, please keep them in reverse chronological
+# order (the newest ones are added at the top).
+#
+# You can use
+#
+#   $ git show -s --format='# %s, %cs%n%H%n'
+#
+# incantation to directly create an entry in the format used here.
+
+# Add missing spaces after compound statement keywords, 2024-12-23
+216232fd7c92d067c21ef28f12d7fc3020441ea8
+
+# Get rid of obsoleted comments, 2023-02-05
+2df05fb915516e0563578e34aec45980be51b1f4
+
+# Code cleanup: wxPGProperty helper classes, 2023-01-06
+e43190ea796ac3c1d15c18a88bcf7f3f745bd4bc
+
+# Get rid of commented out code, 2022-10-26
+db31a0161503c6ea4cc461f4e10b67830b7d6b52
+
+# Use nullptr instead of NULL in the code and documentation, 2022-10-18
+4f4c5fcfdfe7d1eadce22a68929c82b6cb324075
 
 # Fix comment typos in sources, 2021-10-02
 668a2186cd89fd4576bed224df3624811eebeca1
 
+# Wrap variable initializations after '=' consistently, 2019-11-22
+2bc6e50eded2a14099655ce0b4c7df582b87c93a
+
 # Remove all trailing spaces, 2019-01-30
 8fbca5cb70c8b647d5bd2cacb1e0a2a00358f351
 
+# Remove more wxT() macros from samples, 2018-09-29
+b70ed2d8c84cadf10bd42fc052a255fac02391e4
+
 # Remove (most) occurrences of wxT() macro from the samples, 2018-09-23
 f58ea625968953ca93585ea7f93dcc07ad032d8f
 
@@ -22,7 +52,7 @@ f58ea625968953ca93585ea7f93dcc07ad032d8f
 # Remove all lines containing cvs/svn "$Id$" keyword.
 3f66f6a5b3583b02c34854556eb83e3a808524ce
 
-# No changes, just removed hard tabs and trailing white space., 2009-08-21)
+# No changes, just removed hard tabs and trailing white space., 2009-08-21
 03647350fc7cd141953c72e0284e928847d30f44
 
 # Globally replace _T() with wxT()., 2009-07-23
@@ -41,9 +71,15 @@ a3ef8eb50346e04c080ed1711578390080baff8b
 # classes), gridctrl.cpp (for wxGridCellRenderer-derived classes), 2009-01-11
 29efc6e4a478652d6f59fb3f5ca7990d78a8ead4
 
+# removed trailing whitespace, 2007-11-27
+b9db5f3061af49519c56e9981d627a5b206507f3
+
 # cleanup - reformatting, 2006-04-20
 a9339fe22c1815cfbbf2ed9c300c897256644d18
 
+# Source cleaning, warning fixes., 2005-01-13
+2ad1ff540f036e130ed934066b80652c2c5fe158
+
 # Code cleaning: wxID_ANY, wxDefaultSize, wxDefaultPosition, true, false,
 # wxEmptyString, tabs and white spaces, 2004-06-17
 ca65c0440a7163e4e37e48b1c4329709d722db47